From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A144CC2D0E4 for ; Fri, 20 Nov 2020 17:21:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 082282225B for ; Fri, 20 Nov 2020 17:21:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="aPLZipbF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 082282225B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 61B496B005C; Fri, 20 Nov 2020 12:21:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CD3D6B005D; Fri, 20 Nov 2020 12:21:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46C946B006C; Fri, 20 Nov 2020 12:21:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 19C996B005C for ; Fri, 20 Nov 2020 12:21:05 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A8A5D8249980 for ; Fri, 20 Nov 2020 17:21:04 +0000 (UTC) X-FDA: 77505462048.27.title44_2814be62734d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 80E673D668 for ; Fri, 20 Nov 2020 17:21:04 +0000 (UTC) X-HE-Tag: title44_2814be62734d X-Filterd-Recvd-Size: 4107 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Nov 2020 17:21:03 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id u19so14528278lfr.7 for ; Fri, 20 Nov 2020 09:21:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GlV8pwcEGIYETl/1da0CIt2CMOjh6NH0hFTF8FaV9w8=; b=aPLZipbFsCt2Yos6Yko2GrdSgzPihXm60TQPOA7NGZ5VvB7ocksqPeYdNO3e2q29NU Z8ZKmmpTjwzES3DfJ3UOJGbnRii1eNywcHonAkHLcguNFmjUlxXQnC0/UwyCvYQdxogq lqfTsnMWVxdHCIZ0bFWiu9c/ZkeBmZ5QTNKuc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GlV8pwcEGIYETl/1da0CIt2CMOjh6NH0hFTF8FaV9w8=; b=j43SefEaA9bKgSQc8OWgDmpi1qtiR3SOaswWp3QZm/r3AMVANKtV7MBziLYozMi7/8 GvJ5xY8r/k4FE01/lgXqfRGYpsBMMj2lY/AK+URd9a6nMe0egqGSHrnlDFT4iS3yfTuF 5qnA73Gff9nrMAinVe/BJDUa6NwtJkyaSJrn/eziHI51H7E8J2K5cFSk/fkUwEl9/kRx 4fpfKQ0KAZJt7K5uVCA1TrqP4xviYDxowVlkmGJESEjmd6voC6DLG4C5PCPubKpmaQBr 7AB6WHQK6cQvfRqpdyqOTye8n8vuC8rQSYdX/gIZAoWOa+8p7105EpPonP3i0MN7NkcN ciyA== X-Gm-Message-State: AOAM5305CoHNQHTa5JvpDQ9P6EQcoreW1iDm+Az/svxqUCQ9ZTJubXvj FWRs1keVl8do1PITmitvYFC72KU8e1vt/Q== X-Google-Smtp-Source: ABdhPJyn6Nbfiij8FxNIGWZ/0I+xrqOUeQSyTJd13AK1ho+R6pXhdGW2aoZJWIjtkQL21q1OeYILhA== X-Received: by 2002:a19:6b07:: with SMTP id d7mr8682984lfa.509.1605892862017; Fri, 20 Nov 2020 09:21:02 -0800 (PST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id 201sm409044lfk.152.2020.11.20.09.20.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2020 09:20:59 -0800 (PST) Received: by mail-lf1-f45.google.com with SMTP id v144so14469879lfa.13 for ; Fri, 20 Nov 2020 09:20:59 -0800 (PST) X-Received: by 2002:a19:ed0f:: with SMTP id y15mr7580125lfy.352.1605892859115; Fri, 20 Nov 2020 09:20:59 -0800 (PST) MIME-Version: 1.0 References: <20201120143557.6715-1-will@kernel.org> <20201120143557.6715-4-will@kernel.org> In-Reply-To: <20201120143557.6715-4-will@kernel.org> From: Linus Torvalds Date: Fri, 20 Nov 2020 09:20:43 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/6] tlb: mmu_gather: Remove unused start/end arguments from tlb_finish_mmu() To: Will Deacon Cc: Linux Kernel Mailing List , Android Kernel Team , Catalin Marinas , Yu Zhao , Minchan Kim , Peter Zijlstra , Anshuman Khandual , Linux-MM , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 20, 2020 at 6:36 AM Will Deacon wrote: > > tlb_finish_mmu() takes two confusing and unused 'start'/'end' address > arguments. Remove them. Ack, but please add the history to it. Those arguments were used, up until 7a30df49f63a ("mm: mmu_gather: remove __tlb_reset_range() for force flush"). And the thing is, using a range flush in theory might be better, but for simplicity it's now doing a "fullmm" one, which is why those arguments no longer matter. (And I think we track the range better now too, which may be another reason they aren't needed) Linus Linus