From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 959BDC433FE for ; Fri, 18 Nov 2022 20:27:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EC706B0074; Fri, 18 Nov 2022 15:27:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 275376B0075; Fri, 18 Nov 2022 15:27:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EF188E0001; Fri, 18 Nov 2022 15:27:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F16BF6B0074 for ; Fri, 18 Nov 2022 15:27:03 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C31F41414BB for ; Fri, 18 Nov 2022 20:27:03 +0000 (UTC) X-FDA: 80147697126.23.7DE3659 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf21.hostedemail.com (Postfix) with ESMTP id 4D71F1C000D for ; Fri, 18 Nov 2022 20:27:03 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id jr19so3889301qtb.7 for ; Fri, 18 Nov 2022 12:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=debetX+RiAoZ60gEyg+EiA1gcFjja9cf9U11elr9U+o=; b=QuReE7pDtEDmXS8ooywCd1z/6wqgabIk9k1P/wOLRqgenWXns6rpp9eA5g1qg4hdCb UEMOkz/J79Sp7kIM60GSRBJPiZTGXtjRc/DxOoqy/ebinql3uKzAOJBZ7nEfYESvatJG HxrLAWgC9NTL7Gakym5+FKleG7YdojP43DXrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=debetX+RiAoZ60gEyg+EiA1gcFjja9cf9U11elr9U+o=; b=06eepRpvz2JoTHJJwnId4GHP3HbX7e2DUxbC3iq6PyPSiChD+tRNeo+oP3jdQv1zjp w9HBtH91XRbW28loqjdiLNsUzFIGl//W2hEK0F00BmkykjscB/ufalmcoxJuO2s4dacZ GeenldFwFUjineGSgIsXGk73zqiW2Ot0xjN8HB+xM8qKAl0M8/ujVU67pP1oriAr3UR3 e30SGQp5QSotqbgi/IUZi+jtdM1n2kXVFOGNkwZ8kHeJRMDAvJia8NTQSQ5m59Cr84C0 8Jc97NU4XN6KBzemRPM4wslREi3sWr+CQhx6pe/UrrmMAXU+V/WnP0MKcTiZQyCqKTrX bPRw== X-Gm-Message-State: ANoB5pkinh8QPK5BdD8NPX+zfDudsLnJq3GmWeJXOKK/VTP921yR9+lz y0HgrS8W9s686PJPtQMgAfVYpZ0Ieku4oQ== X-Google-Smtp-Source: AA0mqf6SHnLTmdtGeXvOarrOnRjb6xw2BMSMgKAZeB6cQ4pgMXqOhs4sXQqLsGufnizudRdROcf5dQ== X-Received: by 2002:ac8:12cb:0:b0:3a5:bd9:5d8b with SMTP id b11-20020ac812cb000000b003a50bd95d8bmr8208121qtj.399.1668803222255; Fri, 18 Nov 2022 12:27:02 -0800 (PST) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com. [209.85.222.177]) by smtp.gmail.com with ESMTPSA id q16-20020a37f710000000b006b95b0a714esm3002720qkj.17.2022.11.18.12.27.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 12:27:02 -0800 (PST) Received: by mail-qk1-f177.google.com with SMTP id x18so4257276qki.4 for ; Fri, 18 Nov 2022 12:27:01 -0800 (PST) X-Received: by 2002:ac8:518b:0:b0:3a5:49fa:3983 with SMTP id c11-20020ac8518b000000b003a549fa3983mr8046289qtn.436.1668802737937; Fri, 18 Nov 2022 12:18:57 -0800 (PST) MIME-Version: 1.0 References: <5f52de70-975-e94f-f141-543765736181@google.com> In-Reply-To: From: Linus Torvalds Date: Fri, 18 Nov 2022 12:18:42 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3] mm,thp,rmap: rework the use of subpages_mapcount To: Hugh Dickins Cc: Andrew Morton , Johannes Weiner , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Vlastimil Babka , Peter Xu , Yang Shi , John Hubbard , Mike Kravetz , Sidhartha Kumar , Muchun Song , Miaohe Lin , Naoya Horiguchi , Mina Almasry , James Houghton , "Zach O'Keefe" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668803223; a=rsa-sha256; cv=none; b=33CSSWkUt3qP6PYmmidKHwz5ToEHhfD6bIvHQ/oEIb8oW2d2OJQkzybp8B17YRCEKW19bI TazzOuw/+0StF8KNmk4Rb/48ygr9fBxQQtvcPIimkKAjyyiauOO7/7c5lB8GjAo2N5N4RM 73lu0BTiEUyXRnIIEtPAGpjXN3ldRLQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=QuReE7pD; dmarc=none; spf=pass (imf21.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.179 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668803223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=debetX+RiAoZ60gEyg+EiA1gcFjja9cf9U11elr9U+o=; b=twHCY1MDpr9t8DIYfHYhuGzXnRUBeGgDbqnI398ZIV/BSH3Tf4jefptyhDvXsU5iXrDtY+ GDXWRaU83Q7+gzlYaDnLBBiJp3dmG2FjZayI52CJZD4G2cXAaPqTrbcgt/3ow9DcFwG4ar ny6/F7zZaT/3XgGb3oscqGhabEo7Vpw= X-Stat-Signature: agwr75wp9io7aonntqojid3w1441crmc X-Rspamd-Queue-Id: 4D71F1C000D X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=QuReE7pD; dmarc=none; spf=pass (imf21.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.179 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspamd-Server: rspam09 X-HE-Tag: 1668803223-178889 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 18, 2022 at 1:08 AM Hugh Dickins wrote: > > Linus was underwhelmed by the earlier compound mapcounts series: > this series builds on top of it (as in next-20221117) to follow > up on his suggestions - except rmap.c still using lock_page_memcg(), > since I hesitate to steal the pleasure of deletion from Johannes. This looks good to me. Particularly 2/3 made me go "Aww, yes" but the overall line removal stats look good too. That said, I only looked at the patches, and not the end result itself. But not having the bit spin lock is, I think, a huge improvement. I do wonder if this should be now just merged with your previous series - it looks a bit odd how your previous series adds that bitlock, only for it to be immediately removed. But if you think the logic ends up being easier to follow this way as two separate patch series, I guess I don't care. And the memcg locking is entirely a separate issue, and I hope Johannes will deal with that. Thanks, Linus