From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 476B8C433EF for ; Thu, 24 Feb 2022 17:49:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD6888D0002; Thu, 24 Feb 2022 12:49:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B601F8D0001; Thu, 24 Feb 2022 12:49:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FFC28D0002; Thu, 24 Feb 2022 12:49:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 8DC0A8D0001 for ; Thu, 24 Feb 2022 12:49:47 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5275A8248D52 for ; Thu, 24 Feb 2022 17:49:47 +0000 (UTC) X-FDA: 79178411214.20.0F9ED2D Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf03.hostedemail.com (Postfix) with ESMTP id E225F2000C for ; Thu, 24 Feb 2022 17:48:36 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id g20so3938851edw.6 for ; Thu, 24 Feb 2022 09:48:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V24rdVNExs0ytTjnUGhgxI/0/+mvlDmfxrFtfTJbU7k=; b=MqCTqeHdkuXEQpvlJXoh1OEtSmCm3/vJpMIdKfSRYxXCnRpR9JWvac/hzemxQZ3MD0 Kzi9XUTdpnPdGHtDJfxWlY38lY9yU59vtizG+bwXlKZ2nQuR3bn/Qa98DqRJsct4Mv7/ z9sDCGNQjAGR6Nt543jn58ZCWn14cODxguj6k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V24rdVNExs0ytTjnUGhgxI/0/+mvlDmfxrFtfTJbU7k=; b=FrRJzaa8g3TowRWXahuLnpLHnq0UJQENpflnS0qwfWZujdAHqbwH+/IE9tdz05dBge o1kW3c9QAT3zn8WulI1rW0IWE7c/ghCOzKLDrVLbsL6o2lM3PbPd/b4bmT3K4y9pXN5I bejKCsIGkEkNAxWwjkqkb3SM+PGwrwtM78/MD7AI02Si+hHu5lL2ifVbcvLh+sZKDpGF IfmOHTYcPhFUgN25wZEVj8KWSytXxN+KTrhlBxinx1bCnUBkBtul7cgGefxnKvjVPbqv uwPDyHUB0wNAgh/RxbZv98TkqH+IFbm9tH1BHK1uw1EsdWdWeYWroSJmq9RtM/0+ifVO cYkQ== X-Gm-Message-State: AOAM5316mTAgoZVRr/tMdaR8JQPTkWmjQIuNVG2M4ZYwVAEdk059p3iB ZLP3Mmw8PzprBZgrLyHrnZpywj8stM4BT8b0gCE= X-Google-Smtp-Source: ABdhPJwgsKVJQFDjZWXM4ja8YoIYJhryPUEZffvuTO9Vdp1HZVs1+7Jjgh9BbM8jZOQ8P9LLwrawVA== X-Received: by 2002:a50:d659:0:b0:413:4da0:1ef3 with SMTP id c25-20020a50d659000000b004134da01ef3mr3381116edj.423.1645724915231; Thu, 24 Feb 2022 09:48:35 -0800 (PST) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com. [209.85.218.45]) by smtp.gmail.com with ESMTPSA id w20-20020a50f114000000b00405ef64c174sm63241edl.57.2022.02.24.09.48.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 09:48:33 -0800 (PST) Received: by mail-ej1-f45.google.com with SMTP id lw4so5928088ejb.12 for ; Thu, 24 Feb 2022 09:48:31 -0800 (PST) X-Received: by 2002:a05:6512:e8a:b0:443:7b8c:579a with SMTP id bi10-20020a0565120e8a00b004437b8c579amr2497656lfb.687.1645724900775; Thu, 24 Feb 2022 09:48:20 -0800 (PST) MIME-Version: 1.0 References: <20220224122614.94921-1-david@redhat.com> <20220224122614.94921-6-david@redhat.com> <064ba776-e6c6-a430-7d74-0b691123e2a9@redhat.com> In-Reply-To: <064ba776-e6c6-a430-7d74-0b691123e2a9@redhat.com> From: Linus Torvalds Date: Thu, 24 Feb 2022 09:48:04 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC 05/13] mm/rmap: remove do_page_add_anon_rmap() To: David Hildenbrand Cc: Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , Linux-MM Content-Type: text/plain; charset="UTF-8" X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=MqCTqeHd; spf=pass (imf03.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E225F2000C X-Stat-Signature: pxbtq7cscmwtojsoi3gxtyoxrfje91pp X-HE-Tag: 1645724916-923748 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 24, 2022 at 9:41 AM David Hildenbrand wrote: > > Actually, I thought about doing it similarly to what I did in > page_alloc.c with fpi_t: > > typedef int __bitwise fpi_t; > > #define FPI_NONE ((__force fpi_t)0) > > I can do something similar here. Yeah, that looks good. And then the relevant function declarations and definitions also have that explicit type there instead of 'int', which adds a bit more documentation for people grepping for use. Thanks, Linus