From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E98C10F14 for ; Wed, 2 Oct 2019 17:52:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F22120815 for ; Wed, 2 Oct 2019 17:52:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Da0ulCjd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F22120815 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9401C6B0003; Wed, 2 Oct 2019 13:52:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EFCB6B0006; Wed, 2 Oct 2019 13:52:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DE2C6B0007; Wed, 2 Oct 2019 13:52:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 589426B0003 for ; Wed, 2 Oct 2019 13:52:51 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id DC32252B9 for ; Wed, 2 Oct 2019 17:52:50 +0000 (UTC) X-FDA: 75999590100.18.wood55_7017c43a8f152 X-HE-Tag: wood55_7017c43a8f152 X-Filterd-Recvd-Size: 4315 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Oct 2019 17:52:50 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id y23so18040272lje.9 for ; Wed, 02 Oct 2019 10:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0VOcSracTGyf4mK2cc8NxpSFCIaTLGVQfCgFGzC2+os=; b=Da0ulCjd0PWlr56Q/iV7hdkQdtwUT8ixbTGX4LSwlckf+LITNN+ccC7tnrfWsIqQ4r JnegAs8ZTFN9xZOuObzFgcKxcd186SCrtXmPd6NGd53CGHLFSbmJJuT9KnKj5cBidD3J 5wEL+dn/3c15t74OVss9Lc34yPo5x+E/J4t6Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0VOcSracTGyf4mK2cc8NxpSFCIaTLGVQfCgFGzC2+os=; b=E6P4Wmw8NCuY/coNDpqtWKm2j8Msmc0Bm7WZjcPklwZdGRzg2olXu5Z4ynkWU5Lwdi VzVtfZCb3VYlEOXjFQ1/pZyq9vE+VBo2RXv0KAGegFuMAVpGL8WX0anKLeY62Riq/zFA v9lawoLQmDof2sq2vdmCvHZU/GeSMy0r8Lbn8t78sc6gc2NLzCVfgn6bXjSUEruNqoTu CFGkcTpfK3b5urQ/cze0D+pzQxXfmCRspeti/aiMwurDYIO1FuBToOxDGFOxSxOqr+Zj 16VrVvzHCjJDXPIx4BY1NJryBxQ5U7G5hKb1G06Wko30I5KmDE9C/gj5s+NQfKzcp7TL 6cPg== X-Gm-Message-State: APjAAAVGJMkVcCVCoxHYQQTtoVws4l3xQm851twq6uqzV+0Nxy43huEV KfKHfQLW262XyNZ5VfLt2+US102K4To= X-Google-Smtp-Source: APXvYqzPY/raG49OG0wVPNEz2Gb08h+hfr5GnPuRjX7INKS+32a8kEdOrUNm+7id0ZOPGkrbLhPwiQ== X-Received: by 2002:a2e:8907:: with SMTP id d7mr3268492lji.15.1570038767482; Wed, 02 Oct 2019 10:52:47 -0700 (PDT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com. [209.85.208.170]) by smtp.gmail.com with ESMTPSA id t6sm19044ljd.102.2019.10.02.10.52.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Oct 2019 10:52:46 -0700 (PDT) Received: by mail-lj1-f170.google.com with SMTP id m7so18092723lji.2 for ; Wed, 02 Oct 2019 10:52:45 -0700 (PDT) X-Received: by 2002:a2e:551:: with SMTP id 78mr3363688ljf.48.1570038765543; Wed, 02 Oct 2019 10:52:45 -0700 (PDT) MIME-Version: 1.0 References: <20191002134730.40985-1-thomas_os@shipmail.org> <20191002134730.40985-3-thomas_os@shipmail.org> In-Reply-To: <20191002134730.40985-3-thomas_os@shipmail.org> From: Linus Torvalds Date: Wed, 2 Oct 2019 10:52:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code To: =?UTF-8?Q?Thomas_Hellstr=C3=B6m_=28VMware=29?= Cc: Linux-MM , Linux Kernel Mailing List , Thomas Hellstrom , Andrew Morton , Matthew Wilcox , Will Deacon , Peter Zijlstra , Rik van Riel , Minchan Kim , Michal Hocko , Huang Ying , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , "Kirill A . Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 2, 2019 at 6:47 AM Thomas Hellstr=C3=B6m (VMware) wrote: > > From: Thomas Hellstrom > > For users that want to travers all page table entries pointing into a > region of a struct address_space mapping, introduce a walk_page_mapping() > function. This looks non-offensive to me. My main reaction was "oh, really good that we split up the walker ops from the mm_walk structure, this would have been much uglier before that" due to the added vma entry/exit ops. Linus