From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCC2BC7EE2E for ; Fri, 26 May 2023 01:40:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAA7B900003; Thu, 25 May 2023 21:40:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E59AB900002; Thu, 25 May 2023 21:40:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D20DF900003; Thu, 25 May 2023 21:40:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C2920900002 for ; Thu, 25 May 2023 21:40:36 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8D14680AE6 for ; Fri, 26 May 2023 01:40:36 +0000 (UTC) X-FDA: 80830701672.27.400F509 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 7F1101C0005 for ; Fri, 26 May 2023 01:40:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=AN6ZZ1Qj; dmarc=none; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.173 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685065234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mm58cdLmSJ5zDiAtA58RWN5FnFQJSGcvSIirliOWuIM=; b=aazRUFemOwtmzDu1H7lzWYP6qZ9Cjvxo3rVCaIYBxz4iUgRAO118j5Vu1wsG0VdCwAtBZG 0fdWvmyKetbmfjGMC1962XbVaJ2klcyISBT+SbkLu6sLDLaxhtTln7rYE0XIvj125sVw5g 9dzKB7YegQOkJtHv+uSJ4gEJduKZgrA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=AN6ZZ1Qj; dmarc=none; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.173 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685065234; a=rsa-sha256; cv=none; b=sKfm76esQxuZWB+uIIT3KAshx5fCyCGTwVqHQkc60fMwu+Zrp9DsIaDCfa0VXwLTqrVv7a QvzL25S+GYgiKirzzL05yX+JBAYa5ZswlDshhAllcGH2qTxEh2lsaT0g9iyta4UIDe+UCp ZFepfJKM2L9S37ensnq6TTdNwhAp1XA= Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2af1822b710so2056741fa.1 for ; Thu, 25 May 2023 18:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1685065232; x=1687657232; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Mm58cdLmSJ5zDiAtA58RWN5FnFQJSGcvSIirliOWuIM=; b=AN6ZZ1Qjb6GJB6OOue81HlYulO12nT8LuSYRzZ0y4HV/gQHoBctoL5TISEiLDs3uvy AkVTh5fjLDoCDdazn1geNALlcrztjRAvJmnUeZgiC6MiYi4XhgeUoKnkkPvWAfYvA4Up mb4jExcl2SpfLJzjScukXuv9pkCF/OdxNsySA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685065232; x=1687657232; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mm58cdLmSJ5zDiAtA58RWN5FnFQJSGcvSIirliOWuIM=; b=JDeOp1QcTl3hBfJMi221OFRKxBCGkmn9ULrnU0jC0zUd1kUtPfiSD9RbK+kj5qnGcp 7ALBhgRQmqEuPghlrpkfzRKvreJIog/bIbd+MZVJS0W3iEjkcjcEFgO/LEl4/DHuQ/CM 0Xl7Ikjae1Hou/eLa8KRnr4KXWGq2KMhbWlb28/Lg3Lhlc+50zPa9dUuWSkv6X4McQmD R6j2RO5/ZXfMBcndmdhwRbmjU0h1sauNaIVNgO2ibDERQ61CA0IMiRBjFr8dFDa4KdH0 BV9wL/mW3E4+C/DBU/K4vXMS1jT3o4T3M9HvZTtZm7zUYpTi5OFzH90+J6k4SWwn+Kfa JRSQ== X-Gm-Message-State: AC+VfDxjunxdTD2eDgE0m/l+ewIXcLtvGM7rU46FkwGFCuWNMN5Zi142 aZyc4yv0HTrgh05DDnE7eNEy10Y6rl6ohbqIt2wMp4mZ X-Google-Smtp-Source: ACHHUZ4pY+IyjF2St1XN79KOyjAqBXVXjhyJP6PDG5iE+H4RwizCCyFhQEGZatYOUsw0JeovvbkqAA== X-Received: by 2002:a05:6512:4c5:b0:4f1:4468:ee65 with SMTP id w5-20020a05651204c500b004f14468ee65mr18188lfq.30.1685065232184; Thu, 25 May 2023 18:40:32 -0700 (PDT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id p1-20020a19f001000000b004f1406b059asm405166lfc.219.2023.05.25.18.40.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 18:40:31 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2af30a12e84so2131201fa.0 for ; Thu, 25 May 2023 18:40:31 -0700 (PDT) X-Received: by 2002:a17:907:31c3:b0:96f:912d:7922 with SMTP id xf3-20020a17090731c300b0096f912d7922mr478321ejb.53.1685065209995; Thu, 25 May 2023 18:40:09 -0700 (PDT) MIME-Version: 1.0 References: <20230524213620.3509138-1-mcgrof@kernel.org> <20230524213620.3509138-3-mcgrof@kernel.org> <8fc5b26b-d2f6-0c8f-34a1-af085dbef155@suse.com> <6gwjomw6sxxmlglxfoilelswv4hgygqelomevb4k4wrlrk3gtm@wrakbmwztgeu> In-Reply-To: From: Linus Torvalds Date: Thu, 25 May 2023 18:39:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] module: add support to avoid duplicates early on load To: Luis Chamberlain Cc: Lucas De Marchi , Petr Pavlu , gregkh@linuxfoundation.org, rafael@kernel.org, song@kernel.org, lucas.de.marchi@gmail.com, christophe.leroy@csgroup.eu, peterz@infradead.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, yujie.liu@intel.com, david@redhat.com, tglx@linutronix.de, hch@lst.de, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, prarit@redhat.com, lennart@poettering.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7F1101C0005 X-Stat-Signature: h1gi6oh9i9ojs54mfce8iihxcg9qsy6f X-Rspam-User: X-HE-Tag: 1685065234-752952 X-HE-Meta: U2FsdGVkX19V1ytlVNRkPwn6DsenlhlRtr8YEyXmudWITmD7/GHnCNcHJ4giNqOoT3X9OAWomhObDhejcWWJC48zaRMdXtRWThLzy+sHT2Bks11Ai+iUUY56Ze+zwIqHBbvBSr6gLnXkzHvuObiuJCZc+diuZEeiOfU0wdLxg7+6ngjCfvqyFE8gObOq6uE6AbICNf6xQKB/RBctHaboBVSzW7ms1EyfGi4OmASLDFP3qK8hKNuE5i61xJ9wbhZOiRsjsXml/1NfiWQfUA/5KFjX4KBDzDvOZKi5BpmojjP846cqUIDzbWGBLfa32KAKoQBHUyvKCcTJW9raT/D5loW9uRGkEAfZuUr4kWi6GrWgtpZ1mag9xy9V4VWFsODQFKFCpnXdDXGXOXbVxoDDTZpUy7SBIBstroWUUGjP/Xug+CZ1ljkiarxl7GfPnfvXEuNR6Ot1c/RD9GD5mwHaz9/iN9VBt2LO4EwCZFF4XXp1ZN2OBMx3e5KejynhZ0hUZtaUwpSF22mitqpsdwWQPhEB2m1dRBVN7EZZ+7z6y3CpgkqD/Hv8omfgh+dcz3fUiaDyL3u+WJNegAWVonRmpugZ7a1lF0SB4pLlkRCjDmjaL6fg86WgloBx6sL+keZOm0/iz8iV+ZPmaSLcKuWDpbQKPLGGvhG7CcgnGPT87iF/51A9i28h4QsoxRytGngs0RETKWBILdMWuPE9eSpeG6KS+Cg307+30BFSlXfT9FxrjlxLwCK/GxLrYa6X43htPPZZkLohap2C5X5yFi8sDHL1DzzOj6KqW/as0jiEb0HZE1/+pScXI5xVIm+79NxJMVp4yWZ+imV/iCqli3Fz2Sc18XEP9Bt1ifWuFsdSSsSToDtiJ3A3nt/8BG3GmgLb7FVYCAvzO0LXzvF5yT2yej4vYpYQy0lAVO2yO7ICuyJVjA9IS/ER8VlMMT7mXNGxrpxcOJf6/xkdmmiUhKP 9ac8u0f+ EURzhgIAVfJaaPySoR9DhK1sdc6DlRk3wm2ZM6BnjkN7NfH+tZiFKH8PKS7h5R0y/f5YyT6GI3ba88ocb7eNm6+IMlTVCDLVoE52f8s+PQ3okgzgYI9EbEMHeUkp6DU5BMdsrYTOhM79I08D5atE1aYp7QN5JoYZXPOFxNr1XhzokQfiCKfGpZYxk4kdQOYuz4Ffyosn7xxnCzPTL70e8fzrqB5PjvQPyv/MM6DLnAEajOUk3JetrSnhjc+EQHVIpTbTbjRXawR1xKzGEzgqlGWl9kV7TckVIcpmeK/Fpb09RDlxiemdCefCbBmCqrvXGDfD+nCV0uk6gLVmZkeAX4HYZ+RTt4TVLhNM/2+ErmZN70Haztgi8ssakxC9DlNEaHt+EFgZUjT/CbAb4jfGtx3tM57MOUdBbkh/arjlec00wzuaBtqwK9cb6dngm+Qo4pB/xvsJ6vdRppVTp+iLDi+PQCNU591fgAHaMkdK7F7HHMmSMdgUCl6f8Dd5m2Nwf+PinCdgvOcHos4Wno3lwwel5CEexc8ntdq640riu6GGqCUEsMm4KrC6n4tCmDVPCr2DGAWttftU6xYNU6l9qK6B2//d1KI3Mosae6B/kngK42sPWxhpwiJyduWnKBdzitRPq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 3:02=E2=80=AFPM Luis Chamberlain wrote: > > So yeah definitely a pretty good improvement. Sometimes the system boots > without any duplicates at all, for some reason Vs the previous attempt. > > Tested-by: Luis Chamberlain Ok, I decided to just move it from my experimental tree to my main tree. I think I used about three times the time and effort (and lines of text) on writing the commit message compared to what I did on the patch itself. I tried to lay out the background and the implications of the change - it may be pretty darn simple, but it does have some subtle issues. Anyway: I've committed it to my tree. This is not necessarily the best time to do that, but let's get this behind us, and in particular, let's get it out and into wider testing asap. If it causes any problems what-so-ever, I'll just revert it very aggressively (unless the problem is trivially and obviously fixable). It is, after all, not a fix for a _kernel_ bug per se, and whil eI think the patch is very benign, it does change user-visible behavior. Very intentionally so, but still.. Linus