From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F88C02181 for ; Sun, 26 Jan 2025 18:30:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00E64280106; Sun, 26 Jan 2025 13:30:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0047280101; Sun, 26 Jan 2025 13:30:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC79C280106; Sun, 26 Jan 2025 13:30:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BE93B280101 for ; Sun, 26 Jan 2025 13:30:07 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 45545A0E56 for ; Sun, 26 Jan 2025 18:30:07 +0000 (UTC) X-FDA: 83050442454.26.FAE436B Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf21.hostedemail.com (Postfix) with ESMTP id 0D0331C000C for ; Sun, 26 Jan 2025 18:30:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=fBITy4cc; dmarc=none; spf=pass (imf21.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737916205; a=rsa-sha256; cv=none; b=bB3BQB/Xn5zAdYMCU+83dhno9/vA5XiwF179jbQqNVHVmTcSrvKvJBbjufbDcocC6PU1W5 RbxxMihUiAKb7d/7VRA7D4O8wtsMTvNr4WkOICdkb9sW2KFsJ361b5hS/+iUCDDw0Ut96w J0D/hPbnk3b2haMCjkTZHTZcCaNDAKY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=fBITy4cc; dmarc=none; spf=pass (imf21.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737916205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P3M+AbIbM25cnhkMyx94VOLdqhzLPile/W0OaxM5nIY=; b=gLOZgX9k+z3oU4KbK39AXnAIlWTzDU6qgqHMGTRlQjbNSV85bpwXtfPn6RGraJhKxB94PQ r48l3hG1gDbQHrd4GHa/EVF+42aRzcdlayM86FlLcjXoUV4zY6fT1LTm26CGJLovAKWG2h OTlQALZq72qY37JVpfosPTWCFH1JRUM= Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ab34a170526so624585366b.0 for ; Sun, 26 Jan 2025 10:30:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1737916203; x=1738521003; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=P3M+AbIbM25cnhkMyx94VOLdqhzLPile/W0OaxM5nIY=; b=fBITy4ccQei+cHoIKfLWT9VJezzrGV9xsm1+b+jJyzH5MOjnfhibLy0kL5sVxE/TAp 5hEnoEJtcvt8xcZrN551N9zfGMGfjyQ7RS2HTP7p8R3SSsknp7enKXQhh8qNgSXveG60 /wCbDlwPtQJWUWWyEpOSpEkKvgGf8wZrXa5JU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737916203; x=1738521003; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P3M+AbIbM25cnhkMyx94VOLdqhzLPile/W0OaxM5nIY=; b=rCU7tsCEZ817Urw7x34Z6DLhCdM+jpElqO/ra/aD6ej3uaPERmkIYiv5cbQbt8Hlmy M9NdtfxHZh+VhZubmGnxooHOXQreZRKrIUVuJGazzeOfxSLRkXLtDNQ1VejwNil7KZYb D0tmTGp5bymx+dI9++BLeZtkFId4Ihp5Nzu6mA/uJWtMydjY28Z9FVl1W9Vkmi2DvGHk YQYBKBXTJP10+YoCbUA7TGyyWwdvKgbY6OGINwTO8d+VOdZUL3UBxIQcpTM/gtZzacIm qOWQpjPnpzwG683PIKgfWYUfpDXNR26U+LTiclHwEPZ8TVyuQvaBI/PKR+fUD1uFjD6F 11RA== X-Forwarded-Encrypted: i=1; AJvYcCXiPGIpT6k1lylg42xrkHdz3QrZQvoFsIBpwOtXOyGm+w3B9jzUUVKLk1xhpKte5kBRe0JH/wj43A==@kvack.org X-Gm-Message-State: AOJu0YyAVYLDMRTufnBUiLANUnnQVIHbt0y1YzJ8Fm2P02aD2T58vSQK ZyCI1cHfsz5syJWMa0EMFd+C+e/VCJJgK3S2rH9tpDBF8CnORqkbHzzmChxQslFzo8LduwK62V0 ojno= X-Gm-Gg: ASbGncuL/Fkyr1WFS+v/nlPM48uTGPacnScWihm4OIM7MiPO2vfiB+v7Q73NT/u/ve3 FSBLf5hyjTZMZI9hHcPNWEmBb38V/BGyoF5aiBI+J95Nd+Wyv6VpLHs7pbfbegsggU+0kcKAkh/ VCEP5/xkwVC1FJ83lBwqoHLiithW8w6Pz7uzO7jk3gjW4RA7yHPrC3u7EwcclBRnp6I0R/OXZrQ vDoCu6ijly5fmNCB8cbjSBJ7wsSGg+qOhdXvEEtFMZ1hCaGojp8zRUP65mt4I44gmIakTN/8ZA3 PJL+H0GZ35XsCPgwxUs7D2tWEpsw9txhj728S5yVrL0ALjrq3Rob1Hc= X-Google-Smtp-Source: AGHT+IHz22pQzjdEzTGSXi4+eBc598uyLG2g228myCHPenpSgwv5m0EeaOk8o6ZS9i/fSGMfG/2LJA== X-Received: by 2002:a17:907:7fa8:b0:aaf:123a:e4f0 with SMTP id a640c23a62f3a-ab38b0b6886mr3788525066b.6.1737916203133; Sun, 26 Jan 2025 10:30:03 -0800 (PST) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab675e5ca68sm461836266b.38.2025.01.26.10.30.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jan 2025 10:30:02 -0800 (PST) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5d0ac27b412so4841148a12.1 for ; Sun, 26 Jan 2025 10:30:02 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUD4FAbvTqBbQhJeqygRNUamZaril0ABmVcq6W4vOTK1vfkZ0gdcH5jcSB9/+TiSwc0YPSsjHSZVw==@kvack.org X-Received: by 2002:a05:6402:2682:b0:5db:f83c:2473 with SMTP id 4fb4d7f45d1cf-5dbf83c26bdmr17337970a12.30.1737916202070; Sun, 26 Jan 2025 10:30:02 -0800 (PST) MIME-Version: 1.0 References: <20250124162248.60104eec848619a187242392@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Sun, 26 Jan 2025 10:29:45 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZmGdxihCLL9KpFnjKHSSUX1cviulL9CWrj_0RvMLbJiU4pvE2aXY5KXNGc Message-ID: Subject: Re: [GIT PULL] MM updates for 6.14-rc1 To: Uros Bizjak , Miguel Ojeda Cc: Andrew Morton , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 0D0331C000C X-Rspamd-Server: rspam10 X-Stat-Signature: yt4k8cnf15th44siumc8e8g9sw51dp5r X-HE-Tag: 1737916204-238320 X-HE-Meta: U2FsdGVkX1+D+qptGfjddLGK45bjO96WeyBSUSa5T+c5T+E+42X3OnZgv2ho/R4+8H2wFcPHJJ70Gq/NmIVWhochbLa3HKZgwbC2g5sehUqwcw0ww7QptpIqrwPhg+s4+PezdC6puj/Fzq4fVLOlxvE3/t0a3BDCstnuBoa3bh0/ymy3FHsCCZyAuQHmwDfGQN3MkP902I63hz4WDN0mLZgVwCAflY8ysHjvK+kqLgz7C03ipqVhCbtKpWxcRPWjG6aB53/p/txQm/oWkMQjLItYZx9Au9v59MuVZpKyibTHlu3vxft4aISvLpktcq7XZWYHPljeY9zhZh1KALuxCmt0tT7C0TpwVmXwCCZkOAP/lTmNCKU9jDZLiOnGkbMxNDMGfR8sFA8LNIyMLT4/3Z9UqfBKGa+X7wrVdDFs7utYMZqXPy0pTjukVZ1BU7wD4HGtMbT3x/aPw+j9qDquC4V3MR3atQbHjPwMejeRCIvqBvUnqg5YhwpJAmMXbRF5v7JdwZUjBrPdkr7ettNKMzQlbphn36jN741EtFespSK/V+j3IIjqcmLaONWMx/+bJXCVRqQrtc4ahTm4qtZti1RnfEnBmGah+irEAE29pbSiry6fludM48MuazFEZWZnom8abNBpyzV7g71zG3PZQOrq3W8hdFLkRhuZ2hKAvMksza2IR9vkCl2FB6VeZ/1gfnVqy+lX/lmnCynj5bou4yHtdtV4zhiEvMcVF/zxG1PBQtWqH2mfoK5d0RH4JWss7cKzHsL9S5z4mCoR4ELkqubK0iBkRSZ9OVC3g0I82jYCIPUIFsW5iPsI0V4dgdLLNeVrcMjl3W19+DOzzg8NznzAujFYwgjKxT/XeWDM4MdJ8NEZCXACCxVQF61pNGE+Yrp5BVmHdau+ELH9wfVURid3uncAccDJM2P+wSncH7gwfgBjyhwYIBn8X6tpv8Quxs1oUfi2WwA75HN2Hju 3Fd8P7fA QTn4plPKMBpUN26bl3rRWpSp0ZxlpoDYM82HcqekyugedQ2qgp0AHH4NvSTt5ujqwmf+vs2TxINfpzlvGJeeOIyV+Djmr1sikAG/2s50uAVcjXKsQ+V6WkfgrU37gl9yUFh+0nXOzswBJ62BjwxOvt+hr1AaKn1KJxG37u5eYx1+QCkjOTTGHUjy64XAj8gN3i+y5yQjk0JRCi3LyiZHSJwqGOLNJcwZ0Ur5xkTzHjllWvejR52OZHUVgg6O9gM1MOEDmpAGx18QOGi71maoAd2498imauzFmDD4DmNhyXEkmySQB12SaVa/duV1Vhcy/YcLnM4XhZqVxEbmSadR81KUCOXjRk8/GhQP0cjD376zEgIoWWap/l/qQIVfdYrkoCu7I6rK6hEvQRkBR0ALzG4EM8V8GU7kKrGhmUDNuQS+yQ14PjRsvfqtDXstymFJM6/VE73pc2CLyknCwI1sW9hFqicMz+SvXRZ1Q7Y5f3gjOyykbq4s9Pjxf5oUWTxt9LSzwR7soyRipQYk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000228, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 26 Jan 2025 at 09:22, Uros Bizjak wrote: > > bindgen ChangeLog does not mention __typeof_unqual__, so I assume that > the support depends on RUSTC_LLVM_VERSION. That seems to be a reasonable assumption. I guess some crazy setup *could* install a bindgen that uses a different llvm version than rustc itself, but that sounds pretty damn broken. Let's add Miguel to the participants. Miguel, see https://lore.kernel.org/all/CAHk-=whddBhfi5DUi370W3pYs+z3r2E7KYuHjwR=a1eRig5Gxg@mail.gmail.com/ for my "this doesn't work" report, and then Uros' suggested fix in https://lore.kernel.org/all/CAFULd4a-2F_zKMeR0Yjo2WhRLmyoOQ1VdR2qdV34BrM-b_cQCQ@mail.gmail.com/ > Does the attached incremental patch work for you? That does seem to work, but I'd admittedly be happier if we could just find some way to dynamically disable/enable __typeof_unqual__ based on which compiler is used, rather than make it a config option. So that bindgen would not see it, but a recent enough C compiler would. We already use '__has_attribute()' for some of these things. There's a '__has_extension()' thing that comes from clang but that gcc also supports. But I can't find the list of extensions that that model supports, and I guess typeof_unqual isn't on that list if I find it. In the absence of something _clean_ like that, can we just do it in instead? IOW, not use the CONFIG_xyz tests for this at all, but do something like /* * bindgen uses LLVM even if our C compiler is gcc, so we cannot * rely on CONFIG_CC_HAS_TYPEOF_UNQUAL */ #if __clang_major__ >= 19 # define CC_HAS_TYPEOF_UNQUAL 1 #endif in and the gcc version check for gcc (I don't know when __typeof_unqual__ made it)? This does show that our whole "CC_HAS_XYZ" is kind of broken for the Rust integration in general. Linus