From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB73C433EF for ; Thu, 23 Sep 2021 17:12:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8AD7F60F70 for ; Thu, 23 Sep 2021 17:12:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8AD7F60F70 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1F8656B006C; Thu, 23 Sep 2021 13:12:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A82C6B0071; Thu, 23 Sep 2021 13:12:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070276B0072; Thu, 23 Sep 2021 13:12:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id E7DB36B006C for ; Thu, 23 Sep 2021 13:12:24 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8C84B181BD782 for ; Thu, 23 Sep 2021 17:12:24 +0000 (UTC) X-FDA: 78619481808.40.09C30D1 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf07.hostedemail.com (Postfix) with ESMTP id 3F878100009E for ; Thu, 23 Sep 2021 17:12:24 +0000 (UTC) Received: by mail-lj1-f169.google.com with SMTP id m5so588848ljp.4 for ; Thu, 23 Sep 2021 10:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i/CxnIoh9vGI3IXe2n3zSyhD1ELxDhirk2SHmfQlOLQ=; b=RMG/Scp8QfSxAZON5Uq51XOAc0XNXVcBG2GnnrniXglTgraSBvZ9RTKockwhPH4mGf WeyPErky+FsOoPedYN2c7qDYCZw5WhZNubXkskDS/lKdYEHUbPqNnam84t6nOFdacy7a Ly9YiJwUacU0hCuahpkwUe3ElAzj5gwsY1c2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i/CxnIoh9vGI3IXe2n3zSyhD1ELxDhirk2SHmfQlOLQ=; b=x4DfKYGw3RfFdj8idZQHlTmQtaCFRaf0vTCmbowAaq6xJUHWvxiKEELXNXrf+NZWo1 503ucs6xJUheJdmDUi2EFFsc0wmaLg2S18AiqFwonZmhMvHoR5zrk9FZj26yu2QFbLnq KDHXuFLsv7AZ3FQ/e2nI5r2N0SORzrPa4m5LOIZv0ycgjKIn/lK3sd1V5xj5xpLrU4Qq 8BCnmRwAJ5l39zPP9s1ecTu08NOZClIT+xF7jXeDnH3tGJfaEJNZ2Vn5AGTxXZxKaEIr UVGAFqTv5gvwVhtoRsHOfO2PXU5QJVRZbqH30UJLBv7daazaaIhW+GAugkK01OxVPwQb n3GA== X-Gm-Message-State: AOAM5302T5pgb5bybx9WRafS98M+8H7av0mvUPZU5r9Pv3+ZPMD62n4t 81pMR/Zv23KH7djW7QhXZvG+cbH8b2IWbBoquUc= X-Google-Smtp-Source: ABdhPJzDD/Dp9qJ5qfQrUTDd80oRdnJyp2VA6nUieLdUCj/khod5HXnkyfMOb5nTMpIcNGqJYSPEmA== X-Received: by 2002:a2e:87ca:: with SMTP id v10mr5166779ljj.369.1632417142047; Thu, 23 Sep 2021 10:12:22 -0700 (PDT) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id e15sm505474lfj.163.2021.09.23.10.12.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 10:12:19 -0700 (PDT) Received: by mail-lf1-f50.google.com with SMTP id e15so28978928lfr.10 for ; Thu, 23 Sep 2021 10:12:17 -0700 (PDT) X-Received: by 2002:a05:6512:3d29:: with SMTP id d41mr5080713lfv.474.1632417137194; Thu, 23 Sep 2021 10:12:17 -0700 (PDT) MIME-Version: 1.0 References: <20210922224906.676151-1-shakeelb@google.com> In-Reply-To: <20210922224906.676151-1-shakeelb@google.com> From: Linus Torvalds Date: Thu, 23 Sep 2021 10:12:00 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] memcg: flush lruvec stats in the refault To: Shakeel Butt Cc: Johannes Weiner , Roman Gushchin , Michael Larabel , Feng Tang , Michal Hocko , Hillf Danton , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Andrew Morton , Cgroups , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="RMG/Scp8"; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.169 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3F878100009E X-Stat-Signature: sgcuhym3igwjkh4z3fwawj4c35fps39q X-HE-Tag: 1632417144-413261 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 22, 2021 at 3:50 PM Shakeel Butt wrote: > > From the above result, it seems like the option-2 not only solves the > regression but also improves the performance for at least these > benchmarks. > > Feng Tang (intel) ran the aim7 benchmark with these two options and > confirms that option-1 reduces the regression but option-2 removes the > regression. > > Michael Larabel (phoronix) ran multiple benchmarks with these options > and reported the results at [3] and it shows for most benchmarks > option-2 removes the regression introduced by the commit aa48e47e3906 > ("memcg: infrastructure to flush memcg stats"). Ok, I've applied this just to close the issue. If somebody comes up with more data and the delayed flushing or something is problematic, we'll revisit, but this looks all sane to me and fixes the regression. Thanks, Linus