From: Linus Torvalds <torvalds@linux-foundation.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
"Roman Gushchin" <guro@fb.com>,
"Michael Larabel" <michael@michaellarabel.com>,
"Feng Tang" <feng.tang@intel.com>,
"Michal Hocko" <mhocko@kernel.org>,
"Hillf Danton" <hdanton@sina.com>,
"Michal Koutný" <mkoutny@suse.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg: flush lruvec stats in the refault
Date: Thu, 23 Sep 2021 10:12:00 -0700 [thread overview]
Message-ID: <CAHk-=whgL6H0fYt9o2qOVwExZJy_nmZ9=_hTcBUKf=YHXDJVxQ@mail.gmail.com> (raw)
In-Reply-To: <20210922224906.676151-1-shakeelb@google.com>
On Wed, Sep 22, 2021 at 3:50 PM Shakeel Butt <shakeelb@google.com> wrote:
>
> From the above result, it seems like the option-2 not only solves the
> regression but also improves the performance for at least these
> benchmarks.
>
> Feng Tang (intel) ran the aim7 benchmark with these two options and
> confirms that option-1 reduces the regression but option-2 removes the
> regression.
>
> Michael Larabel (phoronix) ran multiple benchmarks with these options
> and reported the results at [3] and it shows for most benchmarks
> option-2 removes the regression introduced by the commit aa48e47e3906
> ("memcg: infrastructure to flush memcg stats").
Ok, I've applied this just to close the issue.
If somebody comes up with more data and the delayed flushing or
something is problematic, we'll revisit, but this looks all sane to me
and fixes the regression.
Thanks,
Linus
prev parent reply other threads:[~2021-09-23 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 22:49 Shakeel Butt
2021-09-23 10:02 ` Michael Larabel
2021-09-23 17:12 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whgL6H0fYt9o2qOVwExZJy_nmZ9=_hTcBUKf=YHXDJVxQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=feng.tang@intel.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=michael@michaellarabel.com \
--cc=mkoutny@suse.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox