From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 928D4C77B73 for ; Sat, 6 May 2023 17:10:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A78606B007B; Sat, 6 May 2023 13:10:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A295E6B007D; Sat, 6 May 2023 13:10:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93E146B007E; Sat, 6 May 2023 13:10:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by kanga.kvack.org (Postfix) with ESMTP id 54C096B007B for ; Sat, 6 May 2023 13:10:47 -0400 (EDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-959a3e2dd27so520069166b.3 for ; Sat, 06 May 2023 10:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1683393046; x=1685985046; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ep2eFTjXkhewcCNr0bmXM2Y/3o4NieTjicG14F04RRo=; b=CGy8Ct67kPfMBD32CeTOeucyvnK79GBDaBmBGh6+HrniyxCmUbbvrSQCVsj+nnp4Aa nJHCOQfXFJJa9xSoLWsOzCTU9SMa7Rte7J+4VI5d7vExbWRPis/VuCHpEwv2ekXGS8Ru 3riE/CpokxA1d9o0MqP5pZn2EM5CD9mkHBv1E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683393046; x=1685985046; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ep2eFTjXkhewcCNr0bmXM2Y/3o4NieTjicG14F04RRo=; b=ZcaHCHN6jM4fhUsgT7cWd4PFexuhecdoRBcqYCHQ4C/tWFR+k/oJhVBDOWWkRf+OSV OmgOWrfZvVEzos3iDwbJyEdJT1xfHDvnorcsZiWQFAWLhrQRdrJvQq8llGW72akbmdoP VI4zQsrQn3TYkv+RlIXxJsNjactMYBs+QJpo3tW8f76r7Za1JKoqYMXAM9675wFg7yWq A+E0+dyb3yGylxUBhpQF0eP9LR8FJ6Xw5EkuAwsL933jWNnprWa/NcwdgxYxkeHC6mED 9HZSfSpHB7tzhqUrF9lEhMDxSkmNlMsBTmIJKHnc/6sUJZInWNe3Q+UnttXkNXBXPi86 w4KA== X-Gm-Message-State: AC+VfDxvHIoyiaoOz2PNFghbhYKK8NyNCNH8KsmRCPpK7pI21sby/q0Y aaH8LiOEcOzbREhjh8HB41f22jIY1Z7hUUPgcnoBQA== X-Google-Smtp-Source: ACHHUZ5EgyM6G7Z4T+TwIqyrDpet9gh8e7z+sykz0QmpEzep7RUao8sS93o3JQrTd6FiUTiFFN4aGw== X-Received: by 2002:a17:907:74c:b0:965:6aff:4f02 with SMTP id xc12-20020a170907074c00b009656aff4f02mr3983352ejb.41.1683393046350; Sat, 06 May 2023 10:10:46 -0700 (PDT) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com. [209.85.208.47]) by smtp.gmail.com with ESMTPSA id ml23-20020a170906cc1700b00966392de4easm54552ejb.14.2023.05.06.10.10.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 May 2023 10:10:44 -0700 (PDT) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-50bc37e1525so5784585a12.1 for ; Sat, 06 May 2023 10:10:44 -0700 (PDT) X-Received: by 2002:a17:907:3f90:b0:953:9899:d9c1 with SMTP id hr16-20020a1709073f9000b009539899d9c1mr5635228ejc.1.1683393044055; Sat, 06 May 2023 10:10:44 -0700 (PDT) MIME-Version: 1.0 References: <20230506160415.2992089-1-willy@infradead.org> In-Reply-To: From: Linus Torvalds Date: Sat, 6 May 2023 10:10:27 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] filemap: Handle error return from __filemap_get_folio() To: "Matthew Wilcox (Oracle)" , Josef Bacik , Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Dan Carpenter , syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com, Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 6, 2023 at 10:04=E2=80=AFAM Linus Torvalds wrote: > > So scratch that patch suggestion of mine, but let's bring in some > people involved with the original fpin code, and see if we can find > some solution that honors that error case too. .. in the meantime, I did end up applying your patch. I still don't like the code around it, but let's fix the conversion error and worry about the other issues later. Linus