From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25D43C02198 for ; Sat, 8 Feb 2025 03:49:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F0766B0096; Fri, 7 Feb 2025 22:49:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59F146B0098; Fri, 7 Feb 2025 22:49:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 466B66B0099; Fri, 7 Feb 2025 22:49:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2A94A6B0096 for ; Fri, 7 Feb 2025 22:49:42 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BC7434CB2A for ; Sat, 8 Feb 2025 03:49:41 +0000 (UTC) X-FDA: 83095398162.03.14C03E1 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf05.hostedemail.com (Postfix) with ESMTP id 9C321100002 for ; Sat, 8 Feb 2025 03:49:39 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=LV2eVcXj; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738986579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=en/w6yDuVSKRL7ItlfwKpxJ2vsOe/76EOS4O3iixM4E=; b=cQlzgAQy3pS5Tg42AGTnENWbRKhWexnqDfF5BJLDRywl/xQnUrqW4Immmf7UKQCxfVgSRs Fv4Jret9qXHLqfW3hLUo7id/s3ioay8NwpbKv4pjShCGOoHrYq30B2WXCkZXG9b1NjJXbC BGazqTis5rHvEWJgHnT1PUt6rLdPy+4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=LV2eVcXj; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738986579; a=rsa-sha256; cv=none; b=o2zb5VX4zsjL9DjYiykMyE6dhKcSM48bJrij8YEJvgf7Gjxx0KUj99JYo8b2RY4q60Lgh4 06AkO0688UEPd9vP3/0SOHFkUS5UFjx3Ff2K3kG1XsWGzhaGWK66zbtfOzFU7DQ0XpLmjw Wwl7l1oo1H/Ce3uTKwAu+56K+xKnUDg= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-aaee2c5ee6eso451760966b.1 for ; Fri, 07 Feb 2025 19:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1738986578; x=1739591378; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=en/w6yDuVSKRL7ItlfwKpxJ2vsOe/76EOS4O3iixM4E=; b=LV2eVcXjnlf1QjSaq4i8sT2gbR8hMnPxf9AAWBbBSItSEt1ilYQie4HFgjYVIuMpBY JwPPNr6U28DFDpEZSQVGus/Dk7pjX0jCgRy5KVouZ5g+cKB5Lb9wN0JcsnfnjbfO1SuL xg5SomJ4zRaFuAFLuG0K7huFn3EYXvpwJw0UY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738986578; x=1739591378; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=en/w6yDuVSKRL7ItlfwKpxJ2vsOe/76EOS4O3iixM4E=; b=o9cQeVZLHRCQEr6BoPMPJKwsYG4myQfiZut9pFUiALS9HTL+cdZOIcYDDalSRnbCpS SxkH5nLQEbfupskRZrbAGkHZ2suy2xN+mP+YR5IGsqUhoFcsPUvBQLK7pR2TspuSITx2 TPUFT+cQnT3NqnYcBAC35vb79wyoyQqRvRqOqLdldnpPCKcPQJQi8hKcILMdBnQc9WU7 wgn3V5aJ24umho4ugupjkthfaxDHxFUVugjfjK4HKmmBwSedR2L3QcbW4lTp7NdXlEZq 5AxbkcnJfajZEmXeRLPj+Jl3FF/oL9vG4CdDMEYkwdx29wv72FNc2XvpkPhOs56Z1zGp aUiw== X-Forwarded-Encrypted: i=1; AJvYcCWucZJM475avPWkTt22QdpVPAF6OCIjkzb7PGf+tRG173MJUpslf6E8gL/6GtrwffgshsGDH3wUQQ==@kvack.org X-Gm-Message-State: AOJu0YwN9+5Dsvv0Kazw4jfJJB2dTP/qHj3WFezDjtHOGVd5WnnR0qVT spVehjShPSH3Q7iGGvmBLDcnonKsLZ7o7UhtAj4pnvv8IxJHdIn69SvNTNs/Pc/q3DljecbIzbd tFGCSkw== X-Gm-Gg: ASbGncvN1KtN2MT1Lb5425qFDoBTE1nTPeUoDPXlqV9qtEyJ3XV998AfpRd8ktxFVBS AkCIXC5OWRfpY6JIvVCs6hflCcCSmTB94J05LsvFlFVGvJVTnYEqZs1tLs+L6LWleaYv8mbaecK PFbk9eZycASICVjB+SCy+hZLUvFBreMPZTmTi5eIcrIhAa+iahJlH35txO6AS9tdK24cZ+fBJYE DonzzTRqWzYa9mc2gP3xylAZ11OTezAwsjcYl37yObIift1ngVRJTNFivpVQ3SXYZ2UWaEjORAy c3iKLbUD7nnWnYIUcSjsqzu1CqKjKNMdwyo9v7QkDtrKp/Unk5OxQlHFc91/X/S8PA== X-Google-Smtp-Source: AGHT+IG2BYusgFXb33ONGmyMPS7fDmmuscPNp+m1xNb+wzP7Sn+opXYXPH/fcIfMZ7VyBEnfJshbNw== X-Received: by 2002:a17:907:7e97:b0:aa6:8a1b:8b78 with SMTP id a640c23a62f3a-ab789a6aeb0mr633438266b.6.1738986577856; Fri, 07 Feb 2025 19:49:37 -0800 (PST) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com. [209.85.208.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab78f45c6easm195250166b.73.2025.02.07.19.49.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2025 19:49:37 -0800 (PST) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5de4d3bbc76so1995857a12.3 for ; Fri, 07 Feb 2025 19:49:36 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVsvx+/iqjALbzWxmY60jLGBBEEDRA2bjNs2T87r4h8yqIqDZdTQ4E9U3R/HDdtOUeXkqSmuSnk/w==@kvack.org X-Received: by 2002:a05:6402:2804:b0:5d9:8877:895a with SMTP id 4fb4d7f45d1cf-5de45022bc6mr6555500a12.17.1738986576060; Fri, 07 Feb 2025 19:49:36 -0800 (PST) MIME-Version: 1.0 References: <20250131191231.1370466-1-bvanassche@acm.org> <20250207164926.6daeac77@kernel.org> <20250207173813.5081ba76@kernel.org> <20250208033351.GB3305705@ax162> In-Reply-To: <20250208033351.GB3305705@ax162> From: Linus Torvalds Date: Fri, 7 Feb 2025 19:49:19 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZm93jEuBeKA0T8ZikX38dvQR5dXzkkQRBS5ZLzaULkflGe0aZoKzJ2QQpI Message-ID: Subject: Re: [PATCH] mm: Fix clang W=1 compiler warnings To: Nathan Chancellor Cc: Jakub Kicinski , Andrew Morton , Bart Van Assche , linux-mm@kvack.org, Ivan Shapovalov , Vlastimil Babka , David Laight , Pasha Tatashin , David Rientjes , David Hildenbrand , Kaiyang Zhao , Joel Granados , Sourav Panda , Johannes Weiner , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9C321100002 X-Stat-Signature: m79ucambix4rbskggxbewfbhm7g3dr19 X-HE-Tag: 1738986579-308744 X-HE-Meta: U2FsdGVkX19HP1vh0i2sL51rA7iwD0gt07FTaUVhX1bNomCb8oEfPx0efmhAdi3P04TVR912HE1kjON4vg8h5RpsTRx6MT3Eq1pmxKoIxyth+GarkAvEsCpzf8RjrGY+k+U0n8mhV6SuL8Z6GgEpDJtKgtXv1Br4AyOXpW08q83DJYDyydAwAi6tRCYY6F0vYT3ai+umexSyanBv/1OrEXJK7tyeDgRNchRxiV9dmvZfmvV/qzdIXuP+NOV7M/NvdYpGCXdWUfLA1vlcUcxRI7yoq4YsXyE83M3HJxH8L1aMjO3Tihn9q784GAnCgJUrxmexM00VUNisCkKDSqDWs98a6WN/Ez8qGUvXWwVnbQ28RfX/M+0P4GS9oD1/TZ0tmd9jtlrJVCf2mzfocVRk7ITv/z1ez5Cyk+ueM2s2Z7NzdYVFNYjsiV5Uh45TRPbz8XxmJI/bhby+8XTDp5EUU1TcPlPgAhlh2Yek+m8lq94gXEinI6QzLM5XDSlo6ZEuhMmybE8uiYzRuda7hKAu3F9tPomdoL2BQhEqpyDTV3dvGZBfMJdczCbgxv1LnWWvL9deKrcwrwt/XKINGov1wsN6tIMBYtZgGyLfpNB3DCaPYuPEaZPPJGPDc08106IDG6KERt+T3dNaLGyAp8WfSFeMeRRYvL0sve1IrUHDsm4h1BBtYcY4vqZfft7nLvlpBOVBo5Ukv17Pzk0rV9QdLiTXHxVDQwrwSJfd1PRh+kgLQdqlomOZvwhyKK/gJkOVpMkwMUz0HUclQVrQDpVUC/o5Pr8VpJ05y+IC7Jm4Bo+KenZN+b82e9zux5hlluZsG0KoFSeVSphz0oPs00hAkEE97hjNiSq1PKdZdu28jDBKd9kz6VZffXp2JWo3SJ4kaqtbrB9vbBu5bm36uhEVSmyU9JFZ1rusn7rLhCu2ZJjZ/r3rpQNQIbvPoF/CvZ1QcQcxNULy5ydL5HS+rkC ayx5pXN8 +uqQLsaEX/aA1iNPoq+WkL4DfMX52oiZWmHuUgkpE26q5uwlm1nK5B9iLnJKt/K6mEuEmT/fOJNcEoEvC1mvOn9G+unazxe9V+OoG8cJRbK6/9cggskzaUsxk3aOP73+2vVqySVDDq/Mq+dj/sAU5qQfHdnc9vZ4iobjoiMjL1CJyb0gRn9KU2Ryzyj5Viuwxrf4+zCzpCKXv72PVZbRxst7J6woboheWIoYiV0SsLcjXxhmmL9u+flz7uBUhePOJe/CrGWehWLCWn+o1+U1kalYKT34CPstNOIMySIuLxOMPnAgZJ4gkYEYM4XVcU1GrY6LwF64mYiluYQfxmYtljgKAfAKHQIgCSEhUdSTyVsmz7jnDngs3vm0wdO38Qar6XXgheAxYhWRPTAJt/LLVjhqVnAmrT/R2DNlFBTiP8NXiC9vDl88lCuImp0Tul9ZpVg3Jl1gTy9EOX39RdRuQdCEEvDzMTVDhKtL9fGVdYp2amee1n4i808qN1iBuMPaWKAzqSmYQXlfhIYapNOC4wJZ8CDxgo23pbuqsUJn38JWIRiQ8Pc1i8X8uxg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 7 Feb 2025 at 19:33, Nathan Chancellor wrote: > > On Fri, Feb 07, 2025 at 07:11:08PM -0800, Linus Torvalds wrote: > > > > But not having clang-19, I can't see if this is a case of "this is so > > rare that let's just avoid it", or "this is the case that causes the > > most noise for every file build, but there are lots of other cases of > > this". > > The diff to hide some of the really common ones: > > https://github.com/ClangBuiltLinux/linux/issues/2002#issuecomment-1970004069 Oh, ok, that's already more than I would have liked to see, and I do think that the patch is not only bigger than I'd like, it makes the code actively worse with adding random casts just to shut the compiler up. That is, of course, something that C++ people think is a good thing, since they are used to their traditional NULL casting idiocy. But in C, we have actual taste and grace. So no, that warning is no good for the kernel. > The build log with that: > > https://gist.github.com/nathanchance/971e5abeba504d3017cd6ed4517bbda6 > > I looked at a number of them and none of them really seemed like bugs to > me. Yeah, those seem like more of the same: the kernel doing sane things, using enum's the way they are meant to be used, and the compiler warning is just simply plain wrong. I will take your patch to move it to W=2. Thanks, Linus