linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: "David Hildenbrand (Red Hat)" <david@kernel.org>,
	akpm@linux-foundation.org,
	 Alexander Deucher <Alexander.Deucher@amd.com>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	amd-gfx@lists.freedesktop.org,
	 dri-devel <dri-devel@lists.freedesktop.org>,
	Guenter Roeck <linux@roeck-us.net>,
	 Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: Linux 6.18 amdgpu build error
Date: Thu, 4 Dec 2025 11:36:33 -0800	[thread overview]
Message-ID: <CAHk-=whd-k3GhNGvVmP7W2p1d0d4ctqJ8iCuG8DbyKzgNqCL+g@mail.gmail.com> (raw)
In-Reply-To: <b24fc85c-0e6d-42f9-a6b9-05136409098f@linuxfoundation.org>

On Thu, 4 Dec 2025 at 09:40, Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> This commit has impact on all architectures, not a narrow scoped
> powerpc only thing -  it enables HAVE_GIGANTIC_FOLIOS on x86_64
> and changes the common code that determines MAX_FOLIO_ORDER in
> include/linux/mm.h

So I suspect your bisection might not have worked out, and there might
be two different things going on.

In particular, hugepages were broken in 6.18-rc6 due to commit
adfb6609c680 ("mm/huge_memory: initialise the tags of the huge zero
folio").

That was then fixed for rc7 (and obviously final 6.18) by commit
5bebe8de19264 ("mm/huge_memory: Fix initialization of huge zero
folio"), but the breakage up until that time was a bit random.

End result: if you ever ended up bisecting into that broken range
between those two commits, you would get failures on some loads (but
not reliably), and your bisection would end up pointing to some random
thing.

But as mentioned, that particular problem would have been fixed in rc7
and in final 6.18, so any issues you saw with the final build would
have been due to something else.

Can I ask you to try to re-do the bisection, but with that commit
5bebe8de19264 applied by hand - if it wasn't already there - every
time you build a kernel that has adfb6609c680?

That way the bisection wouldn't be affected by that other known bug.

                    Linus


  reply	other threads:[~2025-12-04 19:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <74032153-813a-4a40-8363-cce264f4d5ea@linuxfoundation.org>
     [not found] ` <1eb24816-530b-4470-8e58-ce7d8297996c@roeck-us.net>
     [not found]   ` <0425d7b4-76e4-4057-83a5-a7b17a051c54@linuxfoundation.org>
     [not found]     ` <ec77d11a-7613-4b75-8c9e-f2bba1595f0f@roeck-us.net>
     [not found]       ` <9d520a1d-0b8d-4d30-b29f-230fc0f92b8a@linuxfoundation.org>
     [not found]         ` <1f31b86d-283c-4878-92d0-ab90aed0c58d@roeck-us.net>
2025-12-04  2:34           ` Shuah Khan
2025-12-04  6:05             ` David Hildenbrand (Red Hat)
2025-12-04 17:40               ` Shuah Khan
2025-12-04 19:36                 ` Linus Torvalds [this message]
2025-12-04 19:45                   ` David Hildenbrand (Red Hat)
2025-12-04 23:20                     ` Shuah Khan
2025-12-04 23:23                       ` Linus Torvalds
2025-12-04 23:28                         ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=whd-k3GhNGvVmP7W2p1d0d4ctqJ8iCuG8DbyKzgNqCL+g@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=Alexander.Deucher@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=david@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@roeck-us.net \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox