From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E298BC433F5 for ; Thu, 20 Jan 2022 15:53:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 644136B00A3; Thu, 20 Jan 2022 10:53:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CD2A6B00A5; Thu, 20 Jan 2022 10:53:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46E486B00A6; Thu, 20 Jan 2022 10:53:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 35AAE6B00A3 for ; Thu, 20 Jan 2022 10:53:21 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E2572181CA080 for ; Thu, 20 Jan 2022 15:53:20 +0000 (UTC) X-FDA: 79051109760.11.CF85E2C Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf29.hostedemail.com (Postfix) with ESMTP id 7EF0112000C for ; Thu, 20 Jan 2022 15:53:20 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id b13so30791509edn.0 for ; Thu, 20 Jan 2022 07:53:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=miHQqHvTi6uNk+KpO2ktO68R7ziuvLbIMJiH1uT6JE8=; b=WZU35Ix3qzzyvPEMn6FTozbA8yxxxJx/MgkNOS2Oo81IAotubCyzrFts+5kvBPnCXd CPwMXu6gwbAw4BlivOqh+M/w+E+Ld98tp5BwGQQ8l/sTnAdAOfgKB8+UdFeppa73c7ix W7AqZkyAzFIcr9qbNx4K8sxV+KXwB9CTJ2UK4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=miHQqHvTi6uNk+KpO2ktO68R7ziuvLbIMJiH1uT6JE8=; b=QWYmqnByyBrzvFaZhJGfnVz4uZAJ6cVrLIEpqA/P9Rc/AZGRjfdpHiWTljutSCQCOE 6ce3pOZRT5brS1h4zHmdTewwApSru+OnaNgy8iCicdaClU3Y5f2aYpGGayFhYOC6Rgdr FAWzj+KvG4JdkkQIg9S9g0KYGhXa5axWDdhc8YCAy8bPuB3ZOqxVGQIC98aCJpiyPZKo liOhLgvnKwo3bjpXK7p155h4ikquMpL53Cd5RXiKVa1lvHzdjUv4xJsGZ0phZdPH8BEX JAkFXfsyvzk8FgTB4ovUKX/iL1UEJ6TY0dUAeCuB0YbPwDIjMsYv3hOQkoN7A4YFKDSl lIwg== X-Gm-Message-State: AOAM533lzD+CfYQkcPOIAsIWHCDVLmah5kJXKVHJH/TRwL+WF/7+NfxJ xZ/EwUEZ3Ts46B6X7AX1cUV2GPF2QLWIrCnz X-Google-Smtp-Source: ABdhPJxKIc/K4j4oM++EEjVG3sH9ylrQ9EH7LVsUEAYzI3fpTVk70VQy+QqQId31vnq82ydcHWvFIw== X-Received: by 2002:a17:907:a420:: with SMTP id sg32mr28636429ejc.310.1642693999146; Thu, 20 Jan 2022 07:53:19 -0800 (PST) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com. [209.85.128.44]) by smtp.gmail.com with ESMTPSA id gg14sm1156775ejb.63.2022.01.20.07.53.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jan 2022 07:53:17 -0800 (PST) Received: by mail-wm1-f44.google.com with SMTP id r7-20020a1c4407000000b0034e043aaac7so564103wma.5 for ; Thu, 20 Jan 2022 07:53:16 -0800 (PST) X-Received: by 2002:a05:6000:1787:: with SMTP id e7mr20222060wrg.281.1642693995967; Thu, 20 Jan 2022 07:53:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Thu, 20 Jan 2022 17:53:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Bitmap patches for 5.17-rc1 To: Yury Norov Cc: Alexey Klimov , Andrew Morton , Alexander Lobakin , Andy Shevchenko , Dennis Zhou , Jiri Olsa , linux-mm , mm-commits@vger.kernel.org, Ulf Hansson , Will Deacon , Wolfram Sang , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7EF0112000C X-Stat-Signature: 8gj836qi513jpgjikbzec3f7x9e7zugo Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=WZU35Ix3; spf=pass (imf29.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-HE-Tag: 1642694000-945325 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 15, 2022 at 7:10 PM Yury Norov wrote: > > bitmap patches for 5.17-rc1 > > Hi Linus, please pull these patches for bitmap. They were supposed to > be pulled in 5.16 cycle, but due to merge glitch we decided to merge them > in 5.17. So I'm looking at this pull request that changes quite a bit of random files, and some rather core headers, and I see *no* actual explanation for what this pull request does and why I should pull it. Only a "we didn't do it last cycle, so we should do it now". That's not much of an argument. If anything, it makes me go "there was something wrong with it last time". I can look at the commits (and I did), but that's really not how this is all supposed to work. When I _do_ look at the commits, one thing that stands out is how this was all appears to be rebased after the merge window opened (just minutes before you sent the pull request, I suspect). Which is *also* not how things are supposed to work. I also don't have your pgp key (not your fault - pgp key distribution is broken because keyservers are broken) and I haven't pulled from you before. That all just makes this pull request something where I think it's all likely good, but there are enough problems that I haven't actually pulled it. Put another way: the contents do not appear _wrong_ per se, but there are many things in this pull request that keep me from actually doing the pull.. Linus