From: Linus Torvalds <torvalds@linux-foundation.org>
To: Yury Norov <yury.norov@gmail.com>
Cc: Alexey Klimov <aklimov@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Lobakin <alobakin@pm.me>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dennis Zhou <dennis@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
linux-mm <linux-mm@kvack.org>,
mm-commits@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Will Deacon <will@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Bitmap patches for 5.17-rc1
Date: Thu, 20 Jan 2022 17:53:00 +0200 [thread overview]
Message-ID: <CAHk-=whc9DAJN-TWPTnw=bSjHwXk1zDGeJ9A8eniaK7Jfax5aQ@mail.gmail.com> (raw)
In-Reply-To: <CAAH8bW_3mVqCxebkYeY0XKBfTAjPi1dtygCBEy4GpqvyeKAPqA@mail.gmail.com>
On Sat, Jan 15, 2022 at 7:10 PM Yury Norov <yury.norov@gmail.com> wrote:
>
> bitmap patches for 5.17-rc1
>
> Hi Linus, please pull these patches for bitmap. They were supposed to
> be pulled in 5.16 cycle, but due to merge glitch we decided to merge them
> in 5.17.
So I'm looking at this pull request that changes quite a bit of random
files, and some rather core headers, and I see *no* actual explanation
for what this pull request does and why I should pull it.
Only a "we didn't do it last cycle, so we should do it now". That's
not much of an argument. If anything, it makes me go "there was
something wrong with it last time".
I can look at the commits (and I did), but that's really not how this
is all supposed to work.
When I _do_ look at the commits, one thing that stands out is how this
was all appears to be rebased after the merge window opened (just
minutes before you sent the pull request, I suspect).
Which is *also* not how things are supposed to work.
I also don't have your pgp key (not your fault - pgp key distribution
is broken because keyservers are broken) and I haven't pulled from you
before. That all just makes this pull request something where I think
it's all likely good, but there are enough problems that I haven't
actually pulled it.
Put another way: the contents do not appear _wrong_ per se, but there
are many things in this pull request that keep me from actually doing
the pull..
Linus
next prev parent reply other threads:[~2022-01-20 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 17:10 Yury Norov
2022-01-20 15:53 ` Linus Torvalds [this message]
2022-01-21 2:33 ` Yury Norov
2022-01-23 6:18 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whc9DAJN-TWPTnw=bSjHwXk1zDGeJ9A8eniaK7Jfax5aQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aklimov@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alobakin@pm.me \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dennis@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox