From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C61C3DA64 for ; Sun, 4 Aug 2024 20:33:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81F276B007B; Sun, 4 Aug 2024 16:33:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CD816B0082; Sun, 4 Aug 2024 16:33:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695146B0085; Sun, 4 Aug 2024 16:33:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4D64C6B007B for ; Sun, 4 Aug 2024 16:33:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C4D0AA8228 for ; Sun, 4 Aug 2024 20:33:06 +0000 (UTC) X-FDA: 82415712372.21.36574E4 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf12.hostedemail.com (Postfix) with ESMTP id 7684340018 for ; Sun, 4 Aug 2024 20:33:04 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=F082moZh; spf=pass (imf12.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722803504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LJPoUhGsSbI3MesTWfLPEQy046rL3cbhs+jom/8YIqc=; b=KpTtBgTP/zMt6zf6ooqo8k8pJdWlttQCcMeCXxD3vwhkynDrrtnNzwALB/ox/ICgTNTMeQ 2Cj6xB6uTKGSn3S1T3YzSXAQVMUQuKqHELpmX/Nqx4v9WJ3DLZBVgPRPP3wvI0z1hgONv2 zJWOn+pI8I2QTOso0V9zqsMfEmU8Sh0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=F082moZh; spf=pass (imf12.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722803504; a=rsa-sha256; cv=none; b=xcpK3PdcpYAMAwcCMThhOuRsNK64Stlm0592nnvJgiT2PMgHU7rQKnP//1Nx7BaKIP1X4T SJ47MqM6zAvANFKxJCElpbr8C1Pe8LZ+wiDiOQXJuljjTK9Nr4MHPGx7dX3x5hYuF0ap8M K0dcvgxcBpmS7viR859co1nP15QtpNQ= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5af326eddb2so8025626a12.1 for ; Sun, 04 Aug 2024 13:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1722803582; x=1723408382; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LJPoUhGsSbI3MesTWfLPEQy046rL3cbhs+jom/8YIqc=; b=F082moZhIOqLgt6wJPh9kLjApGtRkFxn3xr/pmty2vdYinmdMJLeBjW6aoDIdj/8x7 FSnMVj4uIH9NqYzBgiQ1tTz6rNfEmXjtaZf/1JYpMA8shfPr+iT9WfS4oFZY9dmxje0O rXbQ8I6lbDeM9RALqAQhWnMUcrOeSjLew5xi4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722803582; x=1723408382; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LJPoUhGsSbI3MesTWfLPEQy046rL3cbhs+jom/8YIqc=; b=FYaj130JMWHIZQEJVGm/v04GIFI8pNht64pnvLf0SqAhnmT1i2aqlZy4ehUMgjnnzN vBa6nKuQ/KVX5LXjHh4s8eQDgIvYe5vW7pQlHpQ/T8+aqkhB7dUlFcPxRkVC/DZoHnob A5M85qjSY6rP97m2ZoAOG/GSizKmlnnFCgrLQlz40AOqvbdSfYYHmDmNL984dNMQ14jC mqafrIrOST0lVkrbBnvQwBJBKuGQ2E0Bka43ZC5OHq5dAzsNLiqRK7BIcbrP3y6dYP0N 7eRnlrhnqXTAYsmJy81yD3SvBwTY7sQOSqRx9xEDfn+0pnf0SwGSD/tiDwrqfVba1qRQ vMwQ== X-Forwarded-Encrypted: i=1; AJvYcCXqQsFteTDkOoPLrucwnIN1if3LnMx/f7eYICHa+7p6/NMddrvE84yXrYQD1yFaUTL6DRs5gYtEejfKinCUCU0Hfmk= X-Gm-Message-State: AOJu0YzWnj69apK2Lp2Pvt5Dx5zf0BQD/3cX4sjuLw7M9RE8ql1oTzK8 4ekieOOkxZa6q3C++yJOIx9TptQzo1u5zUdggi4fZyIuuqekDogiYD6uMSt8fbghReGjk1nmveO 6O4/OQg== X-Google-Smtp-Source: AGHT+IGbYMmiEG6yXI3+dfaEC+hTmgNhm2hiktI6XEb0UR89sz/xiS4r1BvpcwQzQ4W/m96P8mhUmw== X-Received: by 2002:a17:907:d1a:b0:a7a:a138:dbc6 with SMTP id a640c23a62f3a-a7dc5faf913mr855371566b.8.1722803582152; Sun, 04 Aug 2024 13:33:02 -0700 (PDT) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com. [209.85.218.53]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9d437c6sm363879966b.129.2024.08.04.13.33.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Aug 2024 13:33:00 -0700 (PDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a7ac469e4c4so853935066b.0 for ; Sun, 04 Aug 2024 13:33:00 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUPknWy53lw6TDk9nN/m4yWbn/rVN3jVVWHVG5nKkfwsZb0LYleQB6AcVUY0UmkALoyXvH5CTuHx0EEmFW8DAVK6+s= X-Received: by 2002:a17:907:608c:b0:a7a:1c7b:dc17 with SMTP id a640c23a62f3a-a7dbe63440dmr975332366b.22.1722803580241; Sun, 04 Aug 2024 13:33:00 -0700 (PDT) MIME-Version: 1.0 References: <202408041602.caa0372-oliver.sang@intel.com> In-Reply-To: <202408041602.caa0372-oliver.sang@intel.com> From: Linus Torvalds Date: Sun, 4 Aug 2024 13:32:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression To: kernel test robot Cc: Jeff Xu , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Kees Cook , "Liam R. Howlett" , Pedro Falcato , Dave Hansen , Greg Kroah-Hartman , Guenter Roeck , Jann Horn , Jeff Xu , Jonathan Corbet , Jorge Lucangeli Obes , Matthew Wilcox , Muhammad Usama Anjum , =?UTF-8?Q?Stephen_R=C3=B6ttger?= , Suren Baghdasaryan , Amer Al Shanawany , Javier Carrasco , Shuah Khan , linux-api@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7684340018 X-Stat-Signature: xq6kgogxekrqs1yod1cpdi66w4fkgk5o X-Rspam-User: X-HE-Tag: 1722803584-539188 X-HE-Meta: U2FsdGVkX1/ZhiduWOOQeeS01FdeVI+od+7PrLtliriuofdS+e8IAnkPAlW1lQ8GCgrGOlo4vRYmpyV+dBM5ISImTfnNYg5RKJSKj+nj1VEXc4KBZEH9ljacUPvWj7CMaarzsqiztzLVPUEZsTXSsH+Afjq2IQ3a+LnOpUNqRbEQTps3yPcwcybULUd+K6tTTkdS5qFwIhbtx7J/3iuqyKh8+oI3jrvhaXx4eC2MwH0BCj2sPDLaOcoi1f+V6YU33Yz0xgiqKb3tDYwQAZQXUuXArmcwSFZbtizf4H9QqZOH1OvBOhyEGn/Rsh6IKJzFwm1u3emN5ASKp/v36k3T13COHkYxdhDnKV9ZFSRTlk1mX1zH9NSZcfFnNmrNmcILb8R36b1H78+fbbRW3HnP1ClmTucVO+HEheHdaKlu24n9iJ9PYwhZWwhPDmUs94DvPOmQ8aid4GL/N5SFdBlsZVAzjR3AbNvPAQg+w3xKd20FByC7ng83J4mimQFsOo1Tk8xciHhBhQxa7Q36ZehEhLGYhE8Vb4sGHyhopIcGRfWF7boC0uzey+X1HAO7DkY1d3z3TVbrNn0oR19Y+ji8BFvdCBTyYOf0nMgKI114UK9De1VmaoO7Cx9XK8BODNRG7ZG7/7EK3ugVfoS6EgQMnaj9Ke8XkNeDvURStqIykUIZH6kfAOwuou+af0fnIpquPT4L3JefFUdenjxFPpON26B9TVjwYxdk6ITEyFCq8UFFDPA7ow0aNsSrGVbrUO0YwP62JglhXQtxqJ3/HhEmuMwgWbkqxqQbruMqWogfyJxbzkYAuECToJoT00x6w1pg1UtUk1p7b626iZv9g95aAl4NXkd3trPKBxP3OSoH8rkvOKFZWzTD+IrOdhkheVrjDIAPyMGbxnw9tqxubkjO9ZJDoiY059Soicd5GXOuiPEtaL9PKQvTO3dOW3FWkA91EFp5zeqWD2cADAkEXV5 63dzymPu JhduETleyiT2REKgspZWAz/vfCoSyb0t6jt9fi9nG8vRtmXDZwwkE5ToyucjdIWRFvp05qzH9zmf8dPZvO0fJ7ix1w/t7ciOn1/ptNx2G6UM65zrWHE68YiUTdLwWQA46vHDvChj3sFhSXgmv5AIccLUIGPCSMDwFurPT0b+bsN0dZmOjCxbBz3GvWT3fGDAnbdBBXWTzQa9nhH7tVY5yI/zGpOnT7Ax2BX2B9EpzQB/QEV2m5P8fzz9NEZ7m0W16y5xhNgQLZSuXsXqs5oUd+N1+wWDJzo0gSa9OjBiED4O5+X/OLsAdbDCBAYMA1sfZtkQaNKwPTVWU44dU8Tesw6PHYs8XVfogB7gAlMKAWp+w6B383/QaKnjCgMkiBJR2yXSxnOS90kMvBj9MfLcF0VEsfxwQuw4sCAyLfetBnj8oOg54he3iZnx0tMOipi/PSAOH0iVzOy+D8qgcxhGDRzD64fetDapvHy6JO+Ixy2uIuoazMROuUZDc2HTOIB6WWX5f3ZbuKOFskDkDWSsFJvy/Nx/wMb10q4i5PYchlX2+0Xx8nEBiWy3azTx4evnTxLFstPbBpuA76DoGq+5DeV+6wwqSr6M5iYwxakEAhy+Z9mMRflEp72p6lA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 4 Aug 2024 at 01:59, kernel test robot wrote: > > kernel test robot noticed a -4.4% regression of stress-ng.pagemove.page_remaps_per_sec on > commit 8be7258aad44 ("mseal: add mseal syscall") Ok, it's basically just the vma walk in can_modify_mm(): > 1.06 +0.1 1.18 perf-profile.self.cycles-pp.mas_next_slot > 1.50 +0.5 1.97 perf-profile.self.cycles-pp.mas_find > 0.00 +1.4 1.35 perf-profile.self.cycles-pp.can_modify_mm > 3.13 +2.0 5.13 perf-profile.self.cycles-pp.mas_walk and looks like it's two different pathways. We have __do_sys_mremap -> mremap_to -> do_munmap -> do_vmi_munmap -> can_modify_mm for the destination mapping, but we also have mremap_to() calling can_modify_mm() directly for the source mapping. And then do_vmi_munmap() will do it's *own* vma_find() after having done arch_unmap(). And do_munmap() will obviously do its own vma lookup as part of calling vma_to_resize(). So it looks like a large portion of this regression is because the mseal addition just ends up walking the vma list way too much. Linus