From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE14C433DF for ; Thu, 2 Jul 2020 18:11:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6831B2073E for ; Thu, 2 Jul 2020 18:11:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="aBC7CVuq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6831B2073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF8278D0018; Thu, 2 Jul 2020 14:11:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A81738D000C; Thu, 2 Jul 2020 14:11:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 949528D0018; Thu, 2 Jul 2020 14:11:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id 7A4298D000C for ; Thu, 2 Jul 2020 14:11:47 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3FE142826 for ; Thu, 2 Jul 2020 18:11:47 +0000 (UTC) X-FDA: 76993929054.22.glue37_410b81f26e8b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 9D20518038C51 for ; Thu, 2 Jul 2020 18:11:02 +0000 (UTC) X-HE-Tag: glue37_410b81f26e8b X-Filterd-Recvd-Size: 4010 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Jul 2020 18:11:02 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id s9so33344962ljm.11 for ; Thu, 02 Jul 2020 11:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4ZF2RO7D0EVWwMJZ+4s9BUuPvy5hetDDT+LtkKbx5jA=; b=aBC7CVuq4bDi327CCmAk00uAKzXwDXFwka2t1budpO1vnfIVa2mhtpM0hyc23Ybcsc 4Q9QSrTL8XeuvC6s7HWsM8siP9hY3nACHvOUGoA9Ud6+Hmi67VrIhRHxBHHtC9gyA+ed oAFRom3cS+moVq1MRyTJGXkqatICUT293Pa3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4ZF2RO7D0EVWwMJZ+4s9BUuPvy5hetDDT+LtkKbx5jA=; b=ufewGUtn9c0WxtP3uEc3kVrFmtQaqZZEGwuZdPURYxaRD2HrWC8N2DjcdUTrR8Imru wQYzSESBsUhOac6FFmymxCUgoljjVefkyUetbAFGLR1xMR87gnnTz3pcyXe/lhVIruCv 9KDrv9V2WblOMn+gvxM2q4tLWy+1AL0ao17ork9Wi0Qtqd1oKFbMZ+y1a/FEFv9SB9F+ QaTsIFsgoJiiAYGe/t99FQ+NHJ3oX2u2PAOWpF+FGXCq2BT6s71aI1X+fR9LYPueyvcy 8icuSVplGxAxYG9Bit1E4KhbjnzJsJ3jxcVj54gWiLcASdWG8/a77l1VrYryTHo5d5kG vs7w== X-Gm-Message-State: AOAM5328y+2En0MjBs5FDo7y7TreqaxAmkyy2GAqTCeW0y5Z3dIu+MMR XPut0dhqJIXHwX5TCvPJO8oplO/jbsY= X-Google-Smtp-Source: ABdhPJxj4h4QNRQjol+MNpkZt18gpGN/f0AC9kWmE/LuptJ4XW0zRqU/aC4TrPeV2sxsuIXfaRdBbw== X-Received: by 2002:a2e:978c:: with SMTP id y12mr5041461lji.270.1593713459846; Thu, 02 Jul 2020 11:10:59 -0700 (PDT) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com. [209.85.208.175]) by smtp.gmail.com with ESMTPSA id q21sm649024ljj.67.2020.07.02.11.10.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 11:10:59 -0700 (PDT) Received: by mail-lj1-f175.google.com with SMTP id z24so8502777ljn.8 for ; Thu, 02 Jul 2020 11:10:58 -0700 (PDT) X-Received: by 2002:a2e:760b:: with SMTP id r11mr2189529ljc.285.1593713458587; Thu, 02 Jul 2020 11:10:58 -0700 (PDT) MIME-Version: 1.0 References: <20200702165120.1469875-1-agruenba@redhat.com> In-Reply-To: <20200702165120.1469875-1-agruenba@redhat.com> From: Linus Torvalds Date: Thu, 2 Jul 2020 11:10:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 0/4] Fix gfs2 readahead deadlocks To: Andreas Gruenbacher Cc: Matthew Wilcox , Dave Chinner , linux-fsdevel , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9D20518038C51 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 2, 2020 at 9:51 AM Andreas Gruenbacher wrote: > > Of this patch queue, either only the first patch or all four patches can > be applied to fix gfs2's current issues in 5.8. Please let me know what > you think. I think the IOCB_NOIO flag looks fine (apart from the nit I pointed out), abnd we could do that. However, is the "revert and reinstate" looks odd. Is the reinstate so different front he original that it makes sense to do that way? Or was it done that way only to give the choice of just doing the revert? Because if so, I think I'd rather just see a "fix" rather than "revert+reinstate". But I didn't look that closely at the gfs2 code itself, maybe there's some reason you did it that way. Linus