From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06893C433F5 for ; Sun, 24 Apr 2022 17:43:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CE0A6B0074; Sun, 24 Apr 2022 13:43:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47D546B0075; Sun, 24 Apr 2022 13:43:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31ECA6B0078; Sun, 24 Apr 2022 13:43:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 1E6B96B0074 for ; Sun, 24 Apr 2022 13:43:55 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DFA4F1C3F for ; Sun, 24 Apr 2022 17:43:54 +0000 (UTC) X-FDA: 79392495588.29.50D0D0E Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf04.hostedemail.com (Postfix) with ESMTP id 4B3014003D for ; Sun, 24 Apr 2022 17:43:51 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id w19so22531563lfu.11 for ; Sun, 24 Apr 2022 10:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=peeXpSGRMeGEzoalpORyTqQLMLKNcHauKDKhUxOBeNk=; b=IekpBZl+Z1RTJbQ89uIac/0pvqJlPZbLqqT1M3FrGlhuNapxhk9LXvDklkTRji31Iv YqTjbVNa45HZCZIFzco0ewinoAbriHZX7UDnNI0FvzoEh8a8GQ8BBe2n2fDNj6t+nH15 eBbh3tx/hkS1SojrqBNx+y9nwQoRTjBiF36VA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=peeXpSGRMeGEzoalpORyTqQLMLKNcHauKDKhUxOBeNk=; b=HX3IFvsW4nXgyLer3veeEDaJp+02+HmvqL+9Xch6sRwkX0o1DcjOIs8ReMWzH8fEZG cAmtnlVWBk3BHnEHYHrgKC7M7cbY4nPYJHNWx5Gc2+3o4EaoGa6dgnOwYTU21it0gv93 3p1huZc7dX6GSliExV8+UD5T2fvmqnYwNbcQ9sqA6MPQJmutg5L9TjpI2OBElPQef/pU i6xzvCKiy0wNLwin0Z28gH+V04TKOBy4LBhqVvpRz8zSgDC1ccJ2SZcv3fRIx0lPec16 E4F9ShFakKPJyW3HkW63FH2VMvl92JgTJGewfGUeOK6Upsu21HPS598p+uIL1vR+6t6p mLUA== X-Gm-Message-State: AOAM530LJYzn9AUFyzZD+sXNMlxKb0Kkw/OE4vkfGJrDkVINtU1Je1Q8 +u7sR9r6TBknErNxmb8UMSPMdizhLBcUd0sX X-Google-Smtp-Source: ABdhPJz3zCfFlE092Nd+qvUgAymigiURem+LIYOTexwd948RYC/7NWtAwafdITqdqoPTkeUF2GQe8g== X-Received: by 2002:a05:6512:2215:b0:472:760:dd3b with SMTP id h21-20020a056512221500b004720760dd3bmr680163lfu.377.1650822232446; Sun, 24 Apr 2022 10:43:52 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id r1-20020a19da01000000b004719d5a2de5sm1084726lfg.301.2022.04.24.10.43.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Apr 2022 10:43:47 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id h3so17832463lfu.8 for ; Sun, 24 Apr 2022 10:43:46 -0700 (PDT) X-Received: by 2002:a05:6512:b12:b0:44a:ba81:f874 with SMTP id w18-20020a0565120b1200b0044aba81f874mr10677909lfu.449.1650822226569; Sun, 24 Apr 2022 10:43:46 -0700 (PDT) MIME-Version: 1.0 References: <20220415164413.2727220-1-song@kernel.org> <4AD023F9-FBCE-4C7C-A049-9292491408AA@fb.com> In-Reply-To: <4AD023F9-FBCE-4C7C-A049-9292491408AA@fb.com> From: Linus Torvalds Date: Sun, 24 Apr 2022 10:43:30 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 bpf 0/4] vmalloc: bpf: introduce VM_ALLOW_HUGE_VMAP To: Song Liu Cc: Christoph Hellwig , Luis Chamberlain , Song Liu , bpf , Linux Memory Management List , open list , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Andrew Morton , "Edgecombe, Rick P" , Claudio Imbrenda Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 6epoywz5o5im3p69k9sjeq94c3wki5om X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4B3014003D Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=IekpBZl+; spf=pass (imf04.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspam-User: X-HE-Tag: 1650822231-417736 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [ I see that you posted a new version of the series, but I wasn't cc'd on that one, so I'm replying to the old thread instead ] On Sat, Apr 16, 2022 at 12:55 PM Song Liu wrote: > > Patch 2/4 enables huge pages for large hash. I decided that for 5.18, we want to at least fix the performance regression on powerpc, so I've applied the 2/4 patch to enable huge pages for the large hashes. I also enabled them for kvmalloc(), since that seemed like the one ObviouslySafe(tm) case of vmalloc use (famous last words, maybe I'll be informed of somebody who still did odd protection games on the result, but that really sounds invalid with the whole SLUB component). I'm not touching the bpf parts. I think that's a 5.19 issue by now, and since it's new, there's no equivalent performance regression issue. Linus