From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB82DC0015E for ; Wed, 9 Aug 2023 15:05:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BFFC6B0074; Wed, 9 Aug 2023 11:05:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26FAE8E0002; Wed, 9 Aug 2023 11:05:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 137CD8E0001; Wed, 9 Aug 2023 11:05:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 038276B0074 for ; Wed, 9 Aug 2023 11:05:58 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B9493B2808 for ; Wed, 9 Aug 2023 15:05:57 +0000 (UTC) X-FDA: 81104891154.23.7B23507 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf12.hostedemail.com (Postfix) with ESMTP id C1AE540017 for ; Wed, 9 Aug 2023 15:05:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=F0JapzA4; dmarc=none; spf=pass (imf12.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691593555; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oNfy891wWQJn9GGaD6lb4vpiDtiobMWaR2UsMEivbwk=; b=743+oortHbLmUma9PNQsbZTnle0QN2M5ZrDXrQsolG+zIm0hZ8Fmtae5vJUbnYUBMxwlTI PclJI3tY6835nf1ZMctuSFp70ezdntilgD4KTbRMzsh+1GLBY9Rmxno1StVZ+s+KFpAusz NxqGjsrgR4PzXUsOdL9xHxZ+GQSCEQI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=F0JapzA4; dmarc=none; spf=pass (imf12.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691593555; a=rsa-sha256; cv=none; b=Yd1JhEaVIybAbCF+E5g1N+6rmSvgh+1xNAyByl7CXJdd3HZPLGgPXklrYTQ03V+H+ThJJA 5HZ4S14rn7n3Uc/3TsGYOpdDUW/hoDSBR6YsD46wwI0Oiv/kiR+mfgW7XBnSpp7iGB9nJm 0NjGLNYi73Qd4TdI6ZoNjyRk1c/zBik= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-99cbfee358eso611425366b.3 for ; Wed, 09 Aug 2023 08:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1691593554; x=1692198354; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oNfy891wWQJn9GGaD6lb4vpiDtiobMWaR2UsMEivbwk=; b=F0JapzA4Vi9mJy4NRwWsAHDugEqxju565TgTe91RCVzWfxEK4zaUiw+PeaO+Cf+MGb 2MYvnDPz86UyKxutV25GqOcjXrYiHTASwOdBAOcj1c+kpppwC/zhdHkoEqYJmKybkMbp DoUc9NyMYujogrq9if20PNFIPdX5d8q7MR+Xw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691593554; x=1692198354; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oNfy891wWQJn9GGaD6lb4vpiDtiobMWaR2UsMEivbwk=; b=O21W3vxii/pkbVzUZYnakB++4Ci2SHsVErjNR1yONm+8Lyl3rEXs+GMNaz5s70fT6Z Bfqp6ijShE3LFq0pDhwhYbbFppXtIxqbjVWtA+3KsJCpN6mvtNKvp7Xv3VRZd0zz8hwr wiUvlL9lSzFoYkhwaGJh7hXRAGgejicIisMu14s7edibRKUjOVcI9myo4TMA65k4MQOy W5a/eSnD2+4qj0Zn7++v3PSarhjl0Pg+rV8WBehKwKTRYVEXRzI+ttZpPOK9O5lsGfN5 gCeMeDXF37owSis+ZomfatwiN7826LmnHPXEhIha3ELi2Pq2bI8v8Y4rX9jUzXTn0Dvo y5rA== X-Gm-Message-State: AOJu0YzR10T6RWzrHAysf9AhfU+KxkedUg8pbiWXelqHlatrKOoxEBYM /5MfCgkj+TnZ3sTMmWcWu7vRp2IAxknLa8FKFmvXcfli X-Google-Smtp-Source: AGHT+IEeAh2ZK6s++Mus2T92U/Nibscd43YX4ao5phs0UIKEWLsngfuB/C/8aWOO2uto2M3OD78fDQ== X-Received: by 2002:a17:906:208:b0:99c:180a:ea61 with SMTP id 8-20020a170906020800b0099c180aea61mr2031177ejd.32.1691593553911; Wed, 09 Aug 2023 08:05:53 -0700 (PDT) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com. [209.85.218.46]) by smtp.gmail.com with ESMTPSA id n26-20020a170906089a00b00988be3c1d87sm8050260eje.116.2023.08.09.08.05.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 08:05:53 -0700 (PDT) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-99cbfee358eso611422066b.3 for ; Wed, 09 Aug 2023 08:05:53 -0700 (PDT) X-Received: by 2002:a17:906:5382:b0:993:eef2:5d61 with SMTP id g2-20020a170906538200b00993eef25d61mr2523827ejo.27.1691593552995; Wed, 09 Aug 2023 08:05:52 -0700 (PDT) MIME-Version: 1.0 References: <20230809144600.13721-1-kirill.shutemov@linux.intel.com> In-Reply-To: <20230809144600.13721-1-kirill.shutemov@linux.intel.com> From: Linus Torvalds Date: Wed, 9 Aug 2023 08:05:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: Fix access_remote_vm() regression on tagged addresses To: "Kirill A. Shutemov" Cc: Andrew Morton , Dave Hansen , Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , Dmitry Vyukov , Rick Edgecombe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christina Schimpe , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C1AE540017 X-Stat-Signature: t8usmsnugcqq4sab98m8d4qiungotu4o X-Rspam-User: X-HE-Tag: 1691593555-647707 X-HE-Meta: U2FsdGVkX18/4xr79Jrcr1KX9b8Hn7hRJnycl7GVgpnrrbldTmDueab4CSG+bTs83YBB5F9dvGIcd22owXejTsWzx2Bvn/sbJeUyddonYxtb34UbOmx1BWCTcoNdnp/vs4n+INcDS58viDON/DpeMWFlg/qFJQ43eWO9QkbwfYCwDRR9M0NXjrC3ecsVP5fYwMD0vAIEKVZmAZoBSrlmXhSM1fBIif3kn4NIITalh0iehuTNPHI5ImOhtLPJheDiz6fR4cwCL1Eo0yGsokhViAQNOxH9myKwJp9xm6k26NMG4qhl6ci90ACJUSH/u4AxnS8A7KTEyUxs8dnuuccK2rrFwG56ALYZPei1HnTNzzPCj5oKvupM9cTtTAxgK4Tu3yBkF8U6ZuO46xJMjIg4LIEkysBYgg1/FPeb8Le+9WAN+OqC6rYHpsqek0a9MR09rUjt4RFCNCMWXQg0jpSgNwT3jw+P4Fi9c81JWVjrH71VzvyhX3bHEAxPVzIH54FP0ksQrTRlCcCPc8Nm6SuG/aJamshle9OkYu3K7qV5gjzdynCLJRbv1+8VaYG5QOWLf8SSxvX7SXuHmQzTYyziTEhjochnhFLuGe9NUZjXxK6/WFNhm47UWBl/Uh7284dZ7u+IaltzKUiFwuUqOHLEE6GQuXqCOA+SNQiOmmdqU8fqNhgQf8tRU/9vXJ3GBUUrMfbci4woG57hlEVTmm+cDk1Xv4E2CDXcq76Ds4Fs5nxm3c37o1Ha/h0qZc71TpWSBgGduHBMvCqxctNzaQ2ZBTziGUt1WTVOigOmITGpgBuiGZAdZ4UKpnssJ9We5pVtKyIOeh2HUJcO5/ZIvKoFEI4dBBi15CTN7UlraBXfvWQlldNFWgpg7RkmmUMemMAopsm4xjUc1muzOQbB0zpFIdyJ4OKkoYsweS7NQhMY0YQvM6pFXxqlnZiWfvvIpKDZGuqpQ15DBDBCfJ3KeN9 ZJ1SyPMi 3z6RnEz8zTK6MlBtk8wV0JnzLBqHXt5UmG5lBuazbmQNk+9b0WqO/sZ4XNMEd4epzC4MKYVDy2T5ANg1CmUhZG+8ubldzB0EbbkWY+z4MhdkHJ05RtaBW0SbcZAsrk/dFGk6wX2YEXbknVew/vx4ZyegzFrVxHIz3O9OfU0JWDnuRdC0DTA6+3wqGvwS/+mwHBpXM+7MSjtRsixgKL7czIJ2VMnTy8DSoieaffWzeL9QUimHmhUizBAEjselDTCAm2R7HMseFgMJozJEOfVvHrK9z8u753GIkYocuSk81+CiM0rqI1xCiB/yvW8aQEZaPCspAtBFuyQRQ7Fb1Xj1RcSDmnWJMHFEPRzn7gYbGdpG8q3Cny874wIpXKv4nxUnNvIZ1vy7uiXUpR3BBtGKb4HuzViE2Cv9o3cTB9obpcIP5kS1D/AdaeLmRAddBoZQADeDkrHeG86gdkxCXeaY+5ncZvWhLZa2U7GQ2d3vhXl1QVBYaridW9f3cM4Cw7c+8R2RR2+Ct/2qlfPTbw1Fd26ssxb+m0vCrg0sHMNAJ+dt6rrhi+WUhXnHP4vy4cQypwu37M0f4T2nopaWb01Ld/9wtCM2biF59wQafwpigpLH8oMhw/1QBu8Gj6HbKJab3oa2BB4DKtMQVxS/bTKGgLQDwTvzCX6M4MycC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 9 Aug 2023 at 07:46, Kirill A. Shutemov wrote: > > mem_rw() of procfs uses access_remote_vm() to get data from the target > process. It worked fine until recent changes in __access_remote_vm() > that now checks if there's VMA at target address using raw address. > > Untag the address before looking up the VMA. Interesting that it took this long to notice. Not surprising considering that LAM isn't actually available, but I'd have expected the arm people to notice more. Yes, I have (and test) my arm64 laptop, but I obviously don't do user space debugging on it. Apparently others don't either. Or maybe TBI is used a lot less than I thought. Anyway, obviously applied, Linus