From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7716C00140 for ; Tue, 26 Jul 2022 16:26:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09C0D8E0003; Tue, 26 Jul 2022 12:26:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04BEF8E0001; Tue, 26 Jul 2022 12:26:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7C958E0003; Tue, 26 Jul 2022 12:26:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D97E68E0001 for ; Tue, 26 Jul 2022 12:26:57 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B63891A09FF for ; Tue, 26 Jul 2022 16:26:57 +0000 (UTC) X-FDA: 79729780074.14.C50408F Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf27.hostedemail.com (Postfix) with ESMTP id 4324E400C5 for ; Tue, 26 Jul 2022 16:26:57 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id va17so27182784ejb.0 for ; Tue, 26 Jul 2022 09:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ttV5vBFo81neCUa67b9tRifIFb4vLEVioSDpa2+KStc=; b=bQNn/HIEV6bNqMxSkqhpn4F1zuXjz1nAKwJuWwLas4x5rbqspUs4sfKW2IrX9JC/Z8 R8wsOZP1GmQxF2GOMGx+JO8TuOmZmJDbMl5Z0bkLy/XRtFz/ZUXZ1rGiV5qZuHHHkQrE +H5bBo55CttlIBNL7fMpNXlGOnttCDBoa1FwE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ttV5vBFo81neCUa67b9tRifIFb4vLEVioSDpa2+KStc=; b=P4w8Y8i/9broKKh6sIFhlFcqXScT/8uWqX75xc7QiFwDqGwwnrELq3JSj/roaT4HMH Gakr9EECls/nNV+CP8zHZ2btxMjhEHdAld9qXa72/4MMrB+7b6lzzC2sSbJmBPjrHztc cYO4f30SkIhfR1F3ZMSLTFMmYW4jZGghcdO6kxKNsUrl7kk9w+Q1daBXe7ldfvhoO62p 1vS7h8VhwjtFhW07KJ5utI/6nlV5q17aY/1m0BU0ywjvMHtfwdloc3Z1mhP+Oub9Q6VS yrjLGyNklWCsbaJX68z7p98ON7YP6ni3XfiD5UsvEtsh3Y/RyzAOUyxNzDFgMgYu2Kca mumA== X-Gm-Message-State: AJIora/piD7qfFbM0BOvfFaiemVLIWY4MIcFxTQ4BYmcQaO5YANpK3+I RGbwcfwjuFQj8zJf3z6UVstQEdAPsO6urvkS X-Google-Smtp-Source: AGRyM1uqb5a3pycX+k75dbUfcW2shUvqO11BPhVSG3ivZKlRc7LUYBXtqPw2t+Rh7MuzM3j0Ld8J+g== X-Received: by 2002:a17:906:8a65:b0:72b:67b7:2c26 with SMTP id hy5-20020a1709068a6500b0072b67b72c26mr14706893ejc.212.1658852815630; Tue, 26 Jul 2022 09:26:55 -0700 (PDT) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com. [209.85.221.41]) by smtp.gmail.com with ESMTPSA id fi22-20020a056402551600b0043bd2a79311sm6873794edb.37.2022.07.26.09.26.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 09:26:55 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id v13so13120872wru.12 for ; Tue, 26 Jul 2022 09:26:54 -0700 (PDT) X-Received: by 2002:adf:dd91:0:b0:21e:4e97:c146 with SMTP id x17-20020adfdd91000000b0021e4e97c146mr11197493wrl.281.1658852814595; Tue, 26 Jul 2022 09:26:54 -0700 (PDT) MIME-Version: 1.0 References: <20220726062436.90290-1-zhengqi.arch@bytedance.com> <621fb975-413d-a6b4-8126-0b78d5b60853@redhat.com> In-Reply-To: <621fb975-413d-a6b4-8126-0b78d5b60853@redhat.com> From: Linus Torvalds Date: Tue, 26 Jul 2022 09:26:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: fix NULL pointer dereference in wp_page_reuse() To: David Hildenbrand Cc: Qi Zheng , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="bQNn/HIE"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658852817; a=rsa-sha256; cv=none; b=W+RKcafiijExcXTayZCDE7way93kD+Y2P3iHRSqBPdjtnQOadgjPBQSaUoIrL3d4t25+CP +mg0sLKJu1/CMYBg+nrb7vBgHOq709I/lH00L8nnkvGsfhd0+edZLG85cX61YVd0lsXxQm 9ar0V54dumxLwlzVmFC4dLaQCTS+OEk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658852817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ttV5vBFo81neCUa67b9tRifIFb4vLEVioSDpa2+KStc=; b=pYHWCFCdDyWIV13DiKNTYGfpTzWUQIDmvrDZzu/47VPzIsxdYAE5B92no2wQS3SUISDH3a InaDEk6J+1Kz9j3tCLjvlL2lTUb2zJImUCVO5/ZQoxv+NiUycc6dI1/4mnhMxbfDx6V90I 6eklTQgr3fEm1hbXBRVDmHZUg1tvOLM= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="bQNn/HIE"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: a6659f8i5bjzqs9ejqegt18exbpe8hdk X-Rspamd-Queue-Id: 4324E400C5 X-HE-Tag: 1658852817-671939 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 26, 2022 at 12:45 AM David Hildenbrand wrote: > > > VM_BUG_ON(!(vmf->flags & FAULT_FLAG_WRITE)); > > - VM_BUG_ON(PageAnon(page) && !PageAnonExclusive(page)); > > + VM_BUG_ON(page && PageAnon(page) && !PageAnonExclusive(page)); > > Indeed, fortunately, only an issue in the VM_BUG_ON statement Well, at least Fedora ends up enabling CONFIG_DEBUG_VM by default, so normal people - not just VM people - can definitely see this. > Reviewed-by: David Hildenbrand Applied. Linus