linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>,
	akpm@linux-foundation.org,  linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix NULL pointer dereference in wp_page_reuse()
Date: Tue, 26 Jul 2022 09:26:38 -0700	[thread overview]
Message-ID: <CAHk-=wh_TrgNm6vz7=7CgZppr0UrZ9TwLyb3dgPXyG-w=a8kJQ@mail.gmail.com> (raw)
In-Reply-To: <621fb975-413d-a6b4-8126-0b78d5b60853@redhat.com>

On Tue, Jul 26, 2022 at 12:45 AM David Hildenbrand <david@redhat.com> wrote:
>
> >       VM_BUG_ON(!(vmf->flags & FAULT_FLAG_WRITE));
> > -     VM_BUG_ON(PageAnon(page) && !PageAnonExclusive(page));
> > +     VM_BUG_ON(page && PageAnon(page) && !PageAnonExclusive(page));
>
> Indeed, fortunately, only an issue in the VM_BUG_ON statement

Well, at least Fedora ends up enabling CONFIG_DEBUG_VM by default, so
normal people - not just VM people - can definitely see this.

> Reviewed-by: David Hildenbrand <david@redhat.com>

Applied.

                    Linus


      reply	other threads:[~2022-07-26 16:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26  6:24 Qi Zheng
2022-07-26  7:45 ` David Hildenbrand
2022-07-26 16:26   ` Linus Torvalds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wh_TrgNm6vz7=7CgZppr0UrZ9TwLyb3dgPXyG-w=a8kJQ@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox