From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743AFC2BA16 for ; Fri, 3 Apr 2020 18:01:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2CBEF2077D for ; Fri, 3 Apr 2020 18:01:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Ys0nLdOP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CBEF2077D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B518C8E0008; Fri, 3 Apr 2020 14:01:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B02128E0007; Fri, 3 Apr 2020 14:01:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F0888E0008; Fri, 3 Apr 2020 14:01:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 85BA88E0007 for ; Fri, 3 Apr 2020 14:01:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 462BB180AD81D for ; Fri, 3 Apr 2020 18:01:32 +0000 (UTC) X-FDA: 76667311224.12.rose20_81cbd7be11511 X-HE-Tag: rose20_81cbd7be11511 X-Filterd-Recvd-Size: 4808 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 18:01:31 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id p14so7851581lji.11 for ; Fri, 03 Apr 2020 11:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=Ys0nLdOPaMPZHWrNpQG57PugKN6mkPGdJSUx/TQDpwY2GQmZdYkhxJaiTGDykgi3DV b9peyP0pK7wyoIA4rX92GpUwZxOJ1gL4WdkK8qsym8w0OHPBQz5LC8Pgsely+7R6EED/ Y1qrLKu/XLubSi3S/jM7cWoFX4dK0Vuw/7IEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GJVFgRSGYKBnNbBPTVD/IukQXQa7rwPwND5Kh+NTBuo=; b=VL6uuBTlSTF1zm1FvAZ1QtHRhlTscnZni/RyIM9LlZxn/3s6GIyFUzk90lhX5ciXEX LZilo+LSkv+tLrliQdlc8og9ipn/1isBt89TrJBl9xCwyfIbgbGRDEGQz7COe3R6TpBA 2ztxRn+GRdqa1Bi5Ht2M4zG9VEGF8L3MPxSkRnBeocLyhImMbNNV8TtcftWCczF0YJBr nPnkBhD+NQ9xiI7b5VUkw+40dnYAG7FQIFR2mJ3CmzGVdoydKJvSpDpCbE1eY1Gqhjrq RbfQB2+W+kYjLSbaw2YIqUWyxkmVv9hMz+oi6U0w+Eqwpqkx1Z3gC7q7CDBBtcCA8xST raCg== X-Gm-Message-State: AGi0PuZl0gY99JGG3eGnINc3QJLP2yes54MBXEyl+kec7mXX+dz0gDm7 HYxnlhSGj3p0TTXdgSYhaEwMgFmqBTo= X-Google-Smtp-Source: APiQypJmtditg6y5zpsgkCuY5Ct29ID+sbT7UdcQRAz/E44bLMluj72E+PPyVYic+13WN2RSt4jU2w== X-Received: by 2002:a2e:b005:: with SMTP id y5mr5501701ljk.25.1585936888550; Fri, 03 Apr 2020 11:01:28 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id g5sm5358837ljl.106.2020.04.03.11.01.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 11:01:27 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id v16so7892213ljg.5 for ; Fri, 03 Apr 2020 11:01:27 -0700 (PDT) X-Received: by 2002:a2e:8652:: with SMTP id i18mr5777613ljj.265.1585936886747; Fri, 03 Apr 2020 11:01:26 -0700 (PDT) MIME-Version: 1.0 References: <36e43241c7f043a24b5069e78c6a7edd11043be5.1585898438.git.christophe.leroy@c-s.fr> <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> In-Reply-To: <42da416106d5c1cf92bda1e058434fe240b35f44.1585898438.git.christophe.leroy@c-s.fr> From: Linus Torvalds Date: Fri, 3 Apr 2020 11:01:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/5] uaccess: Rename user_access_begin/end() to user_full_access_begin/end() To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Dave Airlie , Daniel Vetter , Al Viro , Andrew Morton , Kees Cook , Peter Anvin , Linux Kernel Mailing List , linuxppc-dev , Linux-MM , linux-arch , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 3, 2020 at 12:21 AM Christophe Leroy wrote: > > Now we have user_read_access_begin() and user_write_access_begin() > in addition to user_access_begin(). I realize Al asked for this, but I don't think it really adds anything to the series. The "full" makes the names longer, but not really any more legible. So I like 1-4, but am unconvinced about 5 and would prefer that to be dropped. Sorry for the bikeshedding. And I like this series much better without the cookie that was discussed, and just making the hard rule be that they can't nest. Some architecture may obviously use a cookie internally if they have some nesting behavior of their own, but it doesn't look like we have any major reason to expose that as the actual interface. The only other question is how to synchronize this? I'm ok with it going through the ppc tree, for example, and just let others build on that. Maybe using a shared immutable branch with 5.6 as a base? Linus