From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91AA7C3DA63 for ; Wed, 24 Jul 2024 20:03:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23D316B0083; Wed, 24 Jul 2024 16:03:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EBE76B0088; Wed, 24 Jul 2024 16:03:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08C776B0089; Wed, 24 Jul 2024 16:03:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DC0BC6B0083 for ; Wed, 24 Jul 2024 16:03:11 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8EE49A4368 for ; Wed, 24 Jul 2024 20:03:11 +0000 (UTC) X-FDA: 82375720182.23.0A1D7DB Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf19.hostedemail.com (Postfix) with ESMTP id 6F8F61A001B for ; Wed, 24 Jul 2024 20:03:09 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="DaXxgw/t"; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.221.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721851341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lomV1atdSgU0uSbgjxspjmfWfMuhMKKB3Hl+Hsile+U=; b=xu2+A3z3okUzcJbpcXqrOWMl748Un36aCVN6poVYNKIVpmA4bpcDruuIBgjRn/f/J8v5+8 UoMokzoXMOQvfMetj4i5Red3U8cRB/DRKNStpt+aY7z3obdgIyIQzL7FiX7phyri0JPOWk XEzqua7HAMz8jt3hkrkBd4cruE6U4aI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721851341; a=rsa-sha256; cv=none; b=MqJ5Ab8MvFtmkmxlJUex0aH+OKIoz6aseciOWWbI/xOd2IJnOHzjYi1H1sh7DLG2l7Bp+n eY2TgPjYD5Nap1Mkg2Pi3rChjxEnMtbnjhF7/B7YMUtLNhplnxCnFOYYZF99R6UxYsrEro ONz152mwfP4V+XHaAwZiZNX8lAk5Mjk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="DaXxgw/t"; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.221.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-369f68f63b1so70274f8f.2 for ; Wed, 24 Jul 2024 13:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1721851388; x=1722456188; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lomV1atdSgU0uSbgjxspjmfWfMuhMKKB3Hl+Hsile+U=; b=DaXxgw/tpZvxty2sYKaoAEL7/w679shU5fZCZYOar12Y1V1giUEP0BZ1Kw1ikkd5E8 3lLPdYQ6n8pFoEz8VXQe5UA1IpoPfSQ6fzx/R40VlOJWV6VwhKiVKHzRAH3DoCTAUf4J ysMZvj9xSOTD6r2HFPrXOMT5s11D+kLqetktw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721851388; x=1722456188; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lomV1atdSgU0uSbgjxspjmfWfMuhMKKB3Hl+Hsile+U=; b=pyPatLah+e7CyUDODIE0YzQx+10kAcdtt/eZbTR7xatlpwowE3dzoc2+u5Oj/T3Uhs eqMHVkE3FTGai9nnhfg/i/Hg3TwAPCcsgI9pKv4UrUxhS5SGs/cU6TOrls0YLeR1PIp8 lHGXyKVMkGB5tQFzlFYBqcc0Brsuq8sAQeECwAaChITPuv9UJv4EjbZ2xzI3NurvSJbF xnmZtYNjvZz/JwXy5eJA2ZyfS2Y3qzBVvgC1OHKAKGXavdOn3OjgS/d2YZ5v9neBCba5 3VH6b2bAeFTZOG+TU5mjAve/sy6HgrGTiihJF8iA3dOPMLzmY5dgCkvIYMxNR+MxkkZZ GLrQ== X-Forwarded-Encrypted: i=1; AJvYcCVyNCykG/1nfbzWHPqxoUbXnoYES2hrafC1nntb6NkiBH3iMJNlyo/umgMSnO1xFv75tPahp9zIY9131DCyzgclwC0= X-Gm-Message-State: AOJu0YxXAOXFjEJGml7J/NLsd2fbm9TujIs1BQbWqDcH92JHQTV2vBZI ljljJA38KA7gvUqHXKSuu+raAcx6efUDieSc/gJnm0Z6nIaItEcpUosX01hoOOuBLFvd3sr6LuU DT6o= X-Google-Smtp-Source: AGHT+IFBIfg9EhdQZv43PcnsHwZQonJUdgnPXpXzU93MnbPMGz+URYqDzCLT89FP69C4IvBMOwVZQA== X-Received: by 2002:a5d:4dca:0:b0:368:7256:9c6a with SMTP id ffacd0b85a97d-36b31a0e509mr440019f8f.36.1721851387751; Wed, 24 Jul 2024 13:03:07 -0700 (PDT) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com. [209.85.208.54]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5a30a4d7b90sm9324586a12.2.2024.07.24.13.03.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jul 2024 13:03:06 -0700 (PDT) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5a156557029so298468a12.2 for ; Wed, 24 Jul 2024 13:03:06 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU/yP4PN0waN+butNEXrlDFNomY5qftMUx9URErD7+tlYHdzHUpaw1+qeeT1A048NGSpfGmokjx5BpTGgNA43/zsKw= X-Received: by 2002:a05:6402:35ce:b0:5a2:2ecc:2f0 with SMTP id 4fb4d7f45d1cf-5ac2a2dd11cmr245013a12.1.1721851386493; Wed, 24 Jul 2024 13:03:06 -0700 (PDT) MIME-Version: 1.0 References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <03601661326c4efba4e618ead15fa0e2@AcuMS.aculab.com> In-Reply-To: From: Linus Torvalds Date: Wed, 24 Jul 2024 13:02:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/7] minmax: Simplify signedness check To: Arnd Bergmann Cc: David Laight , "linux-kernel@vger.kernel.org" , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: i19c5b1sct7gn7wos5xedm4gq3enzoib X-Rspamd-Queue-Id: 6F8F61A001B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721851389-939663 X-HE-Meta: U2FsdGVkX1+/mM216NYMLo6UgDtDqzA+WNegV3HSDiQ9s1zsczJP5mS0+4BDiL/ElWTBuBjG/huPCdO2Vl/SgGaTnLe0IqFTmSPtU0CYiorP2JtR0rRB8C/UrCHvbGGxrApeuS1DE8lVt8fhFRVzH4r4C8imddLYHRzGoTdukqlwTjfyrIiiOUWmZU4g5KLZ7nbtVW4JWFxT3VtVRpxLRpgFs6mOq8EQAJ1Xo6ljbwhiAyfVmC8N9Trfji/1i2q8aQBaHghZR4y1NIU+FgYPnQkrd38oZCCJc67BfVR+QgL9DgooqgYNYKY12LtO/QinSkKqwZ26s/NOwVgOUdPPJRelcPfcQ/Jdar5ILfAHqXsSCdxHYwtbrkdfcPai+f6oq9Zf+JGL2AgLi35F7cb1ERnZm1o/HAR67LDX/zx+iR8/DoqHJDwDE+O2n39X9bHZ6aO+w/fVyMtSoTFwV0EfetrduiMO18SITQhoX1vO/2ji93nPlaKI5ADvcouWPQGJcmzBiKz+yTTS/D69HWE4SDzF9iYqgnQ4SufKeOvvlelappu6B1B2i5B8zTrubyUTLsE9o4Hrt3eIXa9k7QOWrJBvEj/w8jwU7ZVpOip7YGdh0obTYtBMmjs7DZkuF33psi74n5OI9jBRcZFVg+f6M41DY8w9v7lKslgDNU7UbhmMqbcVfaBRJ0oienYtYQTxVWjRH9PszThka5E/ygrW839tMFv6ZM7ZdSWFLAV5AUsSQ7BzPJzPaSD815KVUVts0A0wa3bcLWoPoPuc0gQfllxZOrWrCO92zbvnt7vlWqxPEebgeCP2jB/G3UQiQh7wCPat0GEAZuKraDE60TVTmg4Y06lb5k/ZW7tqvF442V/ui6sXS0rO1FaQGNry1tFo5CqJPvKGkU7HlyywL+XpajGqK/DWDY2etXcxyChael4Bk0cuSYuICSrQjSAyzyRbXH8nhSnm77ig7E5HBt0 2Gi8hb8b 5lve0D2dlPHg+fbPHmRIyH1c9awFx7P1w0u4eze30+HI/tatqTemIJ4DbYWic7R+mLSCAQtmnWI/b5IbphB+cno6m8wXkQI361eYvLTKTlcZuNlnmNAxEqtAVLw0KeMtl50LXUYUs0wIXcPbX42/A2NAEQ3zqqaZ7C4zpeif5Vefff4tr+b2mGDve/+akCh05F3EzGZq1+yhmWzKGkNaxViTXhCYhDsqHpVjkwrHkqnSw/Ct8tbF5rmdIRxQ8+ClSgsMzLN01fe+tFy8bEbLwNq367SY8pegwGxmU6yY7yJ1trvrUOhpwm+3yTTHId0d0Dg1/w4iuv63MMVqYO1jMadeNLWr92Sb+gUy97ewdGHX0ezZjgv3Nxgtk2Jy3KetAUwqYOhDPOAHrfwvnO9qWu098xNTSvshnP85FQ5fUxDsKDMa6LsGTlKHfgbL3fD/LWD582/Av37v68aE6hXWk6M6Crkd6athAcfjrg4LR651MxXQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 24 Jul 2024 at 09:49, Arnd Bergmann wrote: > > I don't understand why this return '0' for unsigned types, > shouldn't this be > > ((is_unsigned_type(typeof(x)) ? 1 : __if_constexpr(x, (x) + 0, -1)) >= 0) Yes, that looks more logical. Plus why do that "__if_constexpr(x, (x) + 0, -1)) >= 0)" when it would appear to be more logical to move the comparison inside, ie __if_constexpr(x, (x) >= 0, 0) but I also don't see why that "+ 0" existed in the original. So there's presumably something I'm missing. I do get the feeling that the problem came from us being much too clever with out min/max macros, and now this series is doubling down instead of saying "it wasn't really worth it". Linus