From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540DCC433EF for ; Wed, 30 Mar 2022 23:04:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE0368D0001; Wed, 30 Mar 2022 19:04:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D68076B0073; Wed, 30 Mar 2022 19:04:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE23E8D0001; Wed, 30 Mar 2022 19:04:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A783C6B0072 for ; Wed, 30 Mar 2022 19:04:14 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 65184A5BC1 for ; Wed, 30 Mar 2022 23:04:14 +0000 (UTC) X-FDA: 79302582828.28.B6E746E Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf21.hostedemail.com (Postfix) with ESMTP id EA6501C000C for ; Wed, 30 Mar 2022 23:04:13 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id 17so29745620lji.1 for ; Wed, 30 Mar 2022 16:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tDgQSkHHiSrnRRl+XOyzOTrWuP6P/qs63lMjRlAlumA=; b=H1uwlNadJ0WrOQDMcYJNfFurl6GqhsMtNqCvCiCYzwfrOZQovLUQdtOf10pbURXgQf pxrchutAbzYICc6R04Z6AaQzwmxoEta0W1oCaJa3CR9lP9R/CL+2buSY9c8mRTTeCOOt wKflnsZZ5GulJmTlUyXpc+Ybm951svaYxRDHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tDgQSkHHiSrnRRl+XOyzOTrWuP6P/qs63lMjRlAlumA=; b=WO8i4cyxy6HOpSTn9Vh/JzZhZokR15trtTIl7O7GsMuWTyRYkpScnujoVbx7Tmz6gi g15YiLT6F3jAK1ppXm2pC1UEQlU3iXcnO9QjzdSjPM/yDSUlFCa3pzSHrp+KlUGpUHNS gGvwE4X5Fj9oQcEwEixua004Pe1KU1XfEzVaFPS6BD1/CtzjF2jbkbKkZcxQrK905dSX PX4daXNJTnjbWzo/TcwqAGpWt8mA9BlmKS6vVf7uzN8khPAoWN0WaN7B+B2TEoPH7usg 52enhrcK+qRwbhqf9GR2hLrcndO9/GD2hrQ2zJ+mA/QqesRq3xJvVuOru6LtaTjP2VSX sJZw== X-Gm-Message-State: AOAM533DBsOVA+LiNOnJ8c4FY2G4Kxbfdk7eKy09us4U4keOGzvKK1lc YHlpqXFQWTcd2DuZLtXJ28859woonJG3oV98 X-Google-Smtp-Source: ABdhPJx/J0t4KdzzAF0oaZgDuIDg/pyoJU05FmOV362YufvHhGUV7HcrLB1QF+AK023eXEeNCPoWHA== X-Received: by 2002:a05:651c:1046:b0:24a:edc2:d107 with SMTP id x6-20020a05651c104600b0024aedc2d107mr3231883ljm.285.1648681452010; Wed, 30 Mar 2022 16:04:12 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id p2-20020a056512328200b0044a2d3f889fsm2466376lfe.293.2022.03.30.16.04.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 16:04:10 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id e16so38349761lfc.13 for ; Wed, 30 Mar 2022 16:04:09 -0700 (PDT) X-Received: by 2002:a05:6512:3055:b0:44a:3914:6603 with SMTP id b21-20020a056512305500b0044a39146603mr8634944lfb.435.1648681449455; Wed, 30 Mar 2022 16:04:09 -0700 (PDT) MIME-Version: 1.0 References: <20220330221238.396357-1-zi.yan@sent.com> In-Reply-To: <20220330221238.396357-1-zi.yan@sent.com> From: Linus Torvalds Date: Wed, 30 Mar 2022 16:03:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: page_alloc: validate buddy before check its migratetype. To: Zi Yan Cc: Steven Rostedt , David Hildenbrand , Vlastimil Babka , Mel Gorman , Mike Rapoport , Oscar Salvador , Andrew Morton , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ds5g5oaa134uibsrkzz7qd8q176aeneq Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=H1uwlNad; spf=pass (imf21.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EA6501C000C X-HE-Tag: 1648681453-976813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 30, 2022 at 3:12 PM Zi Yan wrote: > > Fixes: 1dd214b8f21c ("mm: page_alloc: avoid merging non-fallbackable pageblocks with others") Oh, btw - should this perhaps be backported further back than that alleged "fixes" commit? It does look like maybe the problem potentially existed before too, and was just much harder to trigger. That said, google doesn't find any other reports that look like Steven's oops, so maybe it really never happened and backporting isn't called for. Or possibly my google-fu is just bad. Linus