From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 690A1C3DA49 for ; Fri, 26 Jul 2024 21:38:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6BB46B0089; Fri, 26 Jul 2024 17:38:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1C966B0092; Fri, 26 Jul 2024 17:38:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE3E96B0096; Fri, 26 Jul 2024 17:38:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A03816B0089 for ; Fri, 26 Jul 2024 17:38:53 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 532AF40142 for ; Fri, 26 Jul 2024 21:38:53 +0000 (UTC) X-FDA: 82383218946.19.E3003F7 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf11.hostedemail.com (Postfix) with ESMTP id 0785140007 for ; Fri, 26 Jul 2024 21:38:50 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=T15A6k9J; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722029880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bkedeLk8fhK9O3PQ3pqqo7U7kJaAE7vHl3F7D3P/h4E=; b=7udOpsCet4scLZ99LtBk1byRnoxxg8n6EMJqV0t86y/VrxHXhk7sWIyCk/w5FEO25kGDjJ ZhrywaCO7+cpBd8dOsLwU0ClWvDgNRGh0pbQabJl24HHEj4ORd+ZVCcHDbmDzEuZmVDALn vhAk6RHNH/ASg9AeMc6LF/0Hkv3zpoQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722029880; a=rsa-sha256; cv=none; b=4DdH7O2WiohDsG2yW2h80pqciWTSixJiLgOPSUR9mH7+Fu8Ddn/3gyxi0+lhXJjESRQAqn l+iWC7cgFGeIM6cHAN9ikIEjbfBSi15nSRUKHWo0fxv5qWY5P31ION04ZMaU1XvJL0/XtJ T+ZJpWylNrRWI6CD5cs1CxD4Jr21Mbc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=T15A6k9J; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a77ec5d3b0dso235762266b.0 for ; Fri, 26 Jul 2024 14:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722029929; x=1722634729; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bkedeLk8fhK9O3PQ3pqqo7U7kJaAE7vHl3F7D3P/h4E=; b=T15A6k9JE9ih1biG8fkjtQGgi+apqKDEefuF1s+TjzqrZvNVlOg1hFbAjxqvYOpaDC rVocBiJeYbISoZK1BxM9bISih5ZUyMOFxtAkNv60zfjMnGHZBtqnPjzMXI4JUGR4AGLA JdimPMrnnZp4qkSQaFhyiyw6M8mU9BNqOuGLc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722029929; x=1722634729; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bkedeLk8fhK9O3PQ3pqqo7U7kJaAE7vHl3F7D3P/h4E=; b=CZTLOPWIXJ4/lfXF68v0YLLgwt9MbKbVACWL5jeGMPtulIU3BmNwhbs/Vq4G2ISW9U SwadDeBvRsNNW/uNKMbO3zhvW8E3gnxMGrS7xz8UX4kBUVKSJ6YcSfgyYg232btTDN36 Ukc4sbqKTPoCWMohfSJG5osz0GvHIEFhLEdwkV1hPE4Qq3Mx1Fa458xC9tbJ/GJLNfpD J2n54XNx0r9BANIj2ps5bfs+9L6MQoOc7loRLEyEtyloxYLOjY+vPpLIokZWhoT+Olat MPE7DOxBB4voZIm3dYEmdSmvwtUU07jj0WDNriGdZDYN4SI8faxI5lnVpNYH0lTR1q0Q XmpQ== X-Forwarded-Encrypted: i=1; AJvYcCW1EE9OYzmxHVvT3m+rfK9Xjh2GqSrVtAs53/qyPglwipkGkq/xTv7ugxIO2uy9csbKmjVnXepveW6shPQ9tDdYmck= X-Gm-Message-State: AOJu0Yzjr20V94QWH7FBu18s+YlNsvzp5jG9wgzdFXTQJ6yfSJDGupaa YtIly0cGp73OWI7FtWFCfFtFLvuqtZkSjJErmVS2ns1/EJ4CXDwXoKMW36FozuOhnxdvCJep0/b 6jzQe2w== X-Google-Smtp-Source: AGHT+IEWA8gHEiNgHqTuxs2nhxRwVnJpYp+LUTybGAT9+HAP2V/e5gpzt757K03J1+2VPIe8252/MQ== X-Received: by 2002:a17:907:9689:b0:a7a:c083:8578 with SMTP id a640c23a62f3a-a7d40135eabmr51708466b.52.1722029929456; Fri, 26 Jul 2024 14:38:49 -0700 (PDT) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com. [209.85.208.43]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acadb9dd3sm218347366b.220.2024.07.26.14.38.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 14:38:48 -0700 (PDT) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5a156556fb4so3371154a12.3 for ; Fri, 26 Jul 2024 14:38:48 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVhRuAakShwbHdwjPj8m+06KTPXqizGN5dwLoeeYv3WGN8AtJQ42FxxcY342IucdlDteO0pK+2np/GrT/GDmIjkxvQ= X-Received: by 2002:a50:8d14:0:b0:5a7:48de:deb7 with SMTP id 4fb4d7f45d1cf-5b0208c46edmr385441a12.14.1722029927975; Fri, 26 Jul 2024 14:38:47 -0700 (PDT) MIME-Version: 1.0 References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> <20e5a0db0ebf4bbb991b13a1d8951137@AcuMS.aculab.com> In-Reply-To: <20e5a0db0ebf4bbb991b13a1d8951137@AcuMS.aculab.com> From: Linus Torvalds Date: Fri, 26 Jul 2024 14:38:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/7] minmax: reduce compilation time To: David Laight Cc: Lorenzo Stoakes , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: kfwa7rskceamwb75sgxwrrsnie8xu15w X-Rspamd-Queue-Id: 0785140007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722029930-765114 X-HE-Meta: U2FsdGVkX18lmIBPP90bw3oUoqjnL7s4pMcLA/6uB80Q91L11oUxtcG025RcVCvRkDs+OF1d0v4UHcJsR9WhsuUVOlJiy3+SXhM2u6wyNmEQDClqvAZQYRd4mviQKorQdXdwwEJqL9U3fF+NfkDoxNtwqMFamM1lODMXgmacDD2jEkGkIxKgZI9FuKeOROe3ZfhS+Cp8p0nCbheHxh1gaCPI2nuzcyznY5+Vq6HW5hu2vcYr794KIM+PNTskSDXwS/pmhj0J9dk0tUFBOKiNRsx0OOZ8A1bJ+AxOFgnyUrRTwsXJTYYD1MtWD7oQBZZyNwfHetsp+mouSA/qYgTYlPK1m/NmGU+EisNpzcnDLCHtMTrsz+6QkyoMQUEHnFmdOYLcreepLUbV2t3u6x0r10J77QX0UH//VHefYBj4EjoKByYK0qr4Ov/bC+O35fqSxoM49IJy5TH7zKHxv2KGzrP11VQ/sZOvqVb9gaJJqIoVfCdV0+pKFTbmkBlfCKMTmwuz8jPfT6SMuF45tSlB1M3nBw3tMFuSTRd8GWrpITt8ctpDH9F870lmSU7w2zUojsULtYWfKqwIJrdqbWIOiKHTeF8RBO4ES8OXfmDVQmdROi2aGF3gEBUgJrSNyBUk2Ef8xoVUKKP1x+wAZ4rtOwQjnzJ2+m4IFItgnxWyQFZ9TJmNRy36NxpxRE6ldp5RVqdstWbePszfEAhubeHzLhpzZmnrFJ7ppK2rd/LrJ9gG/gc3+OaNxXhjnsC6TWu9diwW9nKGCX0nEXaGB3f56uxnmSNibiorUme1/hpGvGUNKqtqT7GTvzYL4ckQRYFSDyKeaPSb6uOSl994EzG9EE4rRgleyh6kGJNM1bvr9zptcaWg7t9+WqldZVUm8OYgzUbUwoKnJyaj4SKw0VrWJWKolcU/Qac2vKgrRzwOF3Gi1ZNB1WBOQHFVEc11hlNC9UEKHitWIfUVOjsx/Ry zSNzKsfQ mg6Y/pDCT2CVsQI1pDf9vKbdEJ1W4WcYtfgNnjEl+Zf67UqIFk0FvfVU1At3GYOkQPQXuKDcHQ/PNoN4KcfED3hzWx7F1K7EA7tTjk8jNdduktk+Y0TV1pAcn8U5/3rd7pZIIkObDXSowfrKMu9MVm10syOVSXOS9GzXQFxQKPB3EwS2gq3PNdFPEQJGbKxpwUaSmx+WR24BR9MZqCpJuiL90mklZv6a2rJM6wcYvA+44kI9bK2zBZSojOyZ8PZaU3qlA6dKd38zXIbT8Ei+QlsTV+18VEbuqO/okU3rAzBkOYdZWCAv3Atj0AbUShVKA2xcZScTW3CaU3ZnY8baVb3ByVqJeRecC59m5qRbXiXBu6rvj1I2/ayRx9ZN7nB/XID9oRQnKFBsSBaBd/TTXeATV+Ji9Ff5Y8T1H1AZZMkEutIcQf75q3NZ0quoMhx8R/4AH+5uGKVKjpkX3lWobBMQAmbOdaBASju6SoyOwYqfMJ7A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 26 Jul 2024 at 14:33, David Laight wrote: > > I suspect just reordering to: > extra_pages = min3(extra_pages, max_pages - max_pfn, > EXTRA_MEM_RATIO * min(max_pfn, PFN_DOWN(MAXMEM))); > will have a similar effect. That's disgusting. No, we're not adding random "the ordering of min3() matters subtly for expansion size" crap. We're simplifying the sub-expressions, and fixing the problem that way. Linus