From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3344C27C53 for ; Wed, 19 Jun 2024 19:31:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3A5B8D008A; Wed, 19 Jun 2024 15:31:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEA598D0084; Wed, 19 Jun 2024 15:31:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8B2F8D008A; Wed, 19 Jun 2024 15:31:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A84AD8D0084 for ; Wed, 19 Jun 2024 15:31:05 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 28E261414FC for ; Wed, 19 Jun 2024 19:31:05 +0000 (UTC) X-FDA: 82248631290.18.F1B6BBA Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf25.hostedemail.com (Postfix) with ESMTP id B7487A000D for ; Wed, 19 Jun 2024 19:31:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=BDmS5U3Z; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718825459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+wN5dEx96D+70+iPxSD0VoqGzqbVt1ZsfN7BnJKyZXQ=; b=cWDnCP1BGzhhgn0Tf8w4a4akwhORPZgz/Tby3LyMcldg4CB2wwMFYIQ0MOegn25G8Fvz0j BUf9tFAR0n3uI6eKoIJ37B68gEgZ1GgbcBhvBPmkdsguLFVb5JurTYIWmjEy6ZQ20GIkFV ROS25SWOzK7P0fg8wSrHvbtAJbLM2lw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=BDmS5U3Z; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718825459; a=rsa-sha256; cv=none; b=58U8Fm37jawlAt6DZ09GndpHg5tRjSy1h0FSuXInIXSxxrqIkkEOMEO3x4W4Zy5GQtHIwp ZEaTV8IWUqsI9kXwDMF7oAEr0wV7PYc6+EKTCQgKzcnOFiZd922kPbilzas6w5cjjydY1t 9wEfxhFZN0ZEDKKspFa0+xszaG7zFjo= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a6f9fe791f8so29648566b.0 for ; Wed, 19 Jun 2024 12:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1718825461; x=1719430261; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+wN5dEx96D+70+iPxSD0VoqGzqbVt1ZsfN7BnJKyZXQ=; b=BDmS5U3ZeKmpLz9B4tmYiRIsq0zX0Wx4qd3atmcr7cPZsIMrpVlDJ6uXgQF+PyBMtz Kp6daEvvi9ovF4lw0wIawxzkg4ijsTdOsyH8SaLnuEkpYfnwHgVDCB7QZ1JX1vpqnjoM e+OmBm3lGfTZhGBbFk/fY5bYBGD5lBYb+wMCE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718825461; x=1719430261; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+wN5dEx96D+70+iPxSD0VoqGzqbVt1ZsfN7BnJKyZXQ=; b=xQ58Sqe5DaCUKD0QrsnyOaZ7kY6A1dWHgSUfb6U8/9sGzrfH6q/08U9MPPkM7FDbN/ P8Ub5XsAh+dIwWWS8Nx/nTF/5qHnkM+DYqMoKec7Fmr9hRMMetIdiyy7ng5o2q1+kcZn gYaJmtPtGz4C1u6ezsLr6mxlPXmC9QjjnDBT3sdwTmVy8eOo93wgNnb0ssyV/Lrw3yrB QDBa/G1IHD+xyGYHEjihmloTS3ftS7aCtzotL//L5hwgB0t+iBhlOKffllndgJyc1+4V wzKCokQndcTmJ/NzurAbuMo7YG/y1+csszk4SIFDCv/VI4H+Bw0mHOjEFOm2spinhxoN 3Jsg== X-Forwarded-Encrypted: i=1; AJvYcCXxUibu4+1TyGrMEmFH17HrQbQ86QbDf4NaC6rlZMDNSE3/CUACTSytiVNIThzzgt6diMa8+oSGBFvCrCBJf6z4Dcg= X-Gm-Message-State: AOJu0YzdxGE6Sdp2HJIkn+SjQUYQ5gsGWyuOkxxN5z/6v5Q5/htOgqBt 0W4UI1rn2OoVZgL7v/+onjxiAImWdIfICgI8zZreVUzu+ceETz25oIZPb2HAz+ksogk40Kwx9SQ v46XGdw== X-Google-Smtp-Source: AGHT+IHqM6mkktu8KkEpJDBsyp9K+WudZW9k1ZxidsEKYmPPZ0beljomCK+5q/pdYnwItM7Zdbe8bQ== X-Received: by 2002:a17:906:a847:b0:a6f:46f1:5434 with SMTP id a640c23a62f3a-a6f94c047famr403328466b.6.1718825460427; Wed, 19 Jun 2024 12:31:00 -0700 (PDT) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com. [209.85.218.49]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cbb05b465sm8152761a12.18.2024.06.19.12.30.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 12:30:59 -0700 (PDT) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a6f9fe791f8so29640466b.0 for ; Wed, 19 Jun 2024 12:30:59 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUVFenmk8h5r4mG/zgpayBMZokDlbCR/lcxnQ8zDgAFPS9OLyhN1i+R6JzxvTZIasSz50FszdcPlePgtkdkfUX9hkc= X-Received: by 2002:a17:906:bf45:b0:a6f:77bb:1703 with SMTP id a640c23a62f3a-a6fa4109c43mr237633366b.13.1718825459486; Wed, 19 Jun 2024 12:30:59 -0700 (PDT) MIME-Version: 1.0 References: <20240618213421.282381-1-shakeel.butt@linux.dev> <20240619174751.7r2s7iojxbaxpqlw@linux.dev> In-Reply-To: <20240619174751.7r2s7iojxbaxpqlw@linux.dev> From: Linus Torvalds Date: Wed, 19 Jun 2024 12:30:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: ratelimit oversized kvmalloc warnings instead of once To: Shakeel Butt Cc: Michal Hocko , Andrew Morton , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kyle McMartin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: B7487A000D X-Stat-Signature: m6b14u9xynnskg7qusyfppw88sscnq9q X-HE-Tag: 1718825462-574735 X-HE-Meta: U2FsdGVkX1+wFWvsQB9G3wG4TDnL3rHGr2w8jz7/S8PMUINuvVeLenfZ1rDIWy6v4xHj9QZvbxrosfRmJAGxtib2aShK53hifgc5sSsBLUdv13tJ4S4CfngyIhqSNXvqD+cReBjLIkCZ8SzQDC5wNG8Xi+wkJ7I6rG/b4vAQBBlxIOBB5t2pwt7LEIn/HpwMBlHLm4BslN0qQkUgz9sGObFev6ycwumm/kktE5Mev65uehaBaftKk55EmbyEmFuPhF3sg4IwVoCc3atguvWLz7GXVUj62JI4zZzaUy+ftTuWRXP0/0gK1tL2CTTVIAhKOqCKaO4Zd3Iff0FM45FfqEAxp1y9cpmjJIb8qM/mibdx2+UzbrSFi9ut3Wnz2NNBl7R8nLu8s8R1LU6Un/hI6za+ACk1udKzqMK31MWwB1Vi3h+E6twXgq1VSlTMOm/lDdHXbS1GLkcSR8FRrLGTU5KRAJjjV1ylCFBY6IYQ8oY4l2hLU/OnMxK5neWLdqmX1EKfKaC6FyXhgv7RXKassUNLdFnfIaTT+btGSrGXiUvN0V1rGw40USvAhlj9bk6N6hZTxjDTujiocQjup8CHM5rOQQoaq91bKNojHCyFLiTlofUTzZy9MPfGzb3rdyb2Rs9tCqstVjwZA+shQLzGDr6cgRkYgdpO9G23OzQxKazCmXXXDmr8ywVUmKrKboRuSOUeuuXQpsk6pzjzQ0MgAoMb3EFEsXr964NPW6WZ0gZXxWoXB5GfIh16fI5nV+/mcfGptmaCdeUdmpSWn4sF0eg7q1Sn4Xe1lC3c/gktm5bqbLWRDlydQ+/O/ZJ8gwmS0fGrYyC2oMJsJdTS1HMbIHvUswCU5x+3nbTZnxdf0X4m0vz8VNCLjspim0gU4znForcaDKo9Btfr5u9ACppDmeIJtJ4GDKNFxY4Yuccfdw39+HnwuIigZYa+qfzT1oigZWIR4Eek3uGAvxvODUB xWUbzgnH znwXpK4no5VIzm2dQCW9MGmeW4aNlHThUujWsfPfVvVar/ZX+K7UPUllLb5925AFj4dIEezXodn/cUgnbPYg9F0MD/wmPNq55o63fIRlED4UYSvWrGqM4DXSNAS0fdwNbpHCko5Wuz9m3jWCH05dY5baLPn5ioptxzpCmdH4HX6DsItfpyy2cr2cJOAzwJsrT+7ro4qBcfWquimzjwRjiHG8oVWJ8md6/mLkFlPW2RhEO1fG7Edi4jojWCLUMESSGT0KOTMqaI/AvvdVKJDwCO+M6pFEb6FoWEUX+KlqpCw9AzjyMOZ4xB2pxkFgyJIXcmnnHZ7n7x/4/tErm7G4CTSQbMCcZ00VomO73PkF4/ktSIfNrwGL+49d32BAbBzKUJjm0Yv/N1r4ohxzHbhqc9ZT5U7mmWMWRsB5XVoL1Bx4+rzvn/lpkr1iV5QI6Ax7MmrxNBaBB0XgGGvxWqOrvB5uGJrlgvFkmBxLZOq6+X+8v3hs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 19 Jun 2024 at 10:47, Shakeel Butt wrote: > > Linus, please let me know if you have any concerns on the approach > Michal is suggesting i.e. a variant for warn once for unique call stack. I think we should just try to change the existing WARN_ONCE(), and see if it causes any issues. A new "WARN_UNIQUE()" might be the borign and safe approach, but (a) it won't actually be unique if you don't have stackdepot anyway, and will just be WARN_ONCE (b) I suspect most WARN_ONCE users really do want WARN_UNIQUE so let's at least _start_ with just changing semantics of the existing "once", and then if it causes problems we'll have to revisit this. I doubt it will cause problems, Linus