From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB3AEC433F5 for ; Thu, 6 Oct 2022 18:20:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B50F6B0072; Thu, 6 Oct 2022 14:20:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 364C98E0002; Thu, 6 Oct 2022 14:20:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 205DC8E0001; Thu, 6 Oct 2022 14:20:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0F92F6B0072 for ; Thu, 6 Oct 2022 14:20:38 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CE7EC41194 for ; Thu, 6 Oct 2022 18:20:37 +0000 (UTC) X-FDA: 79991340114.27.DD48A8B Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by imf26.hostedemail.com (Postfix) with ESMTP id 72F00140018 for ; Thu, 6 Oct 2022 18:20:36 +0000 (UTC) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1321a1e94b3so3161450fac.1 for ; Thu, 06 Oct 2022 11:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kvZZAbpP6BsRmYO8eDv4ALVmewEv2pB5Qkzc/cExC/c=; b=LrEjH2cWkq3csQCkPUASQkN9+IfYjOMJvwTATtoZz1Pey9Bh1q2Wem5Yxdo77vW1s3 KNzlvLsPIYCLT9GWyJU6iZLu0fjuqCLSWONMRP65fryja4NUDXuaDcm4mILly16tcGC1 E2fSpojOg8qHrBYMXiJgtQDxAH+RE/TguFFxw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kvZZAbpP6BsRmYO8eDv4ALVmewEv2pB5Qkzc/cExC/c=; b=IDHryPfpOeA29UezuSD2GuYFlj0pxJXBDtjl9QqiZRRX8thIKajKdVUsxytyRfmxzX CVQAki5eHp2vuO0EyGSPsiB35C1CJkwbSrYtQJ2Ra2TByZLDs6vtLxJy3SPUtZ81jpqb u3voFCaYvfOnIHvasRfQR6IFFtSvus15oRGAh9ucAcho1ysz2Ru0GfgPSDisYU66APf6 +7oOOaJmRL0dp5c4H2B+M2GzeYeXLl0VeWTHs12ZFn6ebldFwhNmIitfft7vINLk8eax deqcH3bDgygi487TEo7YK/5qo1+OZ+iJJtLzggHouOVipJY3BAFJN1n+cK3/Dp0eB5ou sUJw== X-Gm-Message-State: ACrzQf1RQYC1eJlXXTktfU1tAs/UuQ8hc+MqRsrwWY5IPL6Dqw/r5XnB LBsJyIm8s4S3hJb5tc59gg1DWCLQNTvOfQ== X-Google-Smtp-Source: AMsMyM7tnFMwNtypgqEZlBdTjCSA3Ea/7qT90TVE1RIuS5FIYcDKpDrAgNKHl+m71ZRUoT0nAb80+g== X-Received: by 2002:a05:6870:5b9d:b0:12b:5871:22f4 with SMTP id em29-20020a0568705b9d00b0012b587122f4mr578240oab.211.1665080434957; Thu, 06 Oct 2022 11:20:34 -0700 (PDT) Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com. [209.85.161.51]) by smtp.gmail.com with ESMTPSA id s15-20020a4ac80f000000b0047f72b6988fsm2059069ooq.45.2022.10.06.11.20.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Oct 2022 11:20:33 -0700 (PDT) Received: by mail-oo1-f51.google.com with SMTP id h1-20020a4aa741000000b004756c611188so1980124oom.4 for ; Thu, 06 Oct 2022 11:20:33 -0700 (PDT) X-Received: by 2002:a05:6830:611:b0:65c:26ce:5dc with SMTP id w17-20020a056830061100b0065c26ce05dcmr531643oti.176.1665080433520; Thu, 06 Oct 2022 11:20:33 -0700 (PDT) MIME-Version: 1.0 References: <20221002002326.946620-1-ira.weiny@intel.com> <20221002002326.946620-3-ira.weiny@intel.com> In-Reply-To: From: Linus Torvalds Date: Thu, 6 Oct 2022 11:20:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/4] tee: Remove vmalloc page support To: Sumit Garg Cc: =?UTF-8?B?UGhpbCBDaGFuZyAo5by15LiW5YuzKQ==?= , "ira.weiny@intel.com" , Jens Wiklander , Andrew Morton , Al Viro , "Fabio M. De Francesco" , Christoph Hellwig , "op-tee@lists.trustedfirmware.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665080436; a=rsa-sha256; cv=none; b=WuUT8+puqs+fm7SP8ymdOFm3aS8PniMQTKY6+rudGMpw1TVWZlyfJ5B3Pavi4AfUIFpWGv jJSx16gTDmPnBl0pnwkVf7E3HteVpP5Gqh/MhPCLT0Cgv7t7fskIREBKYbD4nqbRIOhffs Bv7Z5N3to5vEZwgpHkvaDqg38NyU4x8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=LrEjH2cW; dmarc=none; spf=pass (imf26.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665080436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kvZZAbpP6BsRmYO8eDv4ALVmewEv2pB5Qkzc/cExC/c=; b=LXdHtbPTzGODUijmPwHYP9KH0+MXGmNAFJ3YIqvUTIr0exIAwyqicRgcSOSXnZEizCe2xR KK2KDxBs6EqpRqIx1kzEevA3QWt2W7IgQwG4+Ed0dZWyE1hblUBwKfxpRaAaZMdkeUD1LD lnjK8SDmJ/dY0Ak5DFx3itYDNWKdWvs= X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=LrEjH2cW; dmarc=none; spf=pass (imf26.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Stat-Signature: dt94xig8abxxt58wx771etunrxgruwmj X-Rspamd-Queue-Id: 72F00140018 X-Rspamd-Server: rspam09 X-HE-Tag: 1665080436-157328 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 5, 2022 at 11:24 PM Sumit Garg wrote: > > Sorry but you need to get your driver mainline in order to support > vmalloc interface. Actually, I think even then we shouldn't support vmalloc - and register_shm_helper() just needs to be changed to pass in an array of actual page pointers instead. At that point TEE_SHM_USER_MAPPED should also go away, because then it's the caller that should just do either the user space page pinning, or pass in the kernel page pointer. JensW, is there some reason that wouldn't work? Linus