From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62C54C28B20 for ; Sun, 30 Mar 2025 20:56:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8BF3280002; Sun, 30 Mar 2025 16:56:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D393C280001; Sun, 30 Mar 2025 16:56:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0447280002; Sun, 30 Mar 2025 16:56:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A07AD280001 for ; Sun, 30 Mar 2025 16:56:41 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 887EF161669 for ; Sun, 30 Mar 2025 20:56:41 +0000 (UTC) X-FDA: 83279426202.13.5956B08 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf01.hostedemail.com (Postfix) with ESMTP id 8D81B40002 for ; Sun, 30 Mar 2025 20:56:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=DZXcfEBT; dmarc=none; spf=pass (imf01.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743368199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BSOLpfQDj26hqGlCIT72Nb/pIYj7VgJoNsTI8j/3oiA=; b=kamxgVzCf6AxSYEJHNtd30h/yHcul7aCd1QKm2J0qXarA8nohPTdtEekKr5zRHIbTaUFvO FHe8D3ZF0CCaCUgBCBMyRUw0RhLwoZIthlt0Mg36eMEdzL81g1XP8O70eupbZSpAKcT7df +EBEb+2Tku8mF0wOuyETmdea8HQQJvk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=DZXcfEBT; dmarc=none; spf=pass (imf01.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743368199; a=rsa-sha256; cv=none; b=wmPYBYtQIM5UXuGqoG9Nzwu2TBtTYDsJu6YjQSEIQdInKS78nuiGQQ8Y3f/MpAYApqDOe7 Df4X+XXbTxH/9XBN5GWheN7E2u3VslxI75NbgLO7phWVL+fyW0FCBbtes9+xMcnuVUndJL wF7iNDwu85dPJgMXjnmiQTbn1Bfjbzs= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ac6e8cf9132so677029166b.2 for ; Sun, 30 Mar 2025 13:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1743368198; x=1743972998; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BSOLpfQDj26hqGlCIT72Nb/pIYj7VgJoNsTI8j/3oiA=; b=DZXcfEBT5BATKNtBzf07jcA3FczafoHG0TXDS54YpjMma4LmZpiKu6s/uKAH0BaRmx W1RTmvth3e/VUKCS0CHDOUDIpgJsaYY+x5MgrEAYGaxFpbcQ5z0ssMcRp95f9kj7v20e g4NVQlJDVDycaECxyoDTyyItj/xaHkDtnFbfE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743368198; x=1743972998; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BSOLpfQDj26hqGlCIT72Nb/pIYj7VgJoNsTI8j/3oiA=; b=qjfOKYz4zHN3Fu6gYom7O8WC3rGVOb87Xo7KTEJyD4tsjvQ3/zRkj2VyvWRiXMjEFo ZB+LzgN/EAXPutACydJfD/JEzj8YwsCHbwPWeUPuT0/0MSKg8aLEmVkgkQu6zEnOUHEz GRttnASJc4aviRaNG+Ye3k4OiuMh0sLnJBUo0Nb46OpVVfY9JUGLAIqUODH3jnqoaGWG yGC+nXLFj+KyWT/vSOLKOH2QTPlbqU+MRheJ94tKf7NObOv1blKd37jzA/eC5ILOwNRv uwkCaEXEbcrqHYev9CQOBWwGbirmt83ArJtzYPpDBMJnamZ9SmDqyo6LT1BH91clL2RY ot0w== X-Forwarded-Encrypted: i=1; AJvYcCUZws/hkEB8NuCt1qTBYQtPG8pjLxpXJ7eEk8yzMkIIcFVR6d+JndaKI7ksgm0x9VI2FokiP57suA==@kvack.org X-Gm-Message-State: AOJu0YxCM6KgWTNOGmAVzQSpV+QSA6jvEeHcdTo7ZH1RuJvXoDLP/vfX L1JLAOV24F+FQrQbCe6qQdRcbwcalsqAHSjXiPGp9GFmOlVl6ZG16Odi9/ppxQd1i3jJXKIkVIO ZdCQ= X-Gm-Gg: ASbGncubREvXuQLC/hHQltFSINKkG8X5GmM7lUmS1pOs8sn+gtcPUpc5PjcXkKZ68gj hfMRqN9Eb6lySOUUX91BpyAMB4KRX3NnM2T/o7n+u/SScRU2J6fsPLtIpSO69yBoSju5Axeg4dY ce/JCEnEC67h3GVuQT2mbkFi5Bq0PWQi9uFzhIAVVOmu2VquHKT4iFqNpCpcmqBjNqfZgXj+kGS ICDKK5HqA0nTSPgLbC6R+ymtJSMVHG9qo/RnvMVlYlWyG/bxEc2Kla6FaGNxPTmrdVU4Ily5uL6 //4HXBFb/k2DoBv8d3w8XSWwbG3q2FhGKwj8SzkTNI3plVokK/HamOFjMeMZ4wuwwglu3KCNcP0 9AwjsP1l70sNBCY8bKjE= X-Google-Smtp-Source: AGHT+IG+IYGXDavOZxkEtcqyfwexQgBXTG3ZKDMHAQ/pveOBRzp+3Y/rHzPgF/8fAbZu1yM6HIWzgQ== X-Received: by 2002:a17:907:d1a:b0:ac1:e07b:63ca with SMTP id a640c23a62f3a-ac738ae9232mr643289766b.22.1743368197636; Sun, 30 Mar 2025 13:56:37 -0700 (PDT) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com. [209.85.218.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7192ea08esm520559666b.80.2025.03.30.13.56.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Mar 2025 13:56:36 -0700 (PDT) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ac2a9a74d9cso727765566b.1 for ; Sun, 30 Mar 2025 13:56:35 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUNIQOJU1h7NTiz6J2oQxfI19T/XsMCnIDQV+errKcZbQRXjgLWbcWTwH1BlTRkUENNacUY0cheaQ==@kvack.org X-Received: by 2002:a17:907:7e82:b0:ac3:8896:416f with SMTP id a640c23a62f3a-ac738a64ef5mr780959366b.15.1743368195497; Sun, 30 Mar 2025 13:56:35 -0700 (PDT) MIME-Version: 1.0 References: <20250327145159.99799-1-alexei.starovoitov@gmail.com> In-Reply-To: From: Linus Torvalds Date: Sun, 30 Mar 2025 13:56:19 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AQ5f1JpJ7geT4BoReQk_MXUrgZ8jgWTwt7ona-UlzJd5cAmwkXVKsuAn2yvli_0 Message-ID: Subject: Re: [GIT PULL] Introduce try_alloc_pages for 6.15 To: Alexei Starovoitov Cc: bpf@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org, akpm@linux-foundation.org, peterz@infradead.org, vbabka@suse.cz, bigeasy@linutronix.de, rostedt@goodmis.org, mhocko@suse.com, shakeel.butt@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Stat-Signature: ekfujz97i5dqqfgxkewi4t5wfeuun4y3 X-Rspam-User: X-Rspamd-Queue-Id: 8D81B40002 X-HE-Tag: 1743368199-404803 X-HE-Meta: U2FsdGVkX1+jWVNaU6Ss0qVDxac4ZJybPFjUzTkfYLmjlj+ZXzUxb8cBLOepmz80G0HGyFZIaQKvnHnHgTo4BtqH+59++ABjYrszkup3891F0ze8LYNcVTg6gHlamjjGJ8L75Ss5K/oHcj2kfV9fzm64Wi/XGGbTEMDC+sr8tbf1IF1JtrnC9Ovx3qnUgHXe0+4sow+ovEQdaTrKbf3o4wQP8l+Vk2uSgQVJy5g2GsnDu9Rr6Cb5agfqzkOQIhLalAzkDXKIU8Uz2qEyt1XU5aAEQO6b9FR7y/XdnneVk73rNTccDSHYKzsjs4x6YywBkeuZbhfagqIaYN1LiYHywoThJpxQAIXJFqO7mLqICYTklp1eVY4/rNHYwyppQdOyXT6D/ZPqOuZz7RBrQhpTOb+gpwKS6aXQNzV+NKFgcOYmVVHh+nd875GWqnRrJ+xkCYre8kgQESM7Rim1FfYSsFB/4f3I3czmTKJHFWA5s9lRDae8bHc/U6sHMob6aNepvzYnxgHPiWVVIWELKdhVE0+eHxr+xVYzL7tRN38edLRDFlpucFuo2v0z1xX5bxvqF6Gi/OqoFulvNLKP51v0+pggXcxYwtJpO+5p6ZIhMhyrP4OeKphkzHMugVSNGeUoYE6W+IC4wO3+QmvF30xZiMVFwenEOenPWPZjCF6bm12DvC/a39H5Qp3WMHIv8l6TkLA5N1e+uLz0mqhMzTXBEer4haM1Tcul7vdy2fOCV/rRWi81Bpx3f2yJyFD6zLWxU4BSMT/kBkNO+wXE8GHRkvl0OYbwCysj/LLYTVb7QdJCsTZFLrU8tNRhuDtQ8jM/di+ypUNS6GrzjXcVdDRalnFGp9rKpHlDov2dbyV83+WY5ok3yl3XfIEFhN59qMbJDHhZd9mLQIpzB7dOWsTd2g+8NX51CjDD5pNejaS3yJDKBW0R4Jq/Aorx1TbixtweSz7e2z3O4ZZq3slqtQX K8WXe+nJ 84rm/VEF3R2GtfNcStOzJ/NZ8omYcjRnYQqgtP0pl1VQYJuYl0Phx3T1eaQLcrcyQkn0jKtPbdEp72K6z35vcZrJHz3PIzUHczt7UBr0fsBfk+VKlzQTn8aVgof904ExwRbWANpa5PD+Es5F3LsdG19Bo/l7P/qDAD/WSK34DsgCdjf6LYQUeL9oxKuRoR6xJ6mQySb537xff0c2h6nSoYwDOT9exHKnLmGJOOCWUf+b8/6DtTIH7eL3eEYIC84pLzdz+YHAzT0gCfd1ZNlXlRnSooTAgnIeRq4fq1LdjA/HICTQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.011338, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 30 Mar 2025 at 13:42, Linus Torvalds wrote: > > The one reaction I had is that when you basically change Oh, actually, two reactions now that I fixed up the merge build issue which forced me to look at the function naming. That 'localtry_lock_irqsave()' naming is horrendous. The "try" part in it makes me think it's a trylock. But no, the "localtry" just comes from the lock naming, and the trylock version is localtry_trylock_irqsave. That's horrible. I missed that on the first read-though, and I'm not unpulling it because the code generally makes sense. But I do think that the lock name needs fixing. "localtry_lock_t" is not a good name, and spreading that odd "localtry" into the actual (non-try) locking functions makes the naming actively insane. If the *only* operation you could do on the lock was "trylock", then "localtry" would be fine. Then the lock literally is a "only try" thing. But as it is, the naming now ends up actively broken. Honestly, the lock name should probably reflect the fact that it can be used from any context (with a "trylock"), not about the trylock part itself. So maybe "nmisafe_local_lock_t" or something in that vein? Please fix this up, There aren't *that* many users of "localtry_xyzzy", let's get this fixed before there are more of them. Linus