From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E3ECEE343 for ; Wed, 9 Oct 2024 19:49:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D50246B00BA; Wed, 9 Oct 2024 15:49:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFFB56B00BC; Wed, 9 Oct 2024 15:49:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC7C46B00BE; Wed, 9 Oct 2024 15:49:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9D6A96B00BA for ; Wed, 9 Oct 2024 15:49:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6E8D1A1A93 for ; Wed, 9 Oct 2024 19:49:41 +0000 (UTC) X-FDA: 82655103972.16.D47D972 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf07.hostedemail.com (Postfix) with ESMTP id 298814000D for ; Wed, 9 Oct 2024 19:49:43 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=F9hNvgbG; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728503233; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r/L06Ja6eCp8GbRUC/+PsWSnm/5SpwuznlchqKiwSEc=; b=CqH7qZW7XTEs0kC4cPIWrp67/u6pVN3X0nGsWKt1lb0MSPe7QICJ/aXtXiGm/rV7R4a0Oh yDKSh9TKIL+j37RPkHXvQHMqpadOf25r86/BS+FTqVrrKWpxa1s6DqhIR/KFUP8LPYfc9P 5YKGku+o/J+B3+aq7PKDQ/S5s8L4fRQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728503234; a=rsa-sha256; cv=none; b=fZ9/0qD/Lo/CG83k72QS+Ok1pILhHibF1+ED5lNQd/c62VRB/w8oPCarxmLcAOuRtuCKec Cu/ksJVCu5VxPPPzJAzgbKSnGy2oGTcdgjJUo7dZUHQwX75hPSJpwpFYZ3Y5dJiC4DHhzL 8AE21xCZn+6EoRGjXP2u3c7TrIpEUWY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=F9hNvgbG; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a9951fba3b4so29779066b.1 for ; Wed, 09 Oct 2024 12:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1728503382; x=1729108182; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=r/L06Ja6eCp8GbRUC/+PsWSnm/5SpwuznlchqKiwSEc=; b=F9hNvgbGkJyv8q+xTMT+h5Ld5fOyA4anzE5VWrJjHDJsnlF9IP5X4L7dzUdaLOJ49P CMqTUvACgi20kJGlSeNmm78Z6J5bXgJNljl/oqz1FMJOrPizIIuZdRyDPceO9yRghWTr 8IywwB9zbObKnw0SjN97Het3J19C12Mde5g8I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728503382; x=1729108182; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r/L06Ja6eCp8GbRUC/+PsWSnm/5SpwuznlchqKiwSEc=; b=uFii7dRKZY+R1IJKmI1GAxh4VQPVatjhlKOcFtVONy0cjbUXRG4mMniF7cUAxpiybW W5ejm3144nE63FU6nxTX/5KT9oE2iIFyUsHcNIB6/oZlTdCt7r6kaXMHB6Nq/weKh/c/ EfP9vaQ1K8YgKhYrFNIQrtOhChJYX5LZEAD4uUrZbIeHh5fGXiQRGRyHQedyaTDjvTg2 hJR1SOe34Pignv8AUnHKKB7KIdJrlf4YTJu0kHyMYJpriwFTvCtqZ6TRVycboInbR4pJ fQRIXpr+hXlDJy6te561mPoUS7mJBgpxgqEPkH/PUgBPsUbQWuC3Nj2pRa7tddSOCJWV /vkQ== X-Forwarded-Encrypted: i=1; AJvYcCXwprjVIasF0bIhdSOQ/eX3GVuBFLEksDgf5He8Rc/XuPjLkNW43UFNrhp0mh5yRfZw2Tsv9ey4oQ==@kvack.org X-Gm-Message-State: AOJu0YzuRBt/Vf32TZ8eHYDsyM4AwCKMftBs6RdwU9WjlHfhGpI/BeFc 7KMQ6i6GoUy5E8yXuNVmmdGYRX8b520xCzmKbje30cGlb+7dRY1tytymH+Z+uROkfU0PxHQKB9y ByqsGuw== X-Google-Smtp-Source: AGHT+IHkD24359iFNv8IeTz4t/TeeCVKAt2JwhKU0qKFT8gSucQ+NZrMPk+ptbtbbS+bsgjML8spDA== X-Received: by 2002:a17:907:f1a8:b0:a99:53cf:26bc with SMTP id a640c23a62f3a-a998d313ce2mr334294466b.44.1728503382165; Wed, 09 Oct 2024 12:49:42 -0700 (PDT) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com. [209.85.218.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9957d955f8sm437625866b.74.2024.10.09.12.49.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Oct 2024 12:49:41 -0700 (PDT) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a99388e3009so21096366b.3 for ; Wed, 09 Oct 2024 12:49:41 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCW6C+CdbRbfue9Ca/naQKrh3aFhK4RYtmnKJV9h+qVcEc18gLdynC4CpJ1+KglUYwACJzSyr4BBpg==@kvack.org X-Received: by 2002:a17:907:9493:b0:a86:7ba9:b061 with SMTP id a640c23a62f3a-a998d34d21dmr306848466b.64.1728503380729; Wed, 09 Oct 2024 12:49:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Wed, 9 Oct 2024 12:49:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] misc: sgi-gru: Don't disable preemption in GRU driver To: Dimitri Sivanich Cc: Arnd Bergmann , Greg Kroah-Hartman , Dan Carpenter , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 298814000D X-Stat-Signature: p88355kjtfd3qg3eb7uhqcrwwgftzkd8 X-Rspam-User: X-HE-Tag: 1728503383-823969 X-HE-Meta: U2FsdGVkX1/PPyFhwm0eEBMDb0lDzjOwaf4OSC9PaUGkIYIKzV/1hP9wqUoEugbKYJPJ/Aed0zGrl2FYoiXujF2pHVtARlh9oE+IFyCjN2k22vAAnJ+MU/vuUVLwyWB4BnnUpx0T8aGmrgzjVYqQpM1v3ybOQhkh1AaZZ0Dp3FMfsEy/xpfhzboE88N24bR+UIaNVwP3A63a0NIvZeWkDwz2CtHGSHQatsXgWzfhmirouRcWQxT+JNyFDUCC+CDkKi2lIwbTV/ymO/OXOb5QY+C1W9Y13kamzrFzidHL5zV9zcBIzb+Ybatbma0USxBA/tN6WorFoM/NR2drFYY/1sW1MmXKVgL85i0noVkVY1tFYo842BOaGcdpTEqdz7Vz0tDUzGTE9GK7L4CEb/ffUhqNhbXx/v3wBlSwSgfzB9Dnbw9NC1mGe3lL0kcZFAXcObsgztxgsxFuAABHicCzwWFXQ9iffa5mwA5mt6YyDiUus7Y+H9w66iKuKV9cC2gicTIKBMsOB7Ukp0QwCmN5yXAPVwivmbV8Nf6taZAFPo1As/ggJ07EdLeRveQ0j1tCJIpx0L201H4wMBOZ8iz/SaPiVgdM24eMThZ/87Y7Mhp4x7QH3IAhDQGGeW3QDRfyzxz3aAqL/YQAXXxS3SwOwqDhuTTG+T3O6E4G9Oid0Yd4+L1rAsB2z6mA3cCHMsE5oPIZwYckPJihHri+iTitDi9sqojdKjFfAuk50lcRsB2/o/aH3T6piLrHs1IYmbc5SXjm8bcn8+qo1b6p9e+wUe/RYq5xbI+x0toxf/H+v2UGHjI2A2MSOAtgE05vu1V9DQOlJ1qkkDPInkETAMLdRk8fIH0lth91qPN/wby1X1X9/U9ic6/+u/tfUkdtN4i7jF7d4gzWTEgvENwIOX7w0qwUf++8xEaY2KBGAaXj68Q+Dct29nyytvJXLuXMuozK3s+yXwXlw3JOa0Y0ZRG 49g5fJVV gtOhL8eYvCVmcW5xhgWCuMx4ppIgxVaqM+fLIhk/PsbKCvKRPP9XSL774OBPGYmvayJ9YfGJtDbKmtUdD24KD74TRgxwaC8DN1RxQLEBDFnj4Ju+NgaSEzoVVpMYLzcokF6X1Ttn1VNEfCA1SR6/4ntEwTIET1pva1J+tLkwz6lYPVWSXPOsKjCxR641JKpYGQxr3ZFnbAmt7LFDSloMYMrlImRpFkJ71gZEYXyLCwB/FkSybU90wDfghyGONVTAeHd/vLH4PUQuOJkOBSXRKkY2MId7DhwtjswQCAvymwKE7Oj2XdZYdxiDT/5XSF5dLhqcWXzUDX/dEGDjeVWk2HguphI2Mh+RH2YHOVCSPOEVgU23S7zrGQvH2q3Q4eJUmFuDvdkBjm0yYcby/Hb0OTqU11Rv75QEWVI+wn6mvHNonPtMmVcpgxc2dag1EtThqRi3FoYwXrKNZIGS7kzjoUV+ANu1QWuv13ht/EPo1C943PS6poJGSGIKvSjla38b0eYor5vYpmUPAARZIycvxKAW/ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 19 Sept 2024 at 06:16, Dimitri Sivanich wrote: > > Disabling preemption in the GRU driver is unnecessary, and clashes with > sleeping locks in several code paths. Remove preempt_disable and > preempt_enable from the GRU driver. I've applied this directly, since it didn't come in through any of the normal channels, and I don't see it pending anywhere in linux-next either. I doubt it matters much in practice, but at least it should make smatch happier about this driver, and clearly the preemption disabling was always wrong. Linus