From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2D79C433EF for ; Thu, 24 Feb 2022 17:37:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 308AA8D0002; Thu, 24 Feb 2022 12:37:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B7AC8D0001; Thu, 24 Feb 2022 12:37:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A7FC8D0002; Thu, 24 Feb 2022 12:37:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id 0D11A8D0001 for ; Thu, 24 Feb 2022 12:37:38 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3B15797313 for ; Thu, 24 Feb 2022 17:37:36 +0000 (UTC) X-FDA: 79178380512.24.EA5D6B8 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf07.hostedemail.com (Postfix) with ESMTP id 8B8D240010 for ; Thu, 24 Feb 2022 17:37:35 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id r20so3986363ljj.1 for ; Thu, 24 Feb 2022 09:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s6RSUvrfQyVDu1K4DQ7l1PJWccys/B56pfoP2UXlTjM=; b=CMiJRr3TZReunnWs7oexaEgQRHI+PZN2gbfEQ7stEIebHxwsxa2vItFFPHfDG8XqfE 4y29FK3bqoQAkbrH5qXUm+UtofHgO2s+n0WQ2uTHbmyI4nW03QAd25PsvnIBzyHNNleO hpu+HCU7qnlyXL5HWf1fvT86HG2hr4T+bGsSI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s6RSUvrfQyVDu1K4DQ7l1PJWccys/B56pfoP2UXlTjM=; b=3wdBbK9z95183hbpPG7IXnmortSgWATVCzFg3J0KCCKyNiycOgwShE1owrHeMRe7rS 5Va8qib5o6/iCwc7ZVHgxdinAP5uscVO6Ferq5hLelrMW1OfN+QouLkYPIkJujjv/7pA +FtByljIQFN175FSZf8xGv2aJHXC9VP0lxEYjm6Bgc+B9yTsenwvwYTr3/Xd4GWAzNkd 7i+ssWlcvgVj8pzmeD6BJ1xRS80smToU0UfbnQx1FEkWJffC+t/9MTADLxPMFvEm8JVU xOLzvrGh5enet56/as8p0pjt7FqEqJhvsxzytbQMFGjx3tI99gDlIoZ1oPQibOLgOIFm 0/3Q== X-Gm-Message-State: AOAM530kFkqS+KZXWgwwNuqkkGS3nRemjzvKvr6TbBt+XknBb98Se6Lp aCHxGzu/aHH53nuSAVCfhjj5C+ThkaYlTwhBeLM= X-Google-Smtp-Source: ABdhPJyi4jl6xCqzXoN3SYseSBNjiUVh+bVKuy8Nod7bag7HEtV7lK8/6SRvqoWzWqk1EZAo7gQ2zA== X-Received: by 2002:a2e:8681:0:b0:246:3f2f:20d with SMTP id l1-20020a2e8681000000b002463f2f020dmr2663614lji.321.1645724253694; Thu, 24 Feb 2022 09:37:33 -0800 (PST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id w6sm256092lfd.300.2022.02.24.09.37.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 09:37:33 -0800 (PST) Received: by mail-lf1-f44.google.com with SMTP id f37so5116287lfv.8 for ; Thu, 24 Feb 2022 09:37:33 -0800 (PST) X-Received: by 2002:a2e:aaa2:0:b0:244:bf42:3e6e with SMTP id bj34-20020a2eaaa2000000b00244bf423e6emr2668077ljb.176.1645724242833; Thu, 24 Feb 2022 09:37:22 -0800 (PST) MIME-Version: 1.0 References: <20220224122614.94921-1-david@redhat.com> <20220224122614.94921-7-david@redhat.com> In-Reply-To: <20220224122614.94921-7-david@redhat.com> From: Linus Torvalds Date: Thu, 24 Feb 2022 09:37:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC 06/13] mm/rmap: pass rmap flags to hugepage_add_anon_rmap() To: David Hildenbrand Cc: Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , Linux-MM Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=CMiJRr3T; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.178 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8B8D240010 X-Stat-Signature: c7bc75bsp8ftu7kx845184b8jjenhuwo X-HE-Tag: 1645724255-69598 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 24, 2022 at 4:30 AM David Hildenbrand wrote: > > - hugepage_add_anon_rmap(new, vma, pvmw.address); > + hugepage_add_anon_rmap(new, vma, pvmw.address, 0); This now has the same "what does 0 mean?" issue. (And grepping for RMAP_, I notice that we have a namespace clash, with xfs and kvm also using "RMAP_xyz" for their own things. Oh wel, at least they don't look like they'd ever mix). Linus