From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A43C2BB3F for ; Wed, 15 Nov 2023 16:05:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C89380018; Wed, 15 Nov 2023 11:05:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 178196B036F; Wed, 15 Nov 2023 11:05:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 066AD80018; Wed, 15 Nov 2023 11:05:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E99586B0360 for ; Wed, 15 Nov 2023 11:05:15 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BB20B803FC for ; Wed, 15 Nov 2023 16:05:15 +0000 (UTC) X-FDA: 81460662990.25.38673A8 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf28.hostedemail.com (Postfix) with ESMTP id 7053EC00B4 for ; Wed, 15 Nov 2023 16:04:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=IHFgVqJA; spf=pass (imf28.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700064296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jzZnZquzqfUk+KfrDds9CQaV555iZ1w7ZZ/4IXXyLOU=; b=qyVX8cDRV/ZDn5/dz7tc9DPVFqFby2l3zpefb6IvhQGkNfODmE3BdHCOYSWcP3rigUW+hc DprIWcAz2K5VSsMWLWwOOHgFnYD7y9bpnCQbcd3huDlOu/0RER7OMLavxYZ0YTPQTL8dLx 3wBBN8CCX/W2goKoGnbAU22v57MnGew= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700064296; a=rsa-sha256; cv=none; b=GdWnvg6l3tpqz5/znC+2r6IR2PNAlkxEwiRotlO8owLjXecPGp33hWZtgpPvhKMO76Umy2 VIBH6hfBA57b1rTfPlcGPmXDTZ+eW+r6r1mzKvs+JAK8XUvaRAejGucXdSygsElhYD1lSz h202nyydNP8j+WEyaSn85FMB2uMlGfU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=IHFgVqJA; spf=pass (imf28.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-9c603e235d1so1026655866b.3 for ; Wed, 15 Nov 2023 08:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1700064295; x=1700669095; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jzZnZquzqfUk+KfrDds9CQaV555iZ1w7ZZ/4IXXyLOU=; b=IHFgVqJATMHeW4uKrbfGQWJgyu/4mwpx2METu+xa849l/WOaxBRcyx6GfS43+OgPW/ QOhGz4gSFrY9DmOY/KAagFXViIgGn2phNOATLIuJ00btEViQ/nrdXi4MrYZpD8Uno7QU imFpNpOpCw2Z+k7tzYdbUDTPSlkOidGW9lvEw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700064295; x=1700669095; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jzZnZquzqfUk+KfrDds9CQaV555iZ1w7ZZ/4IXXyLOU=; b=Djj/HHdIgmjbX533WgC6SiSG43r9pknC+9dCa8xwOAD6a/x/AtQrxAkSx+lTgIw3rV PAhWmbmqSwtHu25vch3ZrvNPIUu63uivtrINRwwsB6tVJsvp/Tu0tlePsoWYh5qb4ZCd vwHJvcPT4qfAJUTVT8pI7J3OorwCg2wU0kn2rvKCAKkIhkYKxnByKEDzBNN3HwsJTwyM hWpYmwzS+d9x+I0YthxtBUnAaNM1+M6MDChsivafdzED01WrUv0Ws75pEGJHGsiQDWWj WsLih4dy47CTuVWjd6FqsIqMsjKWj5Gkpo9j+/f6Nda2/7Ut+ipWmTqP6jSKrW4t4CQP nI8g== X-Gm-Message-State: AOJu0Yzrp9Fp9r5g73iibOqnTDz17dfnFm0VRMNzgmvYbJ4detFtro59 84GQLGvucynkXXI5XAO6gDe5II73CJOLpSLuMryRSIJn X-Google-Smtp-Source: AGHT+IG3y6eXVvwAdwS1hGKCvhXoKfuimjRpVOqx3vpb7TlYFcVGT1T5fU7l5r28va+vkM4XUwC09Q== X-Received: by 2002:a17:906:7b82:b0:9c3:cd12:1927 with SMTP id s2-20020a1709067b8200b009c3cd121927mr9517385ejo.5.1700064294753; Wed, 15 Nov 2023 08:04:54 -0800 (PST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com. [209.85.208.42]) by smtp.gmail.com with ESMTPSA id fi6-20020a170906da0600b009e6a990a55esm7223392ejb.158.2023.11.15.08.04.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Nov 2023 08:04:53 -0800 (PST) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-543923af573so10788641a12.0 for ; Wed, 15 Nov 2023 08:04:53 -0800 (PST) X-Received: by 2002:a05:6402:34f:b0:540:7a88:ac7c with SMTP id r15-20020a056402034f00b005407a88ac7cmr10183276edw.21.1700064293347; Wed, 15 Nov 2023 08:04:53 -0800 (PST) MIME-Version: 1.0 References: <20231115154946.3933808-1-dhowells@redhat.com> In-Reply-To: <20231115154946.3933808-1-dhowells@redhat.com> From: Linus Torvalds Date: Wed, 15 Nov 2023 11:04:36 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 00/10] iov_iter: kunit: Cleanup, abstraction and more tests To: David Howells Cc: Christian Brauner , Jens Axboe , Al Viro , Christoph Hellwig , David Laight , Matthew Wilcox , Brendan Higgins , David Gow , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: gqdduf8fst1aaay4gzu8iqhe9c5dr7i6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7053EC00B4 X-Rspam-User: X-HE-Tag: 1700064296-112355 X-HE-Meta: U2FsdGVkX18BlXYVpi16QqwUECKE14ArYeTTkdvoAJ6KC5wpoPQOwAYvZ1B6kjR42RDBAxp34OAIbjV/qI6jSMLSnzaBQ4Bm8W8nq9cTlhoCUsTnLkRa37WfsafZ77xlPXMBvRVOkKKyK5ZSIC6RPHY0VUJOok+qUhbT5xHTLSvZ0uq8cCjokVlHVFTmsIz6tHrwAnJnAEwE+jX1O8XPDtkxMPZskROj90Kt4TnuNbhr0J5KM4eGeQiDk4Oa2KP5l12JUMdfZULoKNUcVwP57VvwPAB+/biU+yH0ZiKAaxVmLG6ZsQISaZZ2m0Ll+EVhccBqDzLPbVaK/Ee0m454vL3GFFWs4MmRnsF4zU4eeK38Iax3DFYaVHpcy8FPfKg2UYB5b7nMSf/ukDEQBKlXGpnF+j4oVZTjuECHMls2Ln82qarF1Oa06q5spWk5w2qAx5hG/5vFNywjeksEbZzwzurZPumnqH0pVOy/ligL7IFaYSgJ4qhEajBKtcCP7NYUXit+CH+EfQmbKrOX6CAljESm/hagADOMZbjO8KIhCMtmSBi5xSRUFD8tELeiJyoMq9tdpo7a0UfMqyH08h1EKDh76f77hTJI9sm44jSKCw2nR2jq6iWBTRB2BbHj9MkadPbjrEONUeMIrNlHjp8WmHpEEnzj1VScVVbIcZK/vMn44fi/SCjKfnoEXwHfou2cA93iCkA8FcZMP3a7EY17IOQuEHwsCSAtV3XkXWijVnY7cExQhmGSEXOAprxRcwSe2LDBj15+fAFcbPr7U5xX9T7yJR3R021r/9bU7fuxeTnbYJRBYE9fOu+m02RFLoVjNQbG3UpWk52YqkTwR2w+qsPtd3bXaW3NCSk8hiCPKkTf2ZealdFdpeH0YuZDwSEyzt7DetN5J8Gb3IGK6272D1VMvepx390lp6twzDjS2AharqC4305+SrLhzJZEt8P6i0ivSYYaKq62SeNuADg LmfU4AS8 3jbA/x+YUZqHzUuIBAOe6YItzabcs+zATkfx7xn7jCOgEXGrFklb8ljxNYEJJDKULge1agT9phCzFrgMd1wRPBVgmmXJ5OngXRT5Vvm3UyniTdh8daiG0X92e5ZxkV/SewIpqUQXQdum5Rgg+wWxSOacNeGxH5Gj4nvBlO1xTZ5H1PwW8TAaqansDPX96IrKV6P5AElx9a7ZsYoWnN0wHnTd6op7yfDDqZ+KH1mzuHXCdGcXZ+REBNtBZxdOH/uTvQL5VgaPLtnW4BXcn5vw5rWOhVJ3P10QKoEXgF0fEPeLI8PmCxBtx35NQiD81JVdP38MGjENcN3pQTYmZdOX9i+pl6buNFeLC352+fZosySN8/ele4SQOXsKQzCfImzCzM94skxwzuioKMOefOMriK8WJRCqYHHW9VnWow55jkVxw9NpuGOEiq0toBlBGj/P5wEuq5eoKUKq3etIkWCtt06TaHQJRJLkF3g2MlQRuRzc1Aw+KmnIbrIXUbWUCSMbVsSPcf7vTJSZZvEfPgdF5vl470ym7ZFcJPl9HERu53umYJ4vo62DPIfU9hkGXc88xiB93 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 15 Nov 2023 at 10:50, David Howells wrote: > > (3) Add a function to set up a userspace VM, attach the VM to the kunit > testing thread, create an anonymous file, stuff some pages into the > file and map the file into the VM to act as a buffer that can be used > with UBUF/IOVEC iterators. > > I map an anonymous file with pages attached rather than using MAP_ANON > so that I can check the pages obtained from iov_iter_extract_pages() > without worrying about them changing due to swap, migrate, etc.. > > [?] Is this the best way to do things? Mirroring execve, it requires > a number of extra core symbols to be exported. Should this be done in > the core code? Do you really need to do this as a kunit test in the kernel itself? Why not just make it a user-space test as part of tools/testing/selftests? That's what it smells like to me. You're doing user-level tests, but you're doing them in the wrong place, so you need to jump through all these hoops that you really shouldn't. Linus