From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4079C4332F for ; Thu, 20 Oct 2022 17:35:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22D7B8E0002; Thu, 20 Oct 2022 13:35:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DDD78E0001; Thu, 20 Oct 2022 13:35:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A60C8E0002; Thu, 20 Oct 2022 13:35:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F14F78E0001 for ; Thu, 20 Oct 2022 13:35:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 88D54A11D7 for ; Thu, 20 Oct 2022 17:35:57 +0000 (UTC) X-FDA: 80042030754.12.0A9973E Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf22.hostedemail.com (Postfix) with ESMTP id 2B38EC0032 for ; Thu, 20 Oct 2022 17:35:56 +0000 (UTC) Received: by mail-qv1-f44.google.com with SMTP id j8so145183qvo.6 for ; Thu, 20 Oct 2022 10:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VWECp01B4Xx6nEq/eutNw6SLXu9E/6fw2YNROX2OzQ0=; b=P6c+wo34AHTMfodvTE1hZyTqBtPJJ77PhKMVQAaKwNRySnWfFI9yAQGjHMkEVJisdj 9fZvZ6fEOePG9WvMJeKEpcZto4/3bQvN3pJJFTtHOOlxLef94+44CI9Iv65zXqL4gIi8 UgfZkHMq6og8I2COhZV0d/QiI51DItYR6+vNA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VWECp01B4Xx6nEq/eutNw6SLXu9E/6fw2YNROX2OzQ0=; b=pnavtV3m4aA1Ii7yrjFevRggHNFGjCcCo/d2YDWC7D+dw37Ys+ARkLJHt+knOUFj4q LmLp71yzoiiSTSF8TBE1JY5YC4RAkje5k1frBxRXhe8ozgbNSgn1TCz2VrzMfcOk+KWO gW5IGvlKLc04o6BTYfA1Zq39IxsgBTJGQTXioPdETJWcvAj9xlk3bBCjPyz4aRnDfJUb aRx/eNUizQPoScGKq1k1SrDjXOEGADAuNGVQ/RLIVDOBa41UYTsEsgqLM+e6Lh2/eC52 isb1jqt7EfKVuzngMwAmMBEmHKkQ8VNH76+ytYIMPWtlHp9PX9Ayd45xDFkblc1AHSK6 jLyw== X-Gm-Message-State: ACrzQf2INgcIjdxvfCNJ07b/8O01LyUDeVgi4RqBW+W4qDPzkB8RwiZ1 l5ifdbkcq0rPCiz3RSgpLiJht+rH1miyuw== X-Google-Smtp-Source: AMsMyM74iWwv66cRTvfGsL5XKzwaClghCgHuDP1EByY/1bC8GktPBHZ6cL+DVV9xwS/BfH280zsXmQ== X-Received: by 2002:a05:6214:500f:b0:4b1:d2b1:54c with SMTP id jo15-20020a056214500f00b004b1d2b1054cmr12332542qvb.54.1666287356071; Thu, 20 Oct 2022 10:35:56 -0700 (PDT) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com. [209.85.219.175]) by smtp.gmail.com with ESMTPSA id p16-20020a05620a057000b006eed094dcdasm7584952qkp.70.2022.10.20.10.35.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 10:35:55 -0700 (PDT) Received: by mail-yb1-f175.google.com with SMTP id e62so422630yba.6 for ; Thu, 20 Oct 2022 10:35:55 -0700 (PDT) X-Received: by 2002:a25:bb44:0:b0:6bb:a336:7762 with SMTP id b4-20020a25bb44000000b006bba3367762mr11999002ybk.501.1666287344812; Thu, 20 Oct 2022 10:35:44 -0700 (PDT) MIME-Version: 1.0 References: <20220815071332.627393-1-yuzhao@google.com> <20220815071332.627393-9-yuzhao@google.com> In-Reply-To: From: Linus Torvalds Date: Thu, 20 Oct 2022 10:35:28 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v14 08/14] mm: multi-gen LRU: support page table walks To: Peter Zijlstra Cc: Yu Zhao , Andrew Morton , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666287357; a=rsa-sha256; cv=none; b=I9cu587ODfBBH+Ai3VbSYdm4LkBLXjfSEmjS1NKr+n/mqe3sBYKYkIShK3jy3Ys4+dtNyh ARK47pAOZ+UQmd68OTroyZCFcz2oE7g6/DxGZjlzBXYb30/S739roPkdV/lTB3hmd8k4Ww 1OaYHn0iPCWfqSpRHp9LDinwPjeNdOw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=P6c+wo34; dmarc=none; spf=pass (imf22.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666287357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VWECp01B4Xx6nEq/eutNw6SLXu9E/6fw2YNROX2OzQ0=; b=niPPidgwTi6tBehOK6yvKY+KED7EAUR6PK8Yh2OIOU8/AhhBXpPW0BTcvhttyq35F29sma VOoMJEJ88dzMT+uE4zRPHyE4i9wn8Ma0sd3jZD9ISEFLbUD/W7g1RZj7FOSYeaEVR0k7Ap w5VL4h0PIILBt1AEk3UUGvhKVTEWgFo= X-Stat-Signature: k3j44hds5gfsr1pmh7m64dpm4qf5fanq X-Rspamd-Queue-Id: 2B38EC0032 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=P6c+wo34; dmarc=none; spf=pass (imf22.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspamd-Server: rspam11 X-HE-Tag: 1666287356-607706 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 20, 2022 at 7:14 AM Peter Zijlstra wrote: > > So I've been sitting on these here patches (and never having time to > repost them), which is how I noticed in the first place: > > https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=x86/mm.pae Well, that seems an improvement. I don't love how GUP_GET_PTE_LOW_HIGH now affects the PMD too, but if it's ok for all the three users, I guess it's ok. Maybe rename it now that it's not just the PTE? That said, I reacted to that cmpxchg loop: } while (cmpxchg64(&pmdp->pmd, old.pmd, 0ULL) != old.pmd); is this series just so old (but rebased) that it doesn't use "try_cmpxchg64()"? Linus