From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A50DDC433E1 for ; Fri, 10 Jul 2020 20:11:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 580472076A for ; Fri, 10 Jul 2020 20:11:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WmpCdav5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 580472076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A8D6F8D0002; Fri, 10 Jul 2020 16:11:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A179D8D0001; Fri, 10 Jul 2020 16:11:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DE668D0002; Fri, 10 Jul 2020 16:11:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 743288D0001 for ; Fri, 10 Jul 2020 16:11:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 154154820 for ; Fri, 10 Jul 2020 20:11:33 +0000 (UTC) X-FDA: 77023261266.25.dolls01_5c0e69d26ed1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 9071C1804E3A0 for ; Fri, 10 Jul 2020 20:11:27 +0000 (UTC) X-HE-Tag: dolls01_5c0e69d26ed1 X-Filterd-Recvd-Size: 5422 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 20:11:26 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id d18so5576730edv.6 for ; Fri, 10 Jul 2020 13:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rOjG8jOG5e2cka7UROrnmdRc1ZeKdWqp04+UTzezgXE=; b=WmpCdav5rACJPM1yVreaa5jhIE1Rj0RGr/bF1Qjr1pwf2439Iz5WoGFXdSi5O12Dr5 IXWc1w8QTxV3dD+bOVtIv3lKjedZWexuqrhZTiipy7sQHNTW5whUuBZMflnCtZWXFq8v f4lJqs3GKRsPnpqvfmvNw1KFo/5w8EYLFRpdo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rOjG8jOG5e2cka7UROrnmdRc1ZeKdWqp04+UTzezgXE=; b=Z7qk43XCwQn46/XJHB+hwWyJegMD2jcruIfqEFhep2W24fhf8B1QukIwKUN4miO9Ku w7W2Yin2869i58kptTFpfEJcVOAvePzXOuSA3YdS+E+L2v2y+qeV3oRdD1b5lrvajBKy 1uxkrKjTcITOqpX0A+J+/7a95/Xa+PNRoUtqd9uvR8Z6a6pcUUR+Q9zaT1Rr8ntZPW3S GnSaVtWFzmk4c36K16/YOAp39Ol9K/BacYHqc1raAeNLJXGqbLf72rh6S/t/63O3tzmx RL2f2tYJeslDX/uZ3wSEkvZqiUXTDwV3nsSnVp4wwYKma5ep0glqwj7vv5/yWu9uErop MJ4Q== X-Gm-Message-State: AOAM530R3+30kXo7X3NHHK1TqVihDee92puA4DVMKwaarfc60FUsUVbt sVo+wEt+ce6QcchpTmyRDZuIZG6FOFw= X-Google-Smtp-Source: ABdhPJyWU2zTKx6T6jI114ScBlPPLruXzq0DbODB3d0k+9q6dz4UydAOxq1C3EFjoUyuGpRr7hi0aQ== X-Received: by 2002:aa7:c887:: with SMTP id p7mr65834678eds.240.1594411885426; Fri, 10 Jul 2020 13:11:25 -0700 (PDT) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com. [209.85.208.44]) by smtp.gmail.com with ESMTPSA id u13sm4255656ejx.3.2020.07.10.13.11.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 13:11:25 -0700 (PDT) Received: by mail-ed1-f44.google.com with SMTP id g20so5588183edm.4 for ; Fri, 10 Jul 2020 13:11:25 -0700 (PDT) X-Received: by 2002:a2e:9b42:: with SMTP id o2mr40061229ljj.102.1594411542731; Fri, 10 Jul 2020 13:05:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Fri, 10 Jul 2020 13:05:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: WARNING: at mm/mremap.c:211 move_page_tables in i386 To: Naresh Kamboju Cc: linux- stable , open list , linux-mm , Arnd Bergmann , Andrew Morton , Roman Gushchin , Michal Hocko , lkft-triage@lists.linaro.org, Chris Down , Michel Lespinasse , Fan Yang , Brian Geffon , Anshuman Khandual , Will Deacon , Catalin Marinas , pugaowei@gmail.com, Jerome Glisse , Joel Fernandes , Greg Kroah-Hartman , Mel Gorman , Hugh Dickins , Al Viro , Tejun Heo , Sasha Levin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9071C1804E3A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 10, 2020 at 10:48 AM Naresh Kamboju wrote: > > I have applied your patch and test started in a loop for a million times > but the test ran for 35 times. Seems like the test got a timeout after 1 hour. That just means that my test-case was wrong (in the sense that what it was testing wasn't what was triggering things). It might be wrong because I got the stack usage calculations wrong, but it might be wrong simply because the bug you've triggered with LTP needs something else to trigger. > Re-running test with long timeouts 4 hours and will share findings. That test was more intended to trigger the issue reliably, if it was just a "stack is special, needs that exact 2MB aligned case to be problematic". So re-running my "t.c" the test for long times with that kernel patch that removes the stack randomization isn't going to matter. Either it triggers the case, or not. I don't actually see any case where we play with vm_start the way we used to (it was basically removed with commit 1be7107fbe18: "mm: larger stack guard gap, between vmas"). So it was kind of a log shot anyway. Linus