From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EAE0C3DA49 for ; Tue, 30 Jul 2024 23:04:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6662E6B007B; Tue, 30 Jul 2024 19:04:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 616E76B0082; Tue, 30 Jul 2024 19:04:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B5DD6B0083; Tue, 30 Jul 2024 19:04:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2E0A76B007B for ; Tue, 30 Jul 2024 19:04:00 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CC2D11A0136 for ; Tue, 30 Jul 2024 23:03:59 +0000 (UTC) X-FDA: 82397948598.07.A7B8179 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf15.hostedemail.com (Postfix) with ESMTP id BAC24A0037 for ; Tue, 30 Jul 2024 23:03:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=csQIotkg; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722380575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=98QulGKZlowdI8LQPwLNFOLBD5wJiQYd69148ZBTs3k=; b=IvXoGj406Jw8zB5obkui9uZ36Y5tR459BsD1T3XaZ5E3EJ1ua+fIzcXSE1SQf63+KcKCKm EAMQW4RNuPEgMaNcaf5H2aG4GMJRojBZcA0TI3RblFYfOFuwhlSXrWhb/bttQVfVmY1h59 txmyeiX3BXO9dU0GyCcJx1RM/32lKKk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722380575; a=rsa-sha256; cv=none; b=l3QCHWiG7i/eQ6vF1NV5skHBNW/GaZ3UoLfrpgXJBkGVmQAGB3nnANyBWPqACctgHsFaYo 1HYB2JQvis0nLYIfsK1yfwWGuemdy/UheUu/eOc6bNFXY05hv7X9lNqDL96RVhAY2CqyCK QgxVUkWzInYJJ0of0eSxZZkvrLcrgOA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=csQIotkg; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a7a9e25008aso669697966b.0 for ; Tue, 30 Jul 2024 16:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722380635; x=1722985435; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=98QulGKZlowdI8LQPwLNFOLBD5wJiQYd69148ZBTs3k=; b=csQIotkgQVN8mDX3OXPHRd8O3Xr4fUdWYiIsEuMfEnUHLKuZlNOD/UaGowVGiegE9u DC7a5LtqjhWRf1Vkdp/hZjqXZ7pbN6gHUOtpV3OqHqqr/+pLr2LMUbwLicAVC5/zyQR2 sOF6eV8uyJ+r7Wf6n/dAKr9NF4PJzfCE6Np3c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722380635; x=1722985435; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=98QulGKZlowdI8LQPwLNFOLBD5wJiQYd69148ZBTs3k=; b=fSMprMxcMPwUxlBt5NvVPuouk17IPTfe90HaV3R/5Us1QGkwkqalMhxtlHmRIEa3lI YauAq7TL2oyP1k2uql5u5Eo1OJk1ptXa55DkcmkBRW4Tl5F55Osc3MJt8QjUBzkyK60E zSzG5oCDgZZDHYROv3LEFXL5W2/E9q4N9N9tUdgvPhFAb6ipgsGcIkLKb57pG/nMEL1e h1HR1vn/aupFMVMxyRfQqJGt12+JvTLScSP4JK56q0vy3RwVxyi0VG/4TEdF6Tvv+x65 OumgBj339+Yd2EEIcHKlq9vx/YwwIP7+Hn5aGt2KJVozy5e+O4JBLFmb8D6o6+rpaSLs NuZw== X-Forwarded-Encrypted: i=1; AJvYcCXQQoUxc9/JuZCak+7vIGtPKMQi5eSxAebHFOBGr8uNBeM/ltalkCHrqF4NjT+1sbzatklV7JdxPZ9XwopFqWcgFlo= X-Gm-Message-State: AOJu0Yxx0rwD8aWkRuXVC8Rx+ZZytQ4md2wFZb8XJrzWpBwwxjp1jmrD nFIIVrQMZNUfQYcdBGy7xAEDnjlnra8uNq+gFFws+oZXNjVax3jJ8k+k041yvX581/VhPits/5k gFv9Yaw== X-Google-Smtp-Source: AGHT+IEwpUnsBd7aR5+lGkcRH7/GuRsLTslA+5QXr5E+wvhRQPqAmQcbVyLhxBOqbwPFGfgzQxdClQ== X-Received: by 2002:a17:907:3da2:b0:a72:6055:788d with SMTP id a640c23a62f3a-a7d40166145mr1027428566b.42.1722380634584; Tue, 30 Jul 2024 16:03:54 -0700 (PDT) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com. [209.85.208.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acab236a2sm699473966b.29.2024.07.30.16.03.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 16:03:53 -0700 (PDT) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5b214865fecso3365468a12.1 for ; Tue, 30 Jul 2024 16:03:53 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVa0Yp0WQ9uFESCNrXGE2X+btE3Li/BdNN2JmJCYHtvsyYfDNw04W7uhAt0+3RMsIcaokEMNl38+29REekwDHg+Afw= X-Received: by 2002:a50:d55c:0:b0:5af:a605:cd84 with SMTP id 4fb4d7f45d1cf-5b0221f0b78mr7711590a12.33.1722380632870; Tue, 30 Jul 2024 16:03:52 -0700 (PDT) MIME-Version: 1.0 References: <402c3c617c29465c898b1af55e3c6095@AcuMS.aculab.com> <5cd3e11780df40b0b771da5548966ebd@AcuMS.aculab.com> <8111159a-c571-4c71-b731-184af56b5cb1@app.fastmail.com> <73d65e2553e543069f9969ccec4ea9b3@AcuMS.aculab.com> In-Reply-To: From: Linus Torvalds Date: Tue, 30 Jul 2024 16:03:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] minmax: Put all the clamp() definitions together To: David Laight Cc: Arnd Bergmann , "linux-kernel@vger.kernel.org" , Jens Axboe , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BAC24A0037 X-Stat-Signature: r11x3aa9b66knn6qogypmokea8a4mkn6 X-Rspam-User: X-HE-Tag: 1722380636-919380 X-HE-Meta: U2FsdGVkX1+eOyj9Rb8Y7a0f3e3mzcxIylU4mGFEmKxl9OHDD5hWc/DRzGP2QjH/8yKWNgP4Tra1DblNhMbRDPtzpB+r5dH4QgKO/OnqYUgfiZeF72fzSX5FJE3ol98WAJXJbxzjFofwg0pRTXeykB2IPnnCSyibGKB5Qn5m/Kxyfz5JIkygPHP4mMigq5DOrF6Y2FUWxCMcwgiYloSriGh20BzOLecKGoEYi2Fvmwqg8VhAHsLcCa6mT93XtHNYxOZLRlwDEi2g8U8F72RVZNimJG9JfV32X6IibCwueSG7PX4o3duNPX0Y+pesNsljho/fqWsW7GINc2vCkTPetfVQUXFW4Yq1eok4ntie835kHudF8Mr93spmnGGSm2VPTz6q1WuAAeltonRJBUsbI6z1pOSKTxbsKzhhfvZGAo2cqOm7uG4f4IZJoyGESbYAzJjP3r42bIDFeYnZ+ptL/rmFhoa7Bs5OnKgxC5n7hF7Dm1BRoPOvthyUgNKJokXq2udc2ysAOBx9t/8b64qy7q90L6IeLFaLeU8HgjElwKWQ1rZjXA2WAGAFVh9/G1DvcIO0TePUYIDs2jfdXRWQNQvF+8FDgBczpuqDv81ywyrpdX+0Z55JO6ZDTGxT4ffbJ2krLG62EXxaWON4U+lgjdxCgP2K+z+z7X5sgVueaj1M8paUTD8OH8FP6rzCHuRZCrWnGdaiKiruFhUDWxYx9BL5z5Wpcy7YQiiNJlxxXY4chBkhOHlkj0QWvu+o2hoVCczj3VwwCF2Cp4mRmS65F1WMLG8un1XleGpXAkwdq9ts1LabExWhwAmqs5xkVgr4sGn3vhLsHVAnsUQnEIPrmWYXi+/une1NaMhHD4sd6iUw6vIblZhZfn1/h2kyykmgAg4KEXkPy5fpfKMGgwlKyoleWh7DL4RbrBq0u1Q4lTihZWLgklQPjMBQ3GjMkXGo9PJwRWwfoLEW3+y6dcB NqaiaAMH 7W14ZlWTQ/tilS9FatKI7YTxCo40Lg0rgksuY/oXCzHdhMgSkOS0XDfbk/bTVhYtTYxWsR8g1IoW+Mz1rnnpxl445gKxiVPxEKCQTgZprAFGY68fJhaO9rizLdooilmons/FKoNOQndXuxPzVb1BwX55dVbxMCpaKE/5778jKYlp85FWuLyH20LkTVtwUNNIuR6zLnBp1VyGn8rbqWPGiKUlRyvTOzbOZL5PbytD8XHa5zPN2tjnvPMG4mLZukWeppy2nRj/iE9/mRyHUFeTGnO9bKsyq20ZQ44w/X+QeFZD8tuiDI+CEThCWV6+l/bdafhnZ+XetyxWRaQcErst+3v9tdWXZu7pqTp5pVkDBXCzrMO8klm7IaGbJlAhzuPN9ih5SG0McZfxzj7ug39a/UYZpZfjyS/Y4x40ukKhAFiIJgEvGzhDF77Td9RlthkpRRg7n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 30 Jul 2024 at 15:44, Linus Torvalds wrote: > > Does this work for you? It seems to at least build cleanly here, but I'm not claiming it's all that great. The nested __cmp() is still rather less than optimal from an expansion standpoint, but at least it expands only those unique temporaries. [ Side note: having not looked at a lot of the resulting pre-processed mess, I'm not convinced it really helps to make those unique names so long. The whole "__UNIQUE_ID_" prefix looks good once, but to some degree it actually hides the important part, which is the actual prefix and the unique number. But honestly, nobody ever looks at this part normally, so it probably doesn't matter ] It might be possible to cut down on that by doing them in series instead of nested, but I think that would require something like generating a fourth unique name, and something along the lines of __auto_type u4 = __cmp(op, ux, uy); __cmp(op, u4, uz); as that last line. And no, I did *not* try that, and there might be something I'm missing. Linus