From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32E3C433F5 for ; Tue, 4 Jan 2022 21:43:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 407446B0073; Tue, 4 Jan 2022 16:43:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38FFF6B0074; Tue, 4 Jan 2022 16:43:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 231AE6B0075; Tue, 4 Jan 2022 16:43:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 139886B0073 for ; Tue, 4 Jan 2022 16:43:44 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BDA1C95272 for ; Tue, 4 Jan 2022 21:43:43 +0000 (UTC) X-FDA: 78993931926.28.A4A9DDC Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf18.hostedemail.com (Postfix) with ESMTP id 1ED711C000B for ; Tue, 4 Jan 2022 21:43:30 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id n30so41570585eda.13 for ; Tue, 04 Jan 2022 13:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VlyYekp2oj/MkvkvX6Ay1MnkMaZXRB1aMd6yZZPObxg=; b=FB42VyHKTobzOeaP4gUSV6P6ReZLYkYHUoGFUaidmRZkPqcaL1gU1PiqCIQSDsIyP3 G2dMmKIGbwCwZxL5Q6Geo0D+hbdN1rmrn3hKm7ibL56t4pBENhJw6uVIIkoQrlQVoWPl zgAQWzAnmn6OnNonVWgzgy8Lz5doKmYmIOf/g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VlyYekp2oj/MkvkvX6Ay1MnkMaZXRB1aMd6yZZPObxg=; b=bV55c8qFo8HCJgK+1qCAjdhEmR+CakVRHL8zfHuyJzLalX1PRyL60qzCLj7gyATILL zjM0sxBPg6qRm2blQEBLXM80WiHS/C0lTaWCZajIqPVqjZzFJCC48lOvPvTrYojc4Jz8 JMEhOcy6qMPqssDFHbeb9l33IkWzifsn2CFhqj9Lh7g3kz2F+fctMD6X3B/pl3HE8q4p gM8AOqtlTDjUPftz9G78dHCnJfGGK201WbcJqbSrWhM8TD9TdfrbArNaaT/ALN9dHKDo ZkNf7fjOoBj+lWDaPsyoi9CIlzBH5ZhsoyCCwTSaJWcSrcqiewBKFMtHuu4dJrQtMhoY rKJA== X-Gm-Message-State: AOAM530HQGiOiobk4o9/6Qj5xY+gGKq3PaO46abKRsaXv4rhFeOXE9fK 9w9nYuCZQ1FMRdDpPlwIQxHgRSa0z2zqksymiLE= X-Google-Smtp-Source: ABdhPJyUlsXtBUdHZdnEPpCuuTya7IisbFiS3uNSGfaYTa2KYybsRi+DVLO+QOEbJG8FHz1SxiOY8A== X-Received: by 2002:a05:6402:2808:: with SMTP id h8mr49665393ede.58.1641332621239; Tue, 04 Jan 2022 13:43:41 -0800 (PST) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com. [209.85.208.52]) by smtp.gmail.com with ESMTPSA id qf14sm11213221ejc.18.2022.01.04.13.43.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 13:43:40 -0800 (PST) Received: by mail-ed1-f52.google.com with SMTP id b13so153694119edd.8 for ; Tue, 04 Jan 2022 13:43:40 -0800 (PST) X-Received: by 2002:adf:c74e:: with SMTP id b14mr10486476wrh.97.1641332609879; Tue, 04 Jan 2022 13:43:29 -0800 (PST) MIME-Version: 1.0 References: <20220104202227.2903605-1-yuzhao@google.com> In-Reply-To: From: Linus Torvalds Date: Tue, 4 Jan 2022 13:43:13 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework To: Yu Zhao Cc: Andrew Morton , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , Linux ARM , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Linux-MM , page-reclaim@google.com, "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1ED711C000B X-Stat-Signature: xdx5e8zzu548z6m9p4hyihbka9b7b4nz Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=FB42VyHK; spf=pass (imf18.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-HE-Tag: 1641332610-583066 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 4, 2022 at 12:30 PM Yu Zhao wrote: > > My goal is to get it merged asap so that users can reap the benefits > and I can push the sequels. Please examine the data provided -- I > think the unprecedented coverage and the magnitude of the improvements > warrant a green light. I'll leave this to Andrew. I had some stylistic nits, but all the actual complexity is in that aging and eviction, and while I looked at the patches, I certainly couldn't make much of a judgement on them. The proof is in the numbers, and they look fine, but who knows what happens when others test it. I don't see anything that looks worrisome per se, I just see the silly small things that made me go "Eww". Linus