From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 705E5ECE587 for ; Mon, 14 Oct 2019 17:41:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 37CB820854 for ; Mon, 14 Oct 2019 17:41:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="HWWymbYd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37CB820854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D93BB8E0005; Mon, 14 Oct 2019 13:41:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D44828E0001; Mon, 14 Oct 2019 13:41:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0B6F8E0005; Mon, 14 Oct 2019 13:41:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 992DE8E0001 for ; Mon, 14 Oct 2019 13:41:40 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 2208F68BC for ; Mon, 14 Oct 2019 17:41:40 +0000 (UTC) X-FDA: 76043107560.06.jelly04_82e980e44ac09 X-HE-Tag: jelly04_82e980e44ac09 X-Filterd-Recvd-Size: 4434 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 17:41:39 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id y23so17442588lje.9 for ; Mon, 14 Oct 2019 10:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P799DeurAv7knAP/9jFPDE4m8m+46TvvpHN93XfkDjE=; b=HWWymbYdZnWtJmHwFOmPF1ZzJDaTOeayFZ5PwgDvPf6UmwnVngK8F0WL6ftDpUBt65 6CA7fbK/RfBrDC+lGkPSzKjf3Py8iCvGuqPRh2kQkkDM55QsR1au+xiI2Z52IW4rOkCn s1q1W19Sc+umQVIDvAwB4blHAjaZuSeemBQjM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P799DeurAv7knAP/9jFPDE4m8m+46TvvpHN93XfkDjE=; b=N6hvpOZUA6H3rmMfFLicQev014REo9LKnk3mNY7g6kMB2Ijh5LRvK4rxtbPEjUwOG8 riJk9iowUwgPFirTNE6+tSM5zFtX2USRWP53pH/2q0WiH9+0qlrOnZvPthIENo+KQi8q 5fup7kDMlFxBUcfMeNJNn2Q4mZG7lQ1Ux8QPO7EkR44/ZceYw60oTiss0rrCQuOClEIT yLjVTtoBwLA0rTyxLJ4wpkSVfRfHJTnnQ5rMszuBxWM06YZ0Da/ZZV4hDPJ2M1CzA1Xl w3mHCTgagzkkl1OJ/U2n/EE/Rn3c+s7/oRCfMfHCYlxCfSabfrFI6Y9BzcDVKh1epMrd X1rw== X-Gm-Message-State: APjAAAXZVwx8vtSaQoOjHuNsd7kRVX5Gk7QTDQD3mXwAlSTedO3kKtXO w9tvnGMYmWd2WkC3trdt7K8h2wTdyfw= X-Google-Smtp-Source: APXvYqz4W9AYEaxeMZGhky1q9AtcQ4XL1p4xRzCBLoLRxswDwdjrLlRa3duP8iE5g3C95ubGE3XutQ== X-Received: by 2002:a2e:9693:: with SMTP id q19mr18968518lji.6.1571074897232; Mon, 14 Oct 2019 10:41:37 -0700 (PDT) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com. [209.85.208.176]) by smtp.gmail.com with ESMTPSA id 202sm4417630ljf.75.2019.10.14.10.41.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2019 10:41:35 -0700 (PDT) Received: by mail-lj1-f176.google.com with SMTP id n14so17439857ljj.10 for ; Mon, 14 Oct 2019 10:41:35 -0700 (PDT) X-Received: by 2002:a2e:6a04:: with SMTP id f4mr19334971ljc.97.1571074895188; Mon, 14 Oct 2019 10:41:35 -0700 (PDT) MIME-Version: 1.0 References: <20191011121951.nxna6hruuskvdxod@box> <20191011223818.7238-1-vgupta@synopsys.com> In-Reply-To: <20191011223818.7238-1-vgupta@synopsys.com> From: Linus Torvalds Date: Mon, 14 Oct 2019 10:41:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC] asm-generic/tlb: stub out pmd_free_tlb() if __PAGETABLE_PMD_FOLDED To: Vineet Gupta Cc: Linux-MM , linux-snps-arc@lists.infradead.org, Linux Kernel Mailing List , linux-arch , Arnd Bergmann , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , "Kirill A . Shutemov" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 11, 2019 at 3:38 PM Vineet Gupta wrote: > > This is inine with similar patches for nopud [1] and nop4d [2] cases. I don't think your patch is wrong, but wouldn't it be easier and cleaner to just do this instead --- a/include/asm-generic/pgtable-nopmd.h +++ b/include/asm-generic/pgtable-nopmd.h @@ -60,7 +60,7 @@ static inline pmd_t * pmd_offset(pud_t * pud, unsigned long address) static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) { } -#define __pmd_free_tlb(tlb, x, a) do { } while (0) +#define pmd_free_tlb(tlb, x, a) do { } while (0) #undef pmd_addr_end #define pmd_addr_end(addr, end) (end) and just rely on the regular "#ifndef pmd_free_tlb" in include/asm-generic/tlb.h? Completely untested. Linus