From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA624C433FE for ; Sat, 22 Oct 2022 17:31:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFAA08E0002; Sat, 22 Oct 2022 13:31:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAC0D8E0001; Sat, 22 Oct 2022 13:31:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9BAC8E0002; Sat, 22 Oct 2022 13:31:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A65098E0001 for ; Sat, 22 Oct 2022 13:31:11 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7BA5E40B8E for ; Sat, 22 Oct 2022 17:31:11 +0000 (UTC) X-FDA: 80049276342.29.B29DBFF Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf24.hostedemail.com (Postfix) with ESMTP id 0F8C318000C for ; Sat, 22 Oct 2022 17:31:10 +0000 (UTC) Received: by mail-qv1-f50.google.com with SMTP id f14so3973846qvo.3 for ; Sat, 22 Oct 2022 10:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vNO4n1X5BpGP+j0JDX4vtFFXwAjuMrA9O/wBbEdNfDc=; b=ddSbbairWn90T3DOQN+X79nE6dPhX/Lt11JVyrVfHbKBT6ajo5tFCHdSCq6BYJO0WM lfXxT/CvjAvgRJV/9iVAxeyUUTzEur2hHAwlxtcT/VqQTHEpb2SFFolNxt4IDjHahnzX 0ZIIHBl44TSHwCyKiwenfDzD7VY93ZJPXGsuU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vNO4n1X5BpGP+j0JDX4vtFFXwAjuMrA9O/wBbEdNfDc=; b=mfQYGjyTnErgJs4EqAtzzivNaCJ8HM1kvYnta6KGgWidlidC4pyXxJFrqNRyB7eyh5 RdmZLApTWIMJKQ5L/FeJnQSMPMpulTHWjjZ3kujPb5xlb1P5pQprWYU3U45v5s3EOgr0 P9QrMBfqEm0v/MngM+FUYx3a+1N3l5F/30bIR0MGmwNe+pZ3YHF0korYN96BivD0aguk Xn3rKJ7jdpkzsyCx4VOLz2gc7tq4x6SCiZOvDKaU73vPlC5mRqGW/HF/bpSvrJ2q+Q3j ihdUG7evAj7C2Cn23NthbvocDJXGeK5QvmHW/pdLEvS8frWW6g8kYohgmRviK0+nQ3zD x3Pw== X-Gm-Message-State: ACrzQf1+ExXOO+NRC8A7GinZ29eL98sHfnfXROWSTdvwL7C+Dcig6uJI Q28h1sAeCaT2xU77hP88C0Luo/ncUuvTWA== X-Google-Smtp-Source: AMsMyM5M2UFcLHD1Zx6+wDALqo3rHkQ/B+1m7dVEaF4YURDWKvBsQxC676lTSAluE9dPohrrt41hJg== X-Received: by 2002:a05:6214:1d2c:b0:4b3:e48b:39d2 with SMTP id f12-20020a0562141d2c00b004b3e48b39d2mr22388936qvd.74.1666459870058; Sat, 22 Oct 2022 10:31:10 -0700 (PDT) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id cb23-20020a05622a1f9700b0039cc22a2c49sm9915343qtb.47.2022.10.22.10.31.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Oct 2022 10:31:08 -0700 (PDT) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-3321c2a8d4cso51480327b3.5 for ; Sat, 22 Oct 2022 10:31:08 -0700 (PDT) X-Received: by 2002:a81:114e:0:b0:36a:fc80:fa62 with SMTP id 75-20020a81114e000000b0036afc80fa62mr3963111ywr.58.1666459867739; Sat, 22 Oct 2022 10:31:07 -0700 (PDT) MIME-Version: 1.0 References: <20221022111403.531902164@infradead.org> <20221022114424.711181252@infradead.org> In-Reply-To: <20221022114424.711181252@infradead.org> From: Linus Torvalds Date: Sat, 22 Oct 2022 10:30:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/13] mm: Fix pmd_read_atomic() To: Peter Zijlstra Cc: x86@kernel.org, willy@infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, kirill.shutemov@linux.intel.com, jroedel@suse.de, ubizjak@gmail.com Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=ddSbbair; spf=pass (imf24.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666459871; a=rsa-sha256; cv=none; b=g1X9hz9E/ThqgQZOJzjq72EOjiZdzh1YQGCHWErXTGBBP0zjWIEgCMHTaFD8PHb+vRNl1r mjLV9gF5xA+BYbOZyz1W1KR6Cc7t7Kjv+A9X+cLHpjf+DElWD+dKvf1Gnoc0WhFCbx/EEM XpCd7Q3DRav889v9I9K5fagOonpwEow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666459871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vNO4n1X5BpGP+j0JDX4vtFFXwAjuMrA9O/wBbEdNfDc=; b=EQkQQ75FfNql7Vuq7RIWId1i86SWycbupF0thu2WNIbEct4jBU8WUJoHlNNxZhoc0hSP7p idKwnxxd+P05mMI754S7vQ4c8SD0vx/JnuSTPe13Vh8Ywy1Z733PiqLjkMY1bVn5tRH4Ye z/pp0s8/SqpsAKKqyEsk4DxQn/XHd5s= Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=ddSbbair; spf=pass (imf24.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Stat-Signature: owdq9kyizeyz1cr63mpa15ks398msyju X-Rspamd-Queue-Id: 0F8C318000C X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1666459870-400231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 22, 2022 at 4:48 AM Peter Zijlstra wrote: > > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -258,6 +258,13 @@ static inline pte_t ptep_get(pte_t *ptep > } > #endif > > +#ifndef __HAVE_ARCH_PMDP_GET > +static inline pmd_t pmdp_get(pmd_t *pmdp) > +{ > + return READ_ONCE(*pmdp); > +} > +#endif What, what, what? Where did that __HAVE_ARCH_PMDP_GET come from? I'm not seeing it #define'd anywhere, and we _really_ shouldn't be doing this any more. Please just do #ifndef pmdp_get static inline pmd_t pmdp_get(pmd_t *pmdp) .. and have the architectures that do their own pmdp_get(), just have that #define pmdp_get pmdp_get to let the generic code know about it. Instead of making up a new __HAVE_ARCH_XYZ name. That "use the same name for testing" pattern means that it shows up much nicer when grepping for "where does this come from", but also means that you really never need to make up new names for "does this exist". Linus