From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9131CC7618B for ; Tue, 14 Mar 2023 23:40:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB4596B0071; Tue, 14 Mar 2023 19:40:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C63FD6B0072; Tue, 14 Mar 2023 19:40:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2C006B0074; Tue, 14 Mar 2023 19:40:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A44C06B0071 for ; Tue, 14 Mar 2023 19:40:19 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 714BD404B2 for ; Tue, 14 Mar 2023 23:40:19 +0000 (UTC) X-FDA: 80569124958.02.67C083A Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf11.hostedemail.com (Postfix) with ESMTP id 77D8D40014 for ; Tue, 14 Mar 2023 23:40:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=SWqsjXNt; dmarc=none; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678837216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uNuC5vuLHUrjsLAEtJntp1DYmMh0ryjDseFJIAEyVKE=; b=4/rj0WUC619Wb9VLDKrRKOZ+GMal3lXa/KRQYx8Jkump0ofaE8JlnnWfhwlEkjJBHWSgco 0+th9IDTDlXkwkaQUp/G3+KtXhtcxe0wH3vneswOIlJQPJSslNtbv7AqgXaOESsgMIqo4w o8WXgTQ7O18NRXS/NI0zM7XQD6Aytd0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=SWqsjXNt; dmarc=none; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678837216; a=rsa-sha256; cv=none; b=aCKzCVC8wyJJtlk7VGWx8hVyncC8/TSIjhyxMF3TRnLTFzpB80U4qXxleoSFAKLWh67kda yJ9+3zZppkkiD4m1UXvx2XxH/qUYdcNocuAi1QeVf7cKXUzZSMQYjA7LwtgLL0c3sw/MKY tCDp7Bjac3AQmMdBxafKFHrU41/2XEc= Received: by mail-ed1-f47.google.com with SMTP id z21so3496906edb.4 for ; Tue, 14 Mar 2023 16:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1678837215; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uNuC5vuLHUrjsLAEtJntp1DYmMh0ryjDseFJIAEyVKE=; b=SWqsjXNtJB90zrndCdVwNbsgqtdhu21jKTQCRGI+yGN8eaKZJdg+Ia/4z6CNA17e25 +YbzCjCwIJrc7wvpays0t0a4NTBUNih9VnP0oyTKL7nPZ/+d2WBNWGYNhQ4STTZShx2W uU8qXwm4+fPS4iWPXCcND8/UwnyPMdHQUuyoc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678837215; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uNuC5vuLHUrjsLAEtJntp1DYmMh0ryjDseFJIAEyVKE=; b=Gf08CfmfDvFYC/Hv733lpod5ML2cPPb/Dxxym5NXQOUPVE8cyPs9lSUxyjQGOvfHpO EGyT+q2oRjJEShwVzp2Odjsse5xZudttPdREKOyP7bRFc7J8SV3fWvgfthzbB78uh5tE 075kb9+4y0tZre7PVLS4xMmyzjFq1H+zUN1Ky+JyoUs/4UOqp4CFJWlK8lNVTzqxBI3I Du5f0lrCrY8Q8qcUbjNw6eMKvk9pd67SSwTomMupMqlXoti/kCkQDKfRaUcWOG8z5flI NhrTPcDlREjLPCCwKr69I1g1A1Z6v1EZX6BMJV+d8EQEBd6NKesqmzM0ckHqyIzKIF3I QkQA== X-Gm-Message-State: AO0yUKWIGg9a6tNd1/yvaFXBFQPQhJNw7XHy0BCkHgG+EBIh5Gtxi/ou fA8syTFbNOPC/5Yp9JcStC/ZlIpmKp/m42kb5tSCnA== X-Google-Smtp-Source: AK7set8n7jEGpjpm+ovIXNO83zDgLu44RaeXReMUzLJB37FQUM482d5xA8kezvNkR18opjrkZprH1g== X-Received: by 2002:a05:6402:53:b0:4fa:4b1c:6979 with SMTP id f19-20020a056402005300b004fa4b1c6979mr712865edu.28.1678837214636; Tue, 14 Mar 2023 16:40:14 -0700 (PDT) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com. [209.85.208.52]) by smtp.gmail.com with ESMTPSA id 18-20020a508e12000000b004fa380a14e7sm1644842edw.77.2023.03.14.16.40.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 16:40:13 -0700 (PDT) Received: by mail-ed1-f52.google.com with SMTP id h8so25031813ede.8 for ; Tue, 14 Mar 2023 16:40:12 -0700 (PDT) X-Received: by 2002:a50:d506:0:b0:4fb:482b:f93d with SMTP id u6-20020a50d506000000b004fb482bf93dmr435862edi.2.1678837212326; Tue, 14 Mar 2023 16:40:12 -0700 (PDT) MIME-Version: 1.0 References: <20230314220757.3827941-1-dhowells@redhat.com> <20230314220757.3827941-4-dhowells@redhat.com> In-Reply-To: <20230314220757.3827941-4-dhowells@redhat.com> From: Linus Torvalds Date: Tue, 14 Mar 2023 16:39:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v18 03/15] shmem: Implement splice-read To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daniel Golle , Guenter Roeck , Christoph Hellwig , John Hubbard , Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 77D8D40014 X-Stat-Signature: o1axnqewepukuc95isrdxpfmowpufqs9 X-HE-Tag: 1678837216-353202 X-HE-Meta: U2FsdGVkX18MNpHpG9FtKh/RiuvDgyYYQGulwYJfqHtiN+sDYQIqj67/4yRJuIbYpyCWaYL1WU4GGJl83PDHcFJgxNnbjRXuzvHYd2zck8kHeaCj+13/QGkFCTQV/KOgwxK259hj7WZode49IjbHC3r9jziwHxeP4RnD52aj+7TYP5cxE4GRXXJwvnBObWSZPgLhVAfbNBYdzQPui9Ut0kP7VxXVCqLiZUw/RumTuZbmyJQJPMUkfYg+5AFVWPJqsGna2C9AwUD1qqOnUVO0cz2y9kWgj4iY9+6n9NjTcbH5/oEjmveJ4lDUmq66J3UO3yKEBnBil21zPKHjCOnaAEWGRIKfaEupfu1W8FOMrxZCi58WbOPW0L92djeU0NQi8B6fMbB2kUxtvnZkYPsdictM5FicxibvBB3aA/sCBUgF1VxHRyjcy6ERnvDfy85wdpaWASPpntv4st02uRYjpzSmee+j+xty8a2Hxo7JU6wGhDEMNvBaw3/+7kSmxik5ZiMR2BQ5/9U9ssSVfOZURUsY+K3l1qGS6F244c1XB3qjlzemfMBAdMv7DLZLprffvVjjWapnZCPq8k8qxOkJ5l+DFvldisadYFlGga+W29K/t9GuY6oQGKIQ/KD8HlcBShRgEgXEgN8QfQrGH1ZrjZj36keV+dKYRx5RNuoomqEo+cEKTYsrGAiz6OVsMi+6NTwuE5ZxAEVYLMCFQsIK4yL/63RSXekx8ARbzt39ZUozI4eTBrq+myl6np8jX2NJna8jcZX2le3DeukdjTfeQCxug63pUw5kayo2NwX1879LX7tB8heZNtva8Els1bH9SxOEZLnv9IWU0PiExovpEn+agfF83gaLLndPsk5+l+tUiUw4ngwr+GwcBJP0S76aTuuyfAP3s9Ryp4GNJQ4tb5W46p4mIaqWxjdgKLnNAtnWLUUfzYWaLr1Rhz8e9N7dIByMeuqpvhfRGhZ3F6V MY5SWd9i 6TLj2wsjsjhfKfuW8PiQ1QSUXALrsxwSsLhDGap7TFqNmeoC0Mk9Wn60MXQMt5oiM07QCYdc45ztdlw5LB9Tz8M4y/qm1NYmziIJ8viA3GVcE9YITqGKwRsASEQrQsjrZ4ePvthYfaIG0XxkL5voAM6teqnmNSohH9O845NdPOeLFPyO0FegL8847SqUxZhkr+3gDOzMVzEBn+ipIlKspMZ1IXdyT/Q7fdBrRbs8wCDm3VL7UF7+LkuNcb8af/dKM/8XBcztfZy5ifdZBzgfkHZQ4y2UIYG+iYLvAAAeL4aEd3jXjPMEQTYNavMCoPjA/fDQaVtHFf+ycj0VDfW5Uejv/Q6x9LegCSLFPa6ijZ0wRKwDY5iLQXxIgrac5NJSm1xs9SNEqGFZzL1iz5h5H4196PgKZQH8dms9joJlWbnL7IP5SvmdDCKs6NVpu8/ryx+fPc9RLjUxcjNpzBXrjPTtOe30ziDHsARIXBB0vjCM8MJb2XeVrpJsotUyy9SMvF01gpbOmQr6eGsu/FcdqPvPNn62PB104V4F1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 14, 2023 at 3:08=E2=80=AFPM David Howells = wrote: > \> +static size_t splice_zeropage_into_pipe(... > ... > + *buf =3D (struct pipe_buffer) { > + .ops =3D &zero_pipe_buf_ops, > + .page =3D ZERO_PAGE(0), > + .offset =3D offset, > + .len =3D size, > + }; > + get_page(buf->page); That + get_page(buf->page); is still there, and now it's doubly wrong because it's never dropped and will eventually overflow that count that shouldn't even be there. Linus