From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Hillf Danton <hdanton@sina.com>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Daniel Golle <daniel@makrotopia.org>,
Guenter Roeck <groeck7@gmail.com>,
Christoph Hellwig <hch@lst.de>,
John Hubbard <jhubbard@nvidia.com>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v18 03/15] shmem: Implement splice-read
Date: Tue, 14 Mar 2023 16:39:55 -0700 [thread overview]
Message-ID: <CAHk-=whKPK=Bn_je2A19rSptpDo589DWxBJi8UQYS7sPjDPurw@mail.gmail.com> (raw)
In-Reply-To: <20230314220757.3827941-4-dhowells@redhat.com>
On Tue, Mar 14, 2023 at 3:08 PM David Howells <dhowells@redhat.com> wrote:
>
\> +static size_t splice_zeropage_into_pipe(...
> ...
> + *buf = (struct pipe_buffer) {
> + .ops = &zero_pipe_buf_ops,
> + .page = ZERO_PAGE(0),
> + .offset = offset,
> + .len = size,
> + };
> + get_page(buf->page);
That
+ get_page(buf->page);
is still there, and now it's doubly wrong because it's never dropped
and will eventually overflow that count that shouldn't even be there.
Linus
next prev parent reply other threads:[~2023-03-14 23:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 22:07 [PATCH v18 00/15] splice, block: Use page pinning and kill ITER_PIPE David Howells
2023-03-14 22:07 ` [PATCH v18 01/15] splice: Clean up direct_splice_read() a bit David Howells
2023-03-14 22:07 ` [PATCH v18 02/15] splice: Make do_splice_to() generic and export it David Howells
2023-03-14 22:07 ` [PATCH v18 03/15] shmem: Implement splice-read David Howells
2023-03-14 23:39 ` Linus Torvalds [this message]
2023-03-14 22:07 ` [PATCH v18 04/15] overlayfs: " David Howells
2023-03-14 22:07 ` [PATCH v18 05/15] coda: " David Howells
2023-03-14 22:07 ` [PATCH v18 06/15] tty, proc, kernfs, random: Use direct_splice_read() David Howells
2023-03-14 22:07 ` [PATCH v18 07/15] splice: Do splice read from a file without using ITER_PIPE David Howells
2023-03-14 22:07 ` [PATCH v18 08/15] cifs: Use generic_file_splice_read() David Howells
2023-03-14 22:52 ` Paulo Alcantara
2023-03-14 22:07 ` [PATCH v18 09/15] iov_iter: Kill ITER_PIPE David Howells
2023-04-20 22:22 ` Al Viro
2023-04-20 22:36 ` Al Viro
2023-04-21 1:11 ` Al Viro
2023-04-21 2:25 ` Al Viro
2023-03-14 22:07 ` [PATCH v18 10/15] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-03-14 22:07 ` [PATCH v18 11/15] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-03-14 22:07 ` [PATCH v18 12/15] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic David Howells
2023-03-14 22:07 ` [PATCH v18 13/15] block: Add BIO_PAGE_PINNED and associated infrastructure David Howells
2023-03-14 22:07 ` [PATCH v18 14/15] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-03-14 22:07 ` [PATCH v18 15/15] block: convert bio_map_user_iov " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whKPK=Bn_je2A19rSptpDo589DWxBJi8UQYS7sPjDPurw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=daniel@makrotopia.org \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=groeck7@gmail.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hdanton@sina.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox