From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A612C433EF for ; Wed, 15 Sep 2021 01:12:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 155246115B for ; Wed, 15 Sep 2021 01:12:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 155246115B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6BD3E6B0071; Tue, 14 Sep 2021 21:12:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66D1C6B0072; Tue, 14 Sep 2021 21:12:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55B50900002; Tue, 14 Sep 2021 21:12:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 435966B0071 for ; Tue, 14 Sep 2021 21:12:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E95F039479 for ; Wed, 15 Sep 2021 01:12:48 +0000 (UTC) X-FDA: 78588033216.10.F864FFA Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf18.hostedemail.com (Postfix) with ESMTP id A53694002087 for ; Wed, 15 Sep 2021 01:12:48 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id y28so2608080lfb.0 for ; Tue, 14 Sep 2021 18:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Sj/ckwgRXA0XAritZwn0IRH2Tpo7u3DEDmkQl8JG/xo=; b=dbyS/C0beUkomGpbcmoDo+smCOcStzW4H0jI3Ml2At5hCXRIFGbWz1pwwdjYLAlRYU A98CSjoWpuu43A8QWRL0clUNwdVGLaxezC4DJZvDV9Zk4jWFQqkrc736DsMLED34nzve mUTM6WMWh8zOvT8K26z4LgHYACeX/DfmT1ZHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sj/ckwgRXA0XAritZwn0IRH2Tpo7u3DEDmkQl8JG/xo=; b=bIhb7lmmMLqxAHa6R58j9kcRtJ2d5w9GK54ZU8hUAst00nQJh/PjzQh55skJTv+09b U+tRye685WCoN32EJLnXITfT+OrbAkyGva5irnD7jYhsNzoLAEbLG45/IrwOUttZQqzf gig2YSSQ8lUIC1Xh10JcpMTfOyH4keYMyvHyZf2xd8k8F+CiqantEy5U4n33FU3gJCSt gVWp32vE9DpN+Wi9Agxyy5puSJikkTE0Kopg8Xi8DNQZyzBU27M9q/druzkcKcX6N2Vq LdgS5iY3gseD2LNNOV0ukD729iWaDkNiIb5ZLYdc9xI9/n+4hi7kNHkHk5SGZgqvtqEV EuBA== X-Gm-Message-State: AOAM5309MJiyupHEBQ215p7GNhGK3Cnzz9iSwwPxC20eSUEUm+Bmg7ht cBEJH8gnm5Crc01dqatgGZRwa1gOwyMRD7jFuL8= X-Google-Smtp-Source: ABdhPJwadZcwT0w5OS8OpZm1w+1dBT56ji4LmRJl4pla3kUUMj08wpB3Xe+qU7j8Y7D/U9NXudZo0Q== X-Received: by 2002:a19:48d2:: with SMTP id v201mr15585735lfa.679.1631668366312; Tue, 14 Sep 2021 18:12:46 -0700 (PDT) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id q14sm109834lfc.152.2021.09.14.18.12.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 18:12:44 -0700 (PDT) Received: by mail-lf1-f47.google.com with SMTP id p29so2399620lfa.11 for ; Tue, 14 Sep 2021 18:12:44 -0700 (PDT) X-Received: by 2002:a19:ae15:: with SMTP id f21mr5676587lfc.402.1631668364073; Tue, 14 Sep 2021 18:12:44 -0700 (PDT) MIME-Version: 1.0 References: <163166717752.510331.12843735095061762373.stgit@devnote2> <163166718582.510331.11732633028925882626.stgit@devnote2> In-Reply-To: <163166718582.510331.11732633028925882626.stgit@devnote2> From: Linus Torvalds Date: Tue, 14 Sep 2021 18:12:28 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/5] bootconfig: Fix to check the xbc_node is used before free it To: Masami Hiramatsu Cc: Steven Rostedt , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="dbyS/C0b"; spf=pass (imf18.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Stat-Signature: d1y5cbdtcr63ji3unjwoh68ugrzfzn4e X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A53694002087 X-HE-Tag: 1631668368-17542 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 14, 2021 at 5:53 PM Masami Hiramatsu wrote: > > Fix to check the xbc_node is used before calling memblock_free() > because passing NULL to phys_addr() will cause a panic. No. That's the previous bad situation. The whole point of memblock_free_ptr() is that it actually acts the way a memory freeing function *should*, and has no problems with NULL pointers. > - Rebase on top of Linus tree. Please don't do a mindless rebase, take the actual changes into account. Linus