From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D54CC3DA4A for ; Fri, 26 Jul 2024 22:49:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5ADEA6B0082; Fri, 26 Jul 2024 18:49:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55DEC6B0083; Fri, 26 Jul 2024 18:49:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4263B6B0088; Fri, 26 Jul 2024 18:49:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 273576B0082 for ; Fri, 26 Jul 2024 18:49:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7326114014F for ; Fri, 26 Jul 2024 22:49:13 +0000 (UTC) X-FDA: 82383396186.21.9236BB0 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf20.hostedemail.com (Postfix) with ESMTP id 0F0931C0003 for ; Fri, 26 Jul 2024 22:49:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=c8qzkNHY; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722034101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L8kTffMeNEUYPqB8a6733WBTRK41FhXCH5cIS5+6SWc=; b=NOwaVYs//Xr7SMMe/E6vIy+au/BOSVj+ZQsrC4X7AM8MGGfJqo/ZNCfW0nmUmF37wIorzJ HyDoMUe/02HWpcwSkWmZHhdZKlaGzqmh/l0UY+xzpEe7sOY1cbe4YTyDv/tcGJ2VI+z1fF 0JUKv95/w9srbf/zvjcqB5zr08v09Hs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722034101; a=rsa-sha256; cv=none; b=K812LlxfEShuitCAtUDNO9oIq6drg0PRHz36n5PeZ/9oj0AMspyNjGYtkEM4uV9a68cZMF 1n3njGOdPLSchTOWb/oS1KG5aOB07Fgwx8I+DGMN+jhve5vDVMG42O6EjETRMNOBrEgPSG XDcy52xaX422/rHPC83HHp3IdIk6ggI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=c8qzkNHY; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52efc89dbedso2250198e87.3 for ; Fri, 26 Jul 2024 15:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722034149; x=1722638949; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L8kTffMeNEUYPqB8a6733WBTRK41FhXCH5cIS5+6SWc=; b=c8qzkNHYD4yWfSFrzoMDiR5W5jj6G404g7t98uwxCTR+TZKSo58PBULhNHy0lB80iv qyTabo03xsAo/mFRAXgzuk6q4CuNOse9VqSopC1YyIDWCey8GB8q5DPAXg8IXBS4ixnP OoTzzXbEBUfIC4uxiuEUOmN2MHH7fy4O916DA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722034149; x=1722638949; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L8kTffMeNEUYPqB8a6733WBTRK41FhXCH5cIS5+6SWc=; b=uqN2fqYDszQx6ZfOsqMMZbQK7jAAfDjNvhm5g4EZped7gBRUgaN/iBCs//Aq8J3c18 0ZAJDO3inBU4FYz8jg4bl8y6p92K+iO6XCAHEctobstyFwGQwNedxbzgjYwVgILu1Yl9 suxGlS9Ijw2zw4qm5rcuFusZ65xKFD8FVCFE7mU87EfmhP4FF53+DIIunGZ1YPLoiwMi 4ytinawGf+/LWIQLmOHHKvhVaTwcNU7qLIHsWofDKFd7Pb2/q5KZYnzdSvW1FFPOPv7z lALWnkRgjwd5NDcV/tmJOkPrOQRCwk+EO6O4qMeqJLKdpupk28MtQbrfQgYXEyaZ9vKu tlHg== X-Forwarded-Encrypted: i=1; AJvYcCXXRLx7NiPRmVrLZqprpdDUzCBZNnzanmUBnwnqsUEzAr0Qr1BIcEJoXItAsRWBWrJm/IpFET4Po8jEHTFie5i//+4= X-Gm-Message-State: AOJu0Yz9zXIOABz0UtoAnLX6/m9Spn5wmTWR2pvDsC5QMqUAcR9tkgbD cq841J1vAcrWzVxYgfAny2XwKqDrRRukXmnwygM1DOcznEk95VaWehM/jgqLjJPXiMP5RQ4LLWq bP//yQw== X-Google-Smtp-Source: AGHT+IFmP+0vEThLXQQpFt82w3UmPg2dJLs5mtdpzN7Xq6NKrXWEjaEEr2Sk3qj0HjDmw6qUSW7QQg== X-Received: by 2002:ac2:5b0c:0:b0:52c:d905:9645 with SMTP id 2adb3069b0e04-5309b279f82mr725494e87.13.1722034148650; Fri, 26 Jul 2024 15:49:08 -0700 (PDT) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52fd5bc42ecsm603578e87.49.2024.07.26.15.49.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 15:49:08 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52f01ec08d6so2636294e87.2 for ; Fri, 26 Jul 2024 15:49:07 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWWsK+EuWFqkjdZwcIPt8w+1895/HNtrcMONd9n9B+TdtY9br5b5ynu0niCg0XepoSZKtxRbsbBhNS5AHosagJ6e60= X-Received: by 2002:a19:690c:0:b0:52f:c2fa:b213 with SMTP id 2adb3069b0e04-5309b2d8a91mr630078e87.55.1722034147514; Fri, 26 Jul 2024 15:49:07 -0700 (PDT) MIME-Version: 1.0 References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> <137646a7-7017-490d-be78-5bd5627609c3@lucifer.local> <36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local> In-Reply-To: From: Linus Torvalds Date: Fri, 26 Jul 2024 15:48:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/7] minmax: reduce compilation time To: Lorenzo Stoakes , Jens Axboe Cc: David Laight , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0F0931C0003 X-Stat-Signature: 1ks17dju8ro9fi78i1in3gckxf3wwxdp X-HE-Tag: 1722034150-226933 X-HE-Meta: U2FsdGVkX19fLNXcKbmzOptx+htlmAk1A7rSo0XZbrM1qHd/vJAWR0yP95n2FwhoPlao8TG/3/Rwba9Bteu2H0pfeWkvfaPX1ThkcXMp8BaVgA4501pnQUNmVXtOeoQt4cUx2psKeYUxoSDBXDdWbMM1VyKBmO4VXjG3qmqYX7TtOYHM+Xo2n6fOjdGhQQ2DHPSQAF9jTiDQtboHRgN3MHCA2fSafHDZc/x2but8GUBgufNe8beTkqBZgisVWGkIKbhRyk1lIX/8jTjFfFzU66/CRxy9Z2k7EnkUg6Nf8OCL1YmVaDYEwNnkHgD4EtFkywz/QXoRyuNBw0Xk0QzjWi8ukq/N7w4pSRLcWfVw3TuNFQaIwQOy7buLk5tn1JI66SFyk8PAkT3mistp3+haWfHZ4yHhF+R3e09Kj7Oa9q1c3wH40U4N6BTSRKaHtVRNdXAp4/YYu772UF7eQE1Nq8O2GQ/Gn40/iYUTNnjTcyHIXeJzTsZv51fYfCs4qexsL5JPMJgOlCjzUifbkq6aS6Io0S0k/T5ekEoWZl9+mv0xh8phJvXkO3j0BDhl3zsI6oLmlCg2Cw1D0ePpTJPE9Dx1idZL4YuGrQT0/kIesufuBWpuG208/73jgrv2eBq/O4XVGAH66lmtFmO8ClZ3jCa6gEiNEVrT74kB+QQ4VYZhBgUezGl8CKn1co6rYq65udG0lXqoN5T4ZAvXU2qM71JPc9UwbbUaOrezmJ97r0JTCLx+ok6tB9zTmfWi+RO6QpIvpmgieT9OytHCqQXbTHftn2nobyOTLxepP0yDUTWaOYr1FUd7v9ZTuOsHZxZ8AUdwj63Sgc3pdq4aOPiNE0fgrpSs+YrBCbgnz+nHNPFlidc1AigO7acNDOXMeExZHLXYMQ4zcMM6otfLpKG7sCsZsUQdUDNUBKNA3mJkWJgSnZc/mZ/rye04h4mX0DrdnyjucLTQgSVMsTRIQOx gcQnYsJG 1jfeZrILnnJw2uUQWXPFeauhzBztJ+nJosb+gCp/v+cE84cXHKWkQ4IMeNewWsfblYmHS7Fw1fG6oGW/4axQqKh6BQwvZgX5Wk6hzPmYNlv2wdzpcgMjCEkaTHJeXOqa8qxZDPoYmXKW35kFPunXFkI9UWbbVYXTqHt/G5DvrAYXv4yMl9iN1UnTN+5Yqo2LRADHkC6FR7ZRhbqGTvVHKVM3xK1x6TRSAF7A3bk2dsq90WfO8ImB9C8kEYDQ3h0qkdmZdgT2j+t02LiPJGxxBQE9lobY2a6935tYXZlGV3M/yRrpiYAFkcbT11vU0a3t27rWlk7DACqNU70cNQ6KsCyGyyFstY59aQLymGKLZ/MIsnDCdDnJ3szPGXoLI5+xgHtY9qYnr7K7Z850PagCharry3b5Co3PqwvSrdGXF5NOXk+Yykclmi1vmDvrpDusPrUHx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 26 Jul 2024 at 14:36, Linus Torvalds wrote: > > LOL. At least some of that is because of 'pageblock_order', which > expands to 2.5kB of text [..] Ok, I pushed out my two fixes - one for the xen/setup.c case, and another for the ridiculous 'pageblock_order' expansion. They both looked obvious to me, and they definitely make for a notably smaller preprocessor noise load, but maybe I messed something up. I didn't even look at what the issue was with the bio_for_each_segment() expansion, in the hope that Jens will make that one look better. There are probably many other cases where we have these kinds of "tens of kB of macro expansion", I only looked at the xen case and the mm/compaction.c case based on Lorenzo's list of top offenders. Linus