From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: Linux-MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Kalesh Singh <kaleshsingh@google.com>,
Nick Piggin <npiggin@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Kirill A . Shutemov" <kirill@shutemov.name>
Subject: Re: [RFC PATCH 2/2] mm/mremap: Fix race between MOVE_PUD mremap and pageout
Date: Tue, 25 May 2021 07:28:39 -1000 [thread overview]
Message-ID: <CAHk-=whH4AxQ=84dPDtooDUS9PPLz0ar7YaEoE=qGoksBtuCng@mail.gmail.com> (raw)
In-Reply-To: <20210525083344.162377-2-aneesh.kumar@linux.ibm.com>
On Mon, May 24, 2021 at 10:34 PM Aneesh Kumar K.V
<aneesh.kumar@linux.ibm.com> wrote:
>
> @@ -221,6 +222,9 @@ static inline void page_vma_mapped_walk_done(struct page_vma_mapped_walk *pvmw)
> spin_unlock(pvmw->pte_ptl);
> if (pvmw->pmd_ptl)
> spin_unlock(pvmw->pmd_ptl);
> + if (pvmw->pud_ptl)
> + spin_unlock(pvmw->pud_ptl);
> +
> }
You have this habit of adding odd whitespace..
But yes, this seems to be the right way to fix the races properly. The
pageout code is special, the pageout code is normally not critical, so
it's the pageout code that should go the extra mile to make up for the
fact that it doesn't hold the mmap_sem like good page table
modification codepaths do.
Linus
prev parent reply other threads:[~2021-05-25 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 8:33 [RFC PATCH 1/2] mm/mremap: Fix race between MOVE_PMD " Aneesh Kumar K.V
2021-05-25 8:33 ` [RFC PATCH 2/2] mm/mremap: Fix race between MOVE_PUD " Aneesh Kumar K.V
2021-05-25 17:28 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whH4AxQ=84dPDtooDUS9PPLz0ar7YaEoE=qGoksBtuCng@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=joel@joelfernandes.org \
--cc=kaleshsingh@google.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox