From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F19C2BA19 for ; Sat, 11 Apr 2020 22:09:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B694F20708 for ; Sat, 11 Apr 2020 22:09:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="LWKhzNO/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B694F20708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 586198E00BB; Sat, 11 Apr 2020 18:09:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50F618E0007; Sat, 11 Apr 2020 18:09:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D6C78E00BB; Sat, 11 Apr 2020 18:09:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 2293B8E0007 for ; Sat, 11 Apr 2020 18:09:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DDC4C8248068 for ; Sat, 11 Apr 2020 22:09:54 +0000 (UTC) X-FDA: 76696967508.08.view33_90bba55948e14 X-HE-Tag: view33_90bba55948e14 X-Filterd-Recvd-Size: 3914 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Apr 2020 22:09:54 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id l11so3828700lfc.5 for ; Sat, 11 Apr 2020 15:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TETsvPIW3zFK7a+s4Xy+/EsP/ZIyd7MDAnh8kXDUPDY=; b=LWKhzNO/fmkN9AXIbh6BdMPSoUwuuc1JIQbspBQF8oSJHNi+9xPH2NDbM8dVz5Mzia O5Bv8VqXhUpaAfmywLN4z2mbstp/udAPbBebWk/RVBwyz93e9k0XSh0EtntzOz886wT6 HCLCmJBbcNFSByCMNpooPlQvhUTqF3YMn4tsQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TETsvPIW3zFK7a+s4Xy+/EsP/ZIyd7MDAnh8kXDUPDY=; b=dw6UlbzTkbQfItNvip2mr7a/CKZ7wAQR+0hbAmb2BX+yRCOg9D4wzispn2x1xzYugP DqcAblFDhwBDH+NPyL8JBEwk4JSBankuQI5IR8QhQtjONFGaGzt/vLwnA3jo/tfgZ6kB 1JpQUzJQxh4evxOMSRtLm9wBEEtoJbLUFMJjDFYNFDS6ZLquARF0vjuMD/U10uJAHP23 kypm1ZSZPXBz2BMMFOZ0RO9C3FIKkEWY7UQo5mkLFvpEfZI9jdJKpHDsA7bkVymK4J4c AoIvhXEJtXiwrXjj1MadRcQWq/qqSDDLqu1BRVhReqYX/ZqLNg1smUHyfgYw9sSM8SB3 jmfw== X-Gm-Message-State: AGi0PuaB/mDZ/hNHKOeHIOLsyHeGNL3snjNZaA/HaXG0ZCzD0NI7YW9c LrObvPxExyDgcjzhwb8QSx0oRcBSEfM= X-Google-Smtp-Source: APiQypIlyuYZS8NC4VxtvqbaJJZ8VDgz7R4oIwUUXzGUO3YfmWaFMyLDn/RUxbRzTNS9QV/7bYLpzQ== X-Received: by 2002:a19:5f4e:: with SMTP id a14mr5172898lfj.57.1586642992834; Sat, 11 Apr 2020 15:09:52 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id w27sm5751920lfn.45.2020.04.11.15.09.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Apr 2020 15:09:51 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id s13so3820476lfb.9 for ; Sat, 11 Apr 2020 15:09:51 -0700 (PDT) X-Received: by 2002:a19:9109:: with SMTP id t9mr6353420lfd.10.1586642991463; Sat, 11 Apr 2020 15:09:51 -0700 (PDT) MIME-Version: 1.0 References: <20200411203220.GG21484@bombadil.infradead.org> <20200411214818.GH21484@bombadil.infradead.org> <20200411220603.GI21484@bombadil.infradead.org> In-Reply-To: <20200411220603.GI21484@bombadil.infradead.org> From: Linus Torvalds Date: Sat, 11 Apr 2020 15:09:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Rename page_offset() to page_pos() To: Matthew Wilcox Cc: linux-fsdevel , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 11, 2020 at 3:06 PM Matthew Wilcox wrote: > > But we _have_ an offset_in_page() and it doesn't take a struct page > argument. .. it doesn't take a struct page argument because a struct page always has one compile-time fixed size. The only reason you seem to want to get the new interface is because you want to change that fact. So yes, you'd have to change the _existing_ offset_in_page() to take that extra "which page" argument. That's not confusing. Linus