From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1773C433EF for ; Sat, 6 Nov 2021 21:27:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 65D3861139 for ; Sat, 6 Nov 2021 21:27:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 65D3861139 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E02C66B006C; Sat, 6 Nov 2021 17:27:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8AFE6B00FF; Sat, 6 Nov 2021 17:27:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE1246B0100; Sat, 6 Nov 2021 17:27:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id AACA06B006C for ; Sat, 6 Nov 2021 17:27:00 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5E533768C1 for ; Sat, 6 Nov 2021 21:27:00 +0000 (UTC) X-FDA: 78779790726.05.DF11CF3 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf31.hostedemail.com (Postfix) with ESMTP id AFF7A104D192 for ; Sat, 6 Nov 2021 21:26:50 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id v15so14219201ljc.0 for ; Sat, 06 Nov 2021 14:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lCc3YeCdHo2e3Ru8bueGswsYqbOaxs0YN7dp3QCxbNg=; b=TVIImmQBvd2hjuDjBkJSLHFA0zJWF/WlwN/r8YPkn+HObyHYSGm9GJw5H6ectn8Js3 HdXOA/1bG5tyF2SUg0BLPYg4pPuz00xTveeHNezlP80YJw7JvMFrX/KJpwPfsw5nbZuI 4QxXMWouiGMQOzz2mAjQsGJUN9FP3yPNVagMw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lCc3YeCdHo2e3Ru8bueGswsYqbOaxs0YN7dp3QCxbNg=; b=UkS24CUPgdLTcnQcgNLzFSoSnKeBxGQnYiQ75QVsOS9RDw7xKez3ybA5oTnjeGeWNo 6Id00snrKrQmCCsGYRxT5huljVjh5brHCBe1Dsj4f231otH/R32uKxg2k8IP3E5wp43i 2t/IKIWXC/yfQ8WBDLn4IUJ+oNUocRESEuASqRO58Pc9x064+kb56WvuXPr+u1kiQRYw XDX3VgwT54rdcRRt+x67YWSoKU1QflWzRXwSUAny0/i5ENNf9qcvqPmFKYiR/p6suAhh RKGKiwz6dHP2Qxt5YKHyZQBUqz6/XfQpRd/2r9PEIlkU4him2Rjf42usAJfRQp863+JO P2Ww== X-Gm-Message-State: AOAM531P6lN0j5VjyHQ+GaI4FrUTc4HttpDVaIZDdhI3m1i536Ae/s6S 48Rz4aVuO8hoZ0tkgI5zPCiFkzldAm2x+msN24Q= X-Google-Smtp-Source: ABdhPJx4g3LDEVP3s7W5NZAdJ6R5WUWD4S0RkSGGdvFsd3I55ydaZXFDMssqjreTqoAsEteIaXpTOQ== X-Received: by 2002:a2e:9b42:: with SMTP id o2mr23796779ljj.262.1636234018184; Sat, 06 Nov 2021 14:26:58 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id e21sm191799ljl.82.2021.11.06.14.26.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Nov 2021 14:26:58 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id h11so21394507ljk.1 for ; Sat, 06 Nov 2021 14:26:57 -0700 (PDT) X-Received: by 2002:a19:ad0c:: with SMTP id t12mr62018562lfc.173.1636233658168; Sat, 06 Nov 2021 14:20:58 -0700 (PDT) MIME-Version: 1.0 References: <20211105133408.cccbb98b71a77d5e8430aba1@linux-foundation.org> <20211105204225.iIh99P9cn%akpm@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Sat, 6 Nov 2021 14:20:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 149/262] mm/vmscan: throttle reclaim until some writeback completes if congested To: Vlastimil Babka Cc: Matthew Wilcox , Andrew Morton , Andreas Dilger , Jonathan Corbet , Dave Chinner , "Darrick J. Wong" , Johannes Weiner , Linux-MM , Mel Gorman , Michal Hocko , mm-commits@vger.kernel.org, Neil Brown , Rik van Riel , "Theodore Ts'o" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AFF7A104D192 X-Stat-Signature: 14jf36prgwymgp4mchxg3bmtyeewf9e1 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TVIImmQB; dmarc=none; spf=pass (imf31.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.176 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-HE-Tag: 1636234010-158959 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 6, 2021 at 2:13 PM Vlastimil Babka wrote: > > If this needed resolution, didn't the resolution exist in -next already? Oh, I'm sure it was there in -next. But I just always do my own merge resolution anyway because I want to see what's going on. I don't look at other peoples resolutions, and I much prefer to actually look at the history itself in order to actually understand what the history and cause for the conflicts is (and what the proper resolution was). Of course, in many cases it's so trivial that there's not a lot to "understand", and most merge conflicts by far are not the kind that need a lot of thought. But just to clarify: I do actually like seeing people send their resolutions to me (possibly as an addendum to the pull request email, or possibly as a separate "resolved" branch). I don't use those to guide my resolution, but if there is any subtle issues at all, I will then compare the end results to verify that they agreed. Often any differences tend to be just whitespace or similar, but it can be interesting to see when there are meaningful semantic differences. Linus