From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2942C4727F for ; Fri, 25 Sep 2020 17:18:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2CE2F21741 for ; Fri, 25 Sep 2020 17:18:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ViM6tNtj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CE2F21741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5242E6B0068; Fri, 25 Sep 2020 13:18:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D4AD6B006C; Fri, 25 Sep 2020 13:18:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C5DE6B006E; Fri, 25 Sep 2020 13:18:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 260116B0068 for ; Fri, 25 Sep 2020 13:18:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DBBA88249980 for ; Fri, 25 Sep 2020 17:18:00 +0000 (UTC) X-FDA: 77302241520.29.fall57_3e00d7a27169 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id B290B180868FA for ; Fri, 25 Sep 2020 17:18:00 +0000 (UTC) X-HE-Tag: fall57_3e00d7a27169 X-Filterd-Recvd-Size: 5034 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Sep 2020 17:18:00 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id w11so3671919lfn.2 for ; Fri, 25 Sep 2020 10:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N+ANB8ObSSZ0LIy221HtUSCjieyuyM53ewN5x3+3DVE=; b=ViM6tNtjnjXKy+aig7vGCrWABYQxrnX2HtkZcN4CBEWw59xq/lePN1F/rj4bBZKD9U Ciyu/pPnZh+e6dHKrJngZsreQbcFBMQz0XY6cDFZ6Hru4Bqj/AL8F4fhKruS2mt+CqNQ pTRiIMYwAshLcNOYleRDc/4QZ26uCT/Hm942Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N+ANB8ObSSZ0LIy221HtUSCjieyuyM53ewN5x3+3DVE=; b=RPGxBlcyqEPVk2SAeWB2pqx8KlltSs+w6XuBk1Zzb2BcsuWvhA1xEQAgazsFbnpjjv V4JnsjlrFro+Wt8L4Nb3sFqJEF17E3yddpbaXLBB4Go+xqK52ucHCRilySn7O+OyAaQq HpQXIzevQtGJrcVl/MgZivLHIMnXrgt/+c1sOKqo9ykBdOGFQpWYjPY4PvqeWgQyyOz2 kpzorZWlUhuQdjS2QBTTGDpnksA+WMQUklfL7ebi0wCSpEmOKezlbjqPeXnQSvjUllCH VwRzziiiJaydFGsUH9hRyAVOFR7VQnTOlZGiwhuMPvQrp6qbJtgtSpeycAjgIbEbbVCd yWfg== X-Gm-Message-State: AOAM5331p+XeGoG7UQDzpocZ+nkKVAxGh9l3JCDuwDzJoY0Ubp24HUSt pDmcBNqQz1eO3hieA9zJAPXJIhTHa1beGQ== X-Google-Smtp-Source: ABdhPJwhpIO4Um8wI9nI+IVjfgWQDRhGsstyPTDEotLr+gzu7ZD+7X+D/FgLSOpuS4DZk7htKnzzdg== X-Received: by 2002:a19:cb96:: with SMTP id b144mr1882803lfg.143.1601054277926; Fri, 25 Sep 2020 10:17:57 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id a8sm2734983lfl.186.2020.09.25.10.17.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 10:17:53 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id u8so3670132lff.1 for ; Fri, 25 Sep 2020 10:17:52 -0700 (PDT) X-Received: by 2002:ac2:5594:: with SMTP id v20mr1832306lfg.344.1601054272350; Fri, 25 Sep 2020 10:17:52 -0700 (PDT) MIME-Version: 1.0 References: <20200915073303.GA754106@T590> <20200915224541.GB38283@mit.edu> <20200915230941.GA791425@T590> <20200916202026.GC38283@mit.edu> <20200917022051.GA1004828@T590> <20200917143012.GF38283@mit.edu> <20200924005901.GB1806978@T590> <20200924143345.GD482521@mit.edu> <20200925011311.GJ482521@mit.edu> <20200925073145.GC2388140@T590> <20200925161918.GD2388140@T590> In-Reply-To: <20200925161918.GD2388140@T590> From: Linus Torvalds Date: Fri, 25 Sep 2020 10:17:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag To: Ming Lei Cc: "Theodore Y. Ts'o" , Jens Axboe , Ext4 Developers List , "linux-kernel@vger.kernel.org" , linux-block , Linux-MM , Roman Gushchin , Andrew Morton , Johannes Weiner , Vlastimil Babka , Shakeel Butt Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > git bisect shows the first bad commit: > > [10befea91b61c4e2c2d1df06a2e978d182fcf792] mm: memcg/slab: use a single set of > kmem_caches for all allocations > > And I have double checked that the above commit is really the first bad > commit for the list corruption issue of 'list_del corruption, ffffe1c241b00408->next > is LIST_POISON1 (dead000000000100)', Thet commit doesn't revert cleanly, but I think that's purely because we'd also need to revert 849504809f86 ("mm: memcg/slab: remove unused argument by charge_slab_page()") 74d555bed5d0 ("mm: slab: rename (un)charge_slab_page() to (un)account_slab_page()") too. Can you verify that a git revert 74d555bed5d0 849504809f86 10befea91b61 on top of current -git makes things work for you again? I'm going to do an rc8 this release simply because we have another VM issue that I hope to get fixed - but there we know what the problem and the fix _is_, it just needs some care. So if Roman (or somebody else) can see what's wrong and we can fix this quickly, we don't need to go down the revert path, but .. Linus