From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4028EC6379F for ; Fri, 24 Feb 2023 01:34:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FDEF6B0073; Thu, 23 Feb 2023 20:34:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AEA36B0074; Thu, 23 Feb 2023 20:34:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 675DF6B0075; Thu, 23 Feb 2023 20:34:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 576046B0073 for ; Thu, 23 Feb 2023 20:34:00 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2494581071 for ; Fri, 24 Feb 2023 01:34:00 +0000 (UTC) X-FDA: 80500464240.07.1ECD292 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf30.hostedemail.com (Postfix) with ESMTP id DF4548000F for ; Fri, 24 Feb 2023 01:33:57 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=NsTxMu91; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677202438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ymzGFsmWya6beQpPK0i2hFaBLxyxKs7ybs+4Ujx9o08=; b=vA9iVis/xIJWSbuopYDBSa2G3/PEo4ijS/dwmV+ukqIi+AwaZHnbP/HIyElYBXp3v//VvR /xIRjFWy7vMASEQD5Kl+hoFmEyfaknn0arfnUgg8GIt31KhtdEZq+Yecwc7Dk3ibC3IhZB KkStow3TuCZoRLUHvkhHfgvEsVEitdM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=NsTxMu91; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677202438; a=rsa-sha256; cv=none; b=V53hUnC7z5TD+nIzRm8k111fE4kS5mHw11WVsh4LUB0ro4FJisTviUfw34Xaf0AfN2ODYz tLjyqmPQVCujeMM85E/TJSSkoWEFXD+lMBkLxoGKxvRKKbF6nWCJXOO0Gr1sF2A5WHqajQ iYmPqvIFbZrbbag+S3LGvcRexlAJXs4= Received: by mail-ed1-f52.google.com with SMTP id x10so48364271edd.13 for ; Thu, 23 Feb 2023 17:33:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ymzGFsmWya6beQpPK0i2hFaBLxyxKs7ybs+4Ujx9o08=; b=NsTxMu91loRThYoVGXFnM1XQ6n7iZETYV2DEh33EWoE15bp7NJWrtEXVpY0Rgsg7Sp LnJ2qOiHjWOr23v7VHuhjP9/UNu+4HIaRK604xjFVXvMp6MZw3aDF9OlbfLeAoPOzaxW 03/jDGV57fRr3MShW//nWjDkbPz7ix5RXbCaA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ymzGFsmWya6beQpPK0i2hFaBLxyxKs7ybs+4Ujx9o08=; b=GfX6qU14qaa+3VLCSzODZ5y5CQ9lJJHqUh9Qux1LU1uYgc+BqH9yaYbk4p8BwGT/8S LNcnDErrjA4VWmf0KKTM7baThVBruAnNcctR/fE/g8Xy7GffnW3s+2iajCDkveRoUhWb 6TWaXCTQshRgrv07oDc9FH1OxWIes5qbvF9AaFwSLrvbzU2daIF+cLMKk3DZHU+U/fOu 2UCed1WTNr9Cbendg3UFsE9dE10rIut7Rj4OBllaU30mcxR7D0rg6OS/MpX+lTXeMLkX MCmkFESrL9s6kUf26abLmjDrQUR3EgKZuJeOCqTLAoXvFDdISq87E6e79s2uoK4TlC/8 /nJg== X-Gm-Message-State: AO0yUKW+U1LNDerbXyj/4dG7Wjwky+5NwKq/lnzHOmCsR56oHbcZYURY 1Cg0GlBoIEZBfKMc2hWdXWrHVK0G1tZQxVGnjeWBuQ== X-Google-Smtp-Source: AK7set+em6yqkbif8PNuTvv+5CHxr4ZbcI7+bcJz5YOoONquWHCoCORgvr8GOzg18OSNw2PMfWvLCA== X-Received: by 2002:a17:906:b2ca:b0:878:673f:5492 with SMTP id cf10-20020a170906b2ca00b00878673f5492mr21011028ejb.40.1677202436000; Thu, 23 Feb 2023 17:33:56 -0800 (PST) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com. [209.85.208.45]) by smtp.gmail.com with ESMTPSA id bl11-20020a170906c24b00b008f0143dfa65sm957688ejb.27.2023.02.23.17.33.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 17:33:55 -0800 (PST) Received: by mail-ed1-f45.google.com with SMTP id ec43so48630419edb.8 for ; Thu, 23 Feb 2023 17:33:54 -0800 (PST) X-Received: by 2002:a17:906:40cc:b0:877:747d:4a82 with SMTP id a12-20020a17090640cc00b00877747d4a82mr10458388ejk.0.1677202434537; Thu, 23 Feb 2023 17:33:54 -0800 (PST) MIME-Version: 1.0 References: <20230220135225.91b0f28344c01d5306c31230@linux-foundation.org> In-Reply-To: <20230220135225.91b0f28344c01d5306c31230@linux-foundation.org> From: Linus Torvalds Date: Thu, 23 Feb 2023 17:33:37 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] MM updates for 6.3-rc1 To: Andrew Morton , Jan Kara , Vishal Moola , Paulo Alcantara , Matthew Wilcox , David Howells , Steve French , Huang Ying , Baolin Wang , Xin Hao Cc: linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DF4548000F X-Stat-Signature: 1xus9cie7gndg7nqjunqtgsntf3sr8sk X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677202437-476095 X-HE-Meta: U2FsdGVkX18ykhuHcrteCzVBYm5le4tIFMsEYZYR0LdDLn+GULpMF1gkXZkCNE92nzagMAeB6culjIgqVHK534wjTsAZD8kV1txFn+bzvkhVU88MbQ0m0HX9z8ZX8sLAuxtztzm4l3eNukw5yZyZFSPL+D1QWQ9WNUqkqOffqQcBWuDoUy7aJ6Gb9tB4sI/xS0gGAYhz1qyek1nTvpLj31C0bN6j89k5+mfMmPUGKlO045nWj3ooqAlEDj0D+qJ9VYlZIU0+hRRGLthUG5KdnEHNR+mSc6ChYDzPhwLcVOUX1FBZMKpaNkYcsfugX9ufiQ+sG9KcrmPsI0lfii2EP6zwVy+ZnToWr0JWqEtm69twh2fqcDFENdM0e5fUScIL6obtWLvRLRVASbKUFKB4sq9dXNbAOw4jORiwTWDiAoDfUQ9ZWSmNQ/Iz0uwOR99sEHH2Gra9TfAQg9HYMBL9Idm2OtEsJyhKaPHZe1du6nqpzlEkMHNhKSMFYaMxyp/jEyAkpqhgG/1qUJLiPNSEtn9OWj2a+PcOmxgmu8ZDFT/PHy3X4lCB/DVYHZGeiBRb5aRPZ7WRYGmn8mrhbs03LBKwqr+eS91ym9UEzb3GMqHJHAIWfoAJcdiQD9Km7qVkHxuNQUw7PmnO6lVP2tpVgj0c5Uvu5La7mDHintRgfM8fwhbash/Zm227q+YJliw3Hd16Mhd5jT1GA/YDGQgH73NAW+8iu0kRqqF8npTZUrg/PKaAUjRcM6qhk/rDrIOBrvS9pJorcPMFRx3wHU62bhKHRseVpVpeBphPEDmsWG41YTCF7HMojfrMqnFuX2xvCMgdv+iSWGqrQCYWjf8zzTNNI1zcQtRoKELaGelmNR8vCtJxmWAB/JiHgiGvr5MliP8rN4UDJCZ4RWAWiJriu3kYS4RPcdlCA8BU60qdsiyCTH89v+Ta6/dRzFL9nwB9b47frcF4ruPh+4S+9yq ++npD2ea I6W37eIhRtxwM+lLWZUgRKRrtZAITbl/wdL6eMq6yW4tLqQuspqzdqAWNQYdef9qQF0xbU4MQrhocTS0fg9r9xpTZvvON4riFZ1XWhW0w7P55NOEnTCRbCqWm42XRKQfxCLV8cIolIUS83MrjTPr7nSR5NfeKhvIpc1nLfeygiTq9mlRaNKhaGcIrpQxSoLGwHbtcvynztytEH8jzyTnZF3UguH3YJ/clasWtBAlCYMOdxMSypQftNt+cAvVUicEXM6k/jjPuEnmP2Csmd2RVcNAOlVsOdyJ0VJuEPfwGDMYcXC10DnA6u5tkBOy+Okeu7IUxDCTwpTVe0hBCixwy6L/Mn1VOZ9H6xa4j5Zk3u3YEd0ZUjlhFaHll7hbxOI7EU2qkkbceuHMw3HVR9uZABEpRRhdRu0DsPKYyek4RSgX6Ebx0Zddj61AKTDHGFagbDEx0fZExqfjxoDqRT6xOnpuqfgomksjl/hLtmxcUQwIE8iW2PGrtIagAoK1kfvbpRZb7+sOX5ZuQdMm97zqpiHWOivQrh5kxrbaqMnp2tL1JZEYJYRB3yMhLkdFaLb9v0yi3l3q5dQ1HiLE1XTZRrbbs2GbuhnYRBts0StnSoHYrj8m5oCgdK5P9P7FQQLlPx4pDWcmPt6wHDk84G5hE9yTbCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 20, 2023 at 1:52 PM Andrew Morton w= rote: > > Linus, please merge this cycle's MM updates. Ok, finally got around to this one, and I am not thrilled about it. A few notes: - my fs/udf/inode.c is "minimal". Ugly, ugly, I think udf_adinicb_writepage() should just be made to actually deal with folios inherently, but I did *NOT* do that, and just did struct page *page =3D &folio->page; at the top, and left it at that. I'm not proud of it, but I hope Jan might want to do this properly. That conflict wasn't mentioned, and now I wonder if the UDF changes were in -next at all? - the fs/cifs/file.c conflict was a nightmare. Yes, I saw David Howells resolution suggestion. I think that one was buggy. It would wait for a page under writeback, and then go on to the *next* one without writing it back. I don't thin kthat was right. That said, I'm not at all convinced my version is right either. I can't test it, and that means I probably messed up. It looked sane to me when I did it, and it builds cleanly, but I honestly doubt myself. I think that code should probably use xas_for_each_marked(), but instead I kept the old model, added a loop like DavidH did, and then munged the end result until I thought it was palatable. NOTE! Don't even try to look at the conflict diff. It makes no sense at all. But somebody (I'd hope all of DavidH, SteveF and Willy) should really take a look at my end result. - gcc 12.2.1 quite reasonable complains about some of the new MM code: mm/migrate.c: In function =E2=80=98__migrate_folio_extract=E2=80=99: mm/migrate.c:1050:20: note: randstruct: casting between randomized structure pointer types (ssa): =E2=80=98struct anon_vma=E2=80=99 and =E2=80= =98struct address_space=E2=80=99 1050 | *anon_vmap =3D (void *)dst->mapping; | ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ and while this doesn't cause a build failure ("note" is different from "warning"), I do think something needs to be done. Gcc is right. This code seems to *work* simply because it's intentionally mis-casting pointers, but I think it needs to be seriously looked at and something done to make gcc happy (and a *LARGE* comment about it). That last note is not some merge result, it's purely about the new MM code. Anyway, the merge is done and pushed out, I just am not very confident about the end result at all. That cifs thing really needs somebody competent looking at it. I think I went through three different iterations of my resolution before I was happy with my approach, and "happy" may end up being more about having exhausted my will to live, than about the end result actually being any good. I saw some noise about ext4 being a nightmare too, but I haven't gotten that pull request yet. I'll tackle the non-MM pull next, but I'm taking a break first. Alcohol may have to be involved. Linus