From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B88CC2BA15 for ; Tue, 18 Jun 2024 21:40:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E7AE8D0069; Tue, 18 Jun 2024 17:40:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 295CA8D0066; Tue, 18 Jun 2024 17:40:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15D1F8D0069; Tue, 18 Jun 2024 17:40:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E735B8D0066 for ; Tue, 18 Jun 2024 17:40:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8FF68A2CAB for ; Tue, 18 Jun 2024 21:40:31 +0000 (UTC) X-FDA: 82245328662.22.B65FA5A Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf19.hostedemail.com (Postfix) with ESMTP id 4B61B1A000C for ; Tue, 18 Jun 2024 21:40:29 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=CXl8Kb1z; dmarc=none; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718746824; a=rsa-sha256; cv=none; b=8HaufxSTfLxnj1gYmHYOAXn2r/VzURre7nSxyfCdy10kUprusTD4RZazgFpovZJaDs/AMj gmi9XHL1bVBL6j6z3J5cXhl0Zx++ORXxnnXvamUt1UUgUtxAsx8ZWxs5v1nSBbN8EOK/wT /KLSD3+Ehx4Qq7d5K164PdTW2BBEx3c= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=CXl8Kb1z; dmarc=none; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718746824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t2sFsCkBK5Jgj2XfBETPiTRynBfNBU9KxoV9zhHNOLk=; b=Nn5dxoDRZ8QbRrta6RL10MwftrlSO+foNXIjIZAK0kpWEjo3WNRI4aR9DJ6b4zcyAOg/y1 J/wtdv3K690joSoTM5DUofRmGHIErrNywDH+HqaKukDWBQVJP8RtG14JV8G52zu6HC3HkY a9XShOVEabmGoYmS52HxGeu9KUZQdWc= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-57c7ec8f1fcso7091321a12.0 for ; Tue, 18 Jun 2024 14:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1718746827; x=1719351627; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=t2sFsCkBK5Jgj2XfBETPiTRynBfNBU9KxoV9zhHNOLk=; b=CXl8Kb1z6JaTkVDya6jrjy5IIa2usVLuOfNpKUDexZcghLEPaLa7/O5HQtw7XkPUAb M8v2BHsjryVH0fB0qq2fmAgzcBIBn3itMf1Q/oafu6+rZ3shm2Z+uyLH1n+2LpMbG39r kLznNRJV6Aq5ysGmyatbUSCoUGDB1aTZRgHdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718746827; x=1719351627; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t2sFsCkBK5Jgj2XfBETPiTRynBfNBU9KxoV9zhHNOLk=; b=KgY3DYHLH3QzgEA0HzKV9Xkxh0BbXcGdwbLRSl4rQqk6cfXDj8M331y0518tw9oK63 pjKE79NxxmdmAWKyP3eX2Nfoqc2fzIbXKSXbYYPrdOxaiMST5+4cw/acEUKsxK2IQJHI u/ps9JgeRY9XOo1WbHd71ELo6wdErkc2oID/9WLz5bEYY+GgbXKqhHizUfkNZQqfEuSK EyH6987Jru6oWtM79xhf248eQOk0HgzT3lYRjAmhQNmQb6rqCU0YCMObc/3Y3m4Amui1 Ma+tu3AK47bQSQxIhx1JI0O3R6FKsjzYO9K3E/O4efKXpEwLFI4h9PF4hm03bTwNS2lA UmFg== X-Forwarded-Encrypted: i=1; AJvYcCVjoMu7bZqm6OOyzwVBRCdnZW6hJkYeVI7kzuGRextH1IGhiCn5SKbYUi4W8KWp3XfRtlWV7yEs7xFyWDGRP1TFBNg= X-Gm-Message-State: AOJu0Yz96E2/pWNPZ2wO9gHM0z2Hfgm/FaqOU+x5ytzS1jKgoXBczA5m m/NtABgfmwvtU/7oFg9hjhEkhRT5zg95Yg7lRRXq7UFMPN3l0VzAh/H7g0l9AAPWCLKlMav7q9D bOJ8= X-Google-Smtp-Source: AGHT+IGBpI0o/4+vrGKdHFwc6wa/SdBBaEArMszC4GSLboUE+LlRI+CBIJ4H4WirNGC5y/gTxoVsoQ== X-Received: by 2002:a17:907:6196:b0:a6f:5adc:6533 with SMTP id a640c23a62f3a-a6fab648c2dmr31143366b.46.1718746827155; Tue, 18 Jun 2024 14:40:27 -0700 (PDT) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com. [209.85.218.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f8cc20663sm187648166b.190.2024.06.18.14.40.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jun 2024 14:40:26 -0700 (PDT) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a6f09eaf420so706109566b.3 for ; Tue, 18 Jun 2024 14:40:26 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUAYaUt6E5OLCQk+/se+P7yfbecGhyfPvl5/gDRJNG0cFeT3eh/Z8n30I7PnM8+4rsQhD9eELNrha/hqSMcclMuOto= X-Received: by 2002:a17:906:6d08:b0:a6f:e4f:65ff with SMTP id a640c23a62f3a-a6fab7dda71mr36334866b.76.1718746826235; Tue, 18 Jun 2024 14:40:26 -0700 (PDT) MIME-Version: 1.0 References: <20240618213421.282381-1-shakeel.butt@linux.dev> In-Reply-To: <20240618213421.282381-1-shakeel.butt@linux.dev> From: Linus Torvalds Date: Tue, 18 Jun 2024 14:40:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: ratelimit oversized kvmalloc warnings instead of once To: Shakeel Butt Cc: Andrew Morton , Michal Hocko , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kyle McMartin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4B61B1A000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3jhbg8ajwaspc46nb74rf75ynjce1p3t X-HE-Tag: 1718746829-141158 X-HE-Meta: U2FsdGVkX18JGjLlDeC21uJsM6gM0X/KtVEQAw7hNy0Bm/B7YE2BEJ3Dg1SVIOLaK4fmh9X98dTm7C94t0sp054RuaXQAtf+sQNoneWCQtE9V2WEvp8z/4FVq2znF0wO3+PZ5Tnu7flwK44s/xeGPxM6zQOeNtxRTIzBD3/+o+DxlwGWD8YYWo9+46ZAAUivY5toKeUpP0ZUqRKLH31YHhc0xPgwPE2XUIC3+9qGBnRGKFq3Qdj16Nn2B7JE87W60N/7shHva9PIZ52IeujP46JKXyqOIF9TLt4ffaDT1sp2cI+Q8/X/WJWHs8Tv4s9vfmTgRZrxXST8RilvWiozD7wE34LmC/9mrfuAV9oHQJcXyaa3wtuey0/3d1SJ56x6WlAuB0L8gdIYQDB0MVrVWGyiFjVINPEJOeWrR+OuOipgCNZ5Zwsi1h09moOIpVNlxeBIFy8etoMoEm+WkZLDqAflLtWI7TzHhwq8PDi/XYfgL+R1mE5n1IG/WcBowtUE6+18ikQDaqkdMjmlA+IRIUEIi4zYyd2FsllloIzoem8azyn8TUi42SqFAmic+RWQoyAp+oTO1f269Rf4xmQ/JDpM64wwnpuzSC6wSNDWRK1A1IpDBJOlwPfXXXmN29t2/MfjJEq34lROCBTsPhuG+Fccjha3RuXwjkHYtmfLbn5NBl7q8bnZUtVb/DHBVbWXhcCY3LRwTgawEUrQD6x2QZJ29gf0fJuzFuG5lvkre3nSbygMKyzRZ7/ra1W1zRuC9WGVGM0V/7OK4ndhCx0sb/MPJaJ+jvXlr1PxZg1JingIQwsMj4N3wJFoR+m7yGqLILAg62h8UGohtMnP5+hGJCVMjssDL33uZekUjoB6smkm/M30fytL5OYi+rAZ28A8vMDz5HDvLv2qjIsve8/bN2iwh9QyXVnVt2BJmujhBsItybzz/MLX+syI4mIPHChmzomF88IbT/LuY9Dgz0x VZVkHKRR H+UWaoRZoIqNyN6octKxo2FSMYvFTL7EBZoAsbcPZCQFvPKevzeQbEoELOBY3OOEYm2ClCvUVT4Nj8j2H9DEssEiA8c2GAp+SnrAvC0r5rQpLgQXlJJKan7qLhEdF2Z8SC1PrdX/9FtucESAGXSC8+zboUoUaC2reToK10hWkFkiTg3wO4bKSmKqiGhszTyBXFoBTlZ11DJvOegYZWFZN/YMFS3rHO+wbbdymx7JYepo07kuMG1ZZW5P6cVASwQTYqr9k/N2nVDzcgMtYqDEJ3q21qrqhiI6TzMuV9BhBNPAjDIboeMt4uWGDH53GgJzKQYopT5+fJGIsVj2bTaQ3ROo31mUNpuzZrZjLINKPHRTvQ1NIFUfmhWW9y48xcU506hWf5vrUmDmH2MgGZNHVBam1EDwLtZTe98AiN68v8MY/L5nEIml5Zo4Zt6uj9lXb4vUxgB6Tl6XDVBs8/Nvuww7ecqMi9QzP02SISsHhVfim0d4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 18 Jun 2024 at 14:34, Shakeel Butt wrote: > > Simply replace WARN_ON_ONCE with WARN_RATELIMIT. NAK. Sadly, the RATELIMIT cases are useless. The normal rate limiting is basically "burst of up to ten, every five seconds". That's going to completely swamp things and hide any other issue. If we ratelimit it to "at most 1 per hour", maybe something like that would be acceptable. But honestly, I do not understand your "first abuser only" complaint. There should not be *any* abusers. So just fix that first one already. If you have more than one, you have bigger issues. So what is the real reason for this broken patch? Why didn't you fix the first one? Linus