From: Linus Torvalds <torvalds@linux-foundation.org>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
kernel-team@meta.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Kyle McMartin <kyle@infradead.org>
Subject: Re: [PATCH] mm: ratelimit oversized kvmalloc warnings instead of once
Date: Tue, 18 Jun 2024 14:40:10 -0700 [thread overview]
Message-ID: <CAHk-=wh97fGxpyzKTUCrug_uhrLHJHh5W4wLbLkZ9cJSFh7RHQ@mail.gmail.com> (raw)
In-Reply-To: <20240618213421.282381-1-shakeel.butt@linux.dev>
On Tue, 18 Jun 2024 at 14:34, Shakeel Butt <shakeel.butt@linux.dev> wrote:
>
> Simply replace WARN_ON_ONCE with WARN_RATELIMIT.
NAK.
Sadly, the RATELIMIT cases are useless.
The normal rate limiting is basically "burst of up to ten, every five seconds".
That's going to completely swamp things and hide any other issue.
If we ratelimit it to "at most 1 per hour", maybe something like that
would be acceptable.
But honestly, I do not understand your "first abuser only" complaint.
There should not be *any* abusers. So just fix that first one already.
If you have more than one, you have bigger issues. So what is the real
reason for this broken patch? Why didn't you fix the first one?
Linus
next prev parent reply other threads:[~2024-06-18 21:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 21:34 Shakeel Butt
2024-06-18 21:40 ` Linus Torvalds [this message]
2024-06-18 21:44 ` Shakeel Butt
2024-06-19 7:19 ` Michal Hocko
2024-06-19 8:03 ` Shakeel Butt
2024-06-19 8:30 ` Michal Hocko
2024-06-19 8:37 ` Shakeel Butt
2024-06-19 8:48 ` Michal Hocko
2024-06-19 17:47 ` Shakeel Butt
2024-06-19 19:30 ` Linus Torvalds
2024-06-19 19:54 ` Michal Hocko
2024-06-19 12:49 ` Mateusz Guzik
2024-06-19 12:51 ` Mateusz Guzik
2024-06-19 17:52 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh97fGxpyzKTUCrug_uhrLHJHh5W4wLbLkZ9cJSFh7RHQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@meta.com \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox