From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9391C7EE29 for ; Mon, 29 May 2023 11:00:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CA4A900003; Mon, 29 May 2023 07:00:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 252F2900002; Mon, 29 May 2023 07:00:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CD80900003; Mon, 29 May 2023 07:00:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ECD7D900002 for ; Mon, 29 May 2023 07:00:48 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8FC6FA02A7 for ; Mon, 29 May 2023 11:00:48 +0000 (UTC) X-FDA: 80842999776.26.A4683AA Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf05.hostedemail.com (Postfix) with ESMTP id 5D587100011 for ; Mon, 29 May 2023 11:00:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=OiywrWMO; dmarc=none; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685358046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=83jhJNkWMwv2xEBpts8kpySt/1KhQx2X32FHoz9hyjw=; b=salIm9mNGZgJnQIP2wUPvOgFqAgwLyqzskkJ0Jz6qXeso4m94viMh3auUDwvIdLp9TtAcY i0ZdoyuUXPZThjwj972mG49OKXl2nPKUU+l38y1lbM4RYYfWWyZYz0Nt2qV78QIge+eby5 7Kvs5vZtGLP19nuYbDzmYQLO1bjw+hE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=OiywrWMO; dmarc=none; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685358046; a=rsa-sha256; cv=none; b=RoQh0crUXILTjas6xJzLzlV2F1E0i97//dfDTgnfFaxHdxDASBkMo+YpgKX77i3mf7KUEk MdRTVBviG7DQCJqIavybkKajRevjJo1kaSaSGB9azJy/BuPLARQzCE2kLScgTdLdHfwfkV u8M0eHMaj2WtQ+ho9riMZVJqS8nN72k= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-96f7bf3cf9eso627082466b.0 for ; Mon, 29 May 2023 04:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1685358044; x=1687950044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=83jhJNkWMwv2xEBpts8kpySt/1KhQx2X32FHoz9hyjw=; b=OiywrWMOeb+v9DQlE73IRz4YdmiFzkEjsLqXxqF+F9y7IKE4qFJTapiPBXidk5yslL AwlISE/uUvhlbnnWkWaB9w4yfQe+J9tNL/c3DmH8Xwt2Oj0VIFswUdpQgvAqDiPRBULI 5+bREM9vA9B9Ln0sZ8mvpvMKlxqNULZ2XoSWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685358044; x=1687950044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=83jhJNkWMwv2xEBpts8kpySt/1KhQx2X32FHoz9hyjw=; b=bAcjOROy7/oh9Vd+i4kbvRkKysVpbY2iRByOj235cdW0c9+9bVHWMhsmfkpt4ZiGuq ATIEqnFLxgotAo/8GO/9yCYzu+IEKS/TFB4SmmCc2KbUYWc6d9WvVobnmRIb1Q2ZNTdS UMQd+ea3u7QEDkmncD4em7GxpCoMbt+SQSCaG6oigxhBxYFaCdK1yHbTNwHll8OJMiWZ f1U05ycp/lmoShl5iBPUWdSQ3Dam1j2+dD0JDSMSwx38ieoFsLcSzyl1Z0d7V5Pv/v6N XwJNaC8DGziCxfhs6KZgQ93MyawxcgRMeZ18P7ohmkA6iDEZohZPJOakv92sL05eDDkr oL7Q== X-Gm-Message-State: AC+VfDzU7Wn9cir4W4oUlcIBeBFUjY3qxAoMNketBJ8AvzSWwvVTv+Xi wxXVSm0omx6tGynEj8dWu04KQo7E1S1h9boiwKTn24yd X-Google-Smtp-Source: ACHHUZ77acBp3wbQDsLrnw0vutPdoLw84+O3SVUpqbHE7a2d9TjBgZPAYk3GRyHgtckE64ly8/Y8pA== X-Received: by 2002:a17:906:58c4:b0:961:78c2:1d27 with SMTP id e4-20020a17090658c400b0096178c21d27mr10693176ejs.19.1685358044486; Mon, 29 May 2023 04:00:44 -0700 (PDT) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com. [209.85.218.43]) by smtp.gmail.com with ESMTPSA id bh1-20020a170906a0c100b0094f44bdf7acsm5779994ejb.57.2023.05.29.04.00.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 May 2023 04:00:44 -0700 (PDT) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-96f850b32caso622992266b.3 for ; Mon, 29 May 2023 04:00:44 -0700 (PDT) X-Received: by 2002:a17:907:987:b0:96a:6723:da47 with SMTP id bf7-20020a170907098700b0096a6723da47mr9992607ejc.43.1685358023375; Mon, 29 May 2023 04:00:23 -0700 (PDT) MIME-Version: 1.0 References: <20230524213620.3509138-1-mcgrof@kernel.org> <20230524213620.3509138-3-mcgrof@kernel.org> <8fc5b26b-d2f6-0c8f-34a1-af085dbef155@suse.com> <6gwjomw6sxxmlglxfoilelswv4hgygqelomevb4k4wrlrk3gtm@wrakbmwztgeu> In-Reply-To: From: Linus Torvalds Date: Mon, 29 May 2023 07:00:05 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] module: add support to avoid duplicates early on load To: Johan Hovold Cc: Luis Chamberlain , Lucas De Marchi , Petr Pavlu , gregkh@linuxfoundation.org, rafael@kernel.org, song@kernel.org, lucas.de.marchi@gmail.com, christophe.leroy@csgroup.eu, peterz@infradead.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, yujie.liu@intel.com, david@redhat.com, tglx@linutronix.de, hch@lst.de, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, prarit@redhat.com, lennart@poettering.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: kog6ksy6c5skcwpm86huaxt9s4uhhae8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5D587100011 X-HE-Tag: 1685358046-926830 X-HE-Meta: U2FsdGVkX18NnCf7zB8boSrfke+6oBnUJdzgxx4oa5BSRxHLtPdbETEZzaOr+fr3Jdtz7s4dWxdfAMXHac9BUEFaVJbNGBoJYymhdQtm8hByqAIHgJx6mSxmz1vloil9yVwMLnIccl+q1QJphRvoNi/b/+Q8Hp1vFavKvMVaGLQ7gcBlleKEKvvT56QfLSxRwKt12eVYBUTFeMEw3xfhi1TtI8rIZNgj6O850slRCdlHRYsOwBt/gHbHjnt9BypS9D9cXXJf/WtNhXpgWw7USNDHIWh8z2QoSmG7TMdQc62Yj+JKQL06zHTS5iKhnsoUNA/XRyo211PNldu/dHIXn0MvR0xOtz/ewFpXfimlWU/2+B63ZMAmRzvorfN8LDS/+cIqO0y8hKgA/fe3PmKUAFinHJW7DksqliNbs6TOE3RbiV7qFUlp/HJBgRJffjjV3J3UEC3cIZ06aXXo5JN2nEz1VEJsVtBy0XflUnkn5WMtq2pNYna03QaPEj7AFMEYYoeH+jSUC/82uRy+xACDH/Rtgn+8N0x7eVmxC9xF3YMH27phaKFxLwjtB828u10hiWBg+Rn29Y0USj7V2FxafVcDhie+sYcSNjty2N86cyzwYvRjh+beD8JG0TZNpTXuONf0bjViKApyz1zgCf+2CXguZy/OqPYfDQW6Cs0uw+y78PnVaqt9oSWzm75hy7S/tGP/cvaaKPJPb164P0HYNxZ9kKJ4bXgpq7HIG9IvtcmrZHXSV2In4Rawrp/SfjV/v/etYQHb69EB6fHxt34sOmuIgHXbtyO9+FhYODrt/8ILbOunZNV6wB3Zs/PitYlil2bstNOVguA8/gzN21sQRGNfaSfIkwncdr55vxRH0Au19ftOh6xUdjJHQIY/TOoxql03587B67Mg2FjqiEf28v/iOiHbJGCdSFnR7EX/8zIK9T1hIG5zJCcvqFKFcv6uVsNbcNzqNo4jKFN2OCD brRaYR1I NYQdrGlVt8uvx/QtHN2JRCERme1DITV1ToamLYibtcrHYLeSHHv5TVsIitsI0aB0D+Sl/UrGkknwVc12EgABFTSwacwtRG7Xm65rDxTf7GMQsvrAWotXdUfjq0rXybFj1dX+Qaev0iz+CPU9BgASdlxkNkfTth5VFQz5f5TAy23gjV2qhw1sWklRuj6kwJVeXMc5yXPsNvsURHYk22CH4aTY7S0x72utZ+truLu+UiT5S95yvFjcxa/kL/KHQ1I2ZDQ8PLZbpFFbrMbnCbgBbEMF87a8SaYD5TuWvn10brtk+qFfFMROsTfmQL3GEcm4/Ph64eQnpcB2iG6DELMFxhUTBs8k9kRNAo0cDU0I/UER6/ivRBe2mdTfZsZa0kZ0lQ/d83ABk0HapoNjwQixIGsE6G2r5OiZ0ILHQCceMZ17FBof55QEpSHSex1J53sR/B0Cdt+c3BAIMcnnhahBR9cOj86irqsxzCQ5oAHoYrZ4ougHvnSVcoVpYm7E2vmNV/DMuyYgu6TSmo4K8mY2FfgpFAoF6CsQPijqQ9BOnNOg83dccWB8qbyCvbIxZi8Da0HfQx6C+fOj99PesuUb55CX+ERaKUs7TI5lsVvnXRqCGQIyrkKal0hkzZvcmF2uT6jNq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 29, 2023 at 4:58=E2=80=AFAM Johan Hovold wro= te: > > I have not tried to figure out exactly why things break, but it does > seem like this one should be reverted. Yes, I have done so. However, can I ask you to just verify that it was purely the exclusive open part, and it wasn't that I messed up something else. IOW, can you replace the return exclusive_deny_write_access(file); in prepare_file_for_module_load() with just a "return 0", and remove the allow_write_access(f.file); line in finit_module()? That's obviously _instead_ of the revert that I already pushed out, just to verify that "yup, it's that part, not something silly elsewhere" I do wonder what it is that is different in your setup, and maybe you could also enable the pr_debug("finit_module: fd=3D%d, uargs=3D%p, flags=3D%i\n", fd, uar= gs, flags); in finit_module() while you are at it? Since you'd be editing that file anyway for the test, just change the pr_debug() to a printk() and then do dmesg | grep finit_module to see what it all results in (on a working kernel, of course). Linus