From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF38C04A95 for ; Sat, 22 Oct 2022 17:54:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45E5C8E0002; Sat, 22 Oct 2022 13:54:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E7438E0001; Sat, 22 Oct 2022 13:54:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 288168E0002; Sat, 22 Oct 2022 13:54:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 153658E0001 for ; Sat, 22 Oct 2022 13:54:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D0465140CB3 for ; Sat, 22 Oct 2022 17:54:01 +0000 (UTC) X-FDA: 80049333882.04.468BD97 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 7766140014 for ; Sat, 22 Oct 2022 17:54:01 +0000 (UTC) Received: by mail-qv1-f53.google.com with SMTP id x15so4007947qvp.1 for ; Sat, 22 Oct 2022 10:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rgLpFIIE2aPgmTNZinvyigEE7kGZEoRibGl5oSMNQ84=; b=J/lkd67149Vhqhufch337lcLPNf/88EFFoIaF3DdnYH/DQ8/ECfW2s1cw1jdx5SpAX HCvYU0u+W4Nwm/zpNIufOTFsC3jTxdqLQ3psztUzbTW7+mpUqP/ChqUYt2lO/YDsE4ly WYlFFNbWB+KMXFaWZgL7KKZiKQa7z06LxPjnA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rgLpFIIE2aPgmTNZinvyigEE7kGZEoRibGl5oSMNQ84=; b=gHjQYeUXGLIeLcWodHZIg2ReECPFoarylOFF4NOSwshxTmEG4Xpl+KCmxaPz4resx9 EARYONyX3StTeQEcfq+d3haF6wETkg1SCsHgs2/Wod0kHHr/F0ILwX518cc2OxjH4qOK UIwDLB474WNbqTvi+y1eVuQeDeHj6hsv92FSooEwcg0e71KX9pHPlG7Nnmr3Ih29CaXD nJ2ypq/vqqTtz1XdUh6iQKMvJxxqmhNtY3BqKcuxPqMD1Yzp+HKMb0cfh11r4/VMlsdN 63MNAuCTH1ptDuh+z02LITRbLES0ELXNgDiGlIfNSdLrOkGN7EhDejR3S35VGG16RbAV /HQw== X-Gm-Message-State: ACrzQf0jh65LdxaT0HZOz3xIYYpzDm3+F7EUG/m51PQgoyuLiixLMEjt a1sSniHIu6yKOxWD+IOBxhTL48XTSm4jyg== X-Google-Smtp-Source: AMsMyM51rygJ+7s1L/YWBH7yNhS8SGBQjUQRCET9XPF1PiPJFRKcggyxIZlSj/kZ9NBGrE+ZHYYq/g== X-Received: by 2002:a05:6214:268a:b0:4bb:62a8:990 with SMTP id gm10-20020a056214268a00b004bb62a80990mr2090008qvb.75.1666461240525; Sat, 22 Oct 2022 10:54:00 -0700 (PDT) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com. [209.85.128.171]) by smtp.gmail.com with ESMTPSA id b1-20020ac87fc1000000b0039cc47752casm10450758qtk.77.2022.10.22.10.53.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Oct 2022 10:53:58 -0700 (PDT) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-369426664f9so51434067b3.12 for ; Sat, 22 Oct 2022 10:53:58 -0700 (PDT) X-Received: by 2002:a81:555:0:b0:36b:2d71:5861 with SMTP id 82-20020a810555000000b0036b2d715861mr3070116ywf.340.1666461237942; Sat, 22 Oct 2022 10:53:57 -0700 (PDT) MIME-Version: 1.0 References: <20221022111403.531902164@infradead.org> <20221022114425.103392961@infradead.org> In-Reply-To: <20221022114425.103392961@infradead.org> From: Linus Torvalds Date: Sat, 22 Oct 2022 10:53:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/13] x86/mm/pae: Be consistent with pXXp_get_and_clear() To: Peter Zijlstra Cc: x86@kernel.org, willy@infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, kirill.shutemov@linux.intel.com, jroedel@suse.de, ubizjak@gmail.com Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666461241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rgLpFIIE2aPgmTNZinvyigEE7kGZEoRibGl5oSMNQ84=; b=L2Yi4o0SvY3x4FR6Sh+CujoLM0c+LHRBuVZTwDKfAYktZeJxuaZnDi4h1JST0ygDjU+EuD UV7mcIJ1EF2l+GWPIuyYBAzP+inoGeMAHrojr2OTXEVFR5h+SBIhfzn2zhuGX2+7u8hllE a5pXFdS47N1ZAnoM4NG9sQ5+l5NFjl8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="J/lkd671"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666461241; a=rsa-sha256; cv=none; b=nMupdwhEmPfsdtOP+Czvodh1CUTT6cXWMLyQn+qex82Ihuc6gG2AYdYmluZVrGzqFBF9bL +k3ePrRKr9JSg/rXbLaHJY8QP7fTA2++vtQJg7zIsv5rpDZrCkmHIK781U/373m7n74G7h kfqVWwF8hgkNiJFAPLJrVe1kLE6WCeA= X-Rspam-User: X-Rspamd-Queue-Id: 7766140014 X-Stat-Signature: pczcz35c3kfufo3riaji7ky8c7xsrufz Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="J/lkd671"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspamd-Server: rspam07 X-HE-Tag: 1666461241-539075 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 22, 2022 at 4:48 AM Peter Zijlstra wrote: > > + > +#define pxx_xchg64(_pxx, _ptr, _val) ({ \ > + _pxx##val_t *_p = (_pxx##val_t *)_ptr; \ > + _pxx##val_t _o = *_p; \ > + do { } while (!try_cmpxchg64(_p, &_o, (_val))); \ > + native_make_##_pxx(_o); \ > +}) I think this could just be a "xchp64()", but if the pte/pmd code is the only thing that actually wants this on 32-bit architectures, I'm certainly ok with making it be specific to just this code, and calling it "pxx_xchg()". I wonder if there's some driver somewhere that wanted to use it, but just made it be depends on CONFIG_64BIT instead, or made it use a cmpxchg64() loop because a plain xchg() didn't work. I guess it really doesn't matter, with 32-bit being relegated to legacy status anyway. No need to try to expand usage. Linus