From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164BAC4332F for ; Mon, 7 Nov 2022 23:48:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D83B8E0001; Mon, 7 Nov 2022 18:48:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 788AD6B0075; Mon, 7 Nov 2022 18:48:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 628D58E0001; Mon, 7 Nov 2022 18:48:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 55A0C6B0074 for ; Mon, 7 Nov 2022 18:48:01 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1DEFCAB5A2 for ; Mon, 7 Nov 2022 23:48:01 +0000 (UTC) X-FDA: 80108286762.22.A193A22 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf16.hostedemail.com (Postfix) with ESMTP id BADA1180005 for ; Mon, 7 Nov 2022 23:48:00 +0000 (UTC) Received: by mail-qt1-f173.google.com with SMTP id cg5so7826470qtb.12 for ; Mon, 07 Nov 2022 15:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2nUGmNm82TyRLx97jZms1dOOGi76NwVe8JFuVeWiOQg=; b=My5uqWQwXOffTiWXNHqYQhulwxGxYGEm7K9+0FNU7iSCJTiHIpLKcqjmRdDQF+ZBkb Pg1ba84w3LhFXgshAIEFlqw202AajwYhP3vp8snD7MElUpy1fGUKi0JL4ot9xEL1OZHD srxGnutg7uHNcTHztzXfNg/I2NN1QnphRTqmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2nUGmNm82TyRLx97jZms1dOOGi76NwVe8JFuVeWiOQg=; b=58cbKyDnkoNLKSd9ICvcmiKuX54GIbUgrLjxPwPKkv4wgxYiM9a6qCM63y6omoWMGG qej5SmPKr3yoTJBudzF0fuSEDXrjjNIXSBj2xK/f+Rlf+iNcQk8eGkdNs+I7gSBJHNFw Z3oz4RmW0lelhD4jsDW4xDqo2yA9HXaC/yHgy3vrqy7Xd3/dpeBk5aIiiyKRCWEd53z3 8F6SFgYbM/2cgYwnIT3X/UFGVDKyuKorDLofsSe/fXwhNiehsPkBM/KHjQOw9bk6NgTj e57bBHNCRqltp0j2PViWjenPa6AUKpdsZnvSCvWqAqKIHGwKoQVHRpDcdZO47O+amEVp 6WXQ== X-Gm-Message-State: ANoB5pk3jHUzO3kzifCeBnGx5JV98h9Wig1gmHBQpOl9goR9JIyAO5Ug 6SI9LUQnQWYGrxLU8QHG0G0nkaEALncwqg== X-Google-Smtp-Source: AA0mqf4Gx1Rg+mg/oNISJ7oPGV/VZXWew3dUNMpw9Gy29Fuio3VOqlNVcl4KQG5S0VAJDFMJegaJ6g== X-Received: by 2002:a05:622a:1344:b0:3a5:8520:5381 with SMTP id w4-20020a05622a134400b003a585205381mr7177050qtk.341.1667864879833; Mon, 07 Nov 2022 15:47:59 -0800 (PST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id de4-20020a05620a370400b006bb29d932e1sm2834321qkb.105.2022.11.07.15.47.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 15:47:56 -0800 (PST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-36ad4cf9132so119623027b3.6 for ; Mon, 07 Nov 2022 15:47:55 -0800 (PST) X-Received: by 2002:a81:114e:0:b0:36a:fc80:fa62 with SMTP id 75-20020a81114e000000b0036afc80fa62mr51708860ywr.58.1667864875345; Mon, 07 Nov 2022 15:47:55 -0800 (PST) MIME-Version: 1.0 References: <8a1e97c9-bd5-7473-6da8-2aa75198fbe8@google.com> In-Reply-To: From: Linus Torvalds Date: Mon, 7 Nov 2022 15:47:38 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mm: delay rmap removal until after TLB flush To: Johannes Weiner Cc: Hugh Dickins , Stephen Rothwell , Alexander Gordeev , Peter Zijlstra , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Nadav Amit , Jann Horn , John Hubbard , X86 ML , Matthew Wilcox , Andrew Morton , kernel list , Linux-MM , Andrea Arcangeli , "Kirill A . Shutemov" , Joerg Roedel , Uros Bizjak , Alistair Popple , linux-arch Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=My5uqWQw; spf=pass (imf16.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.173 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667864880; a=rsa-sha256; cv=none; b=vQHR1SWEwhCqUlmI1nLT1Z07/64NDDTPS4wZ59H4B1PhRNV2l9q68cETLgBU4WAuBFSdcn sUyhaQPjZMvez6MEkwkRG4IEplA8NN/Cit8O679PcWKu1x1ZPyYKp/JzD6a319X+VtNQDt ksjBjQBJjDOOqX/bqA/qrEkhJBB4EXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667864880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2nUGmNm82TyRLx97jZms1dOOGi76NwVe8JFuVeWiOQg=; b=A8PiyM6I8eTTepxRfc8N1pP/4XMe+ovrV4t2a1AYvO1p4T//EhZ6Y8EwdlzNMOpw6LKxcN crSIfvtFfPJzXI+f+XZIz/vY7iOXwcgkbn823HHhnc7NIv1s21YCAM8bVtdu+lgfgVqVfb VZ43PxjHZODMymm4q828cTDYvFXPlDE= X-Stat-Signature: c7fx6j6w5zkwzz8yekjrpgn6qzw5hbch X-Rspamd-Queue-Id: BADA1180005 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=My5uqWQw; spf=pass (imf16.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.173 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1667864880-466063 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 7, 2022 at 12:29 PM Linus Torvalds wrote: > > That said, if always doing the rmap removal under the page table lock > means that that memcg lock can just be deleted in that whole path, I > will certainly bow to _that_ simplification instead, and just handle > the dirty pages after the TLB flush but before the page table drop. Ok, so I think I have a fairly clean way to do this. Let me try to make that series look reasonable, although it might be until tomorrow. I'll need to massage my mess into not just prettier code, but a sane history. Linus