From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4719DC02199 for ; Sat, 8 Feb 2025 03:22:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FBBA6B008A; Fri, 7 Feb 2025 22:22:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AC226B008C; Fri, 7 Feb 2025 22:22:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 874846B0092; Fri, 7 Feb 2025 22:22:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6A8646B008A for ; Fri, 7 Feb 2025 22:22:39 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E9A31A15D7 for ; Sat, 8 Feb 2025 03:22:38 +0000 (UTC) X-FDA: 83095329996.10.0EF551A Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf19.hostedemail.com (Postfix) with ESMTP id C76561A0003 for ; Sat, 8 Feb 2025 03:22:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=OEmVKMeO; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738984957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HSnuYIJ812yAAamMzrkn+g6HCJ6wuJGWXwYClw24Ku0=; b=wcEdCE7hoO57kLRdPyPrNXOVArnbvZiu+zSO26NfMhDfDf3NVH8+0jqRR4RHMGiJkB/eBM 35mYChUFEY4WGw8bTk0B0cQY0j7u+cDBaDQ4ErlMK2ooup6FVZlO2LdOFRIirrXIA2UEz9 Ex6A1zBKbxC/xL/ouIaEtI0rivAKKaU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=OEmVKMeO; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738984957; a=rsa-sha256; cv=none; b=63ZOmmUavCDkcagRw3IOclXVDnbPaofNVev8pVKQIOmULv1KEi1a96RX11cmDPatV68ZNT UUsTpF4nFI3VsYi4aDP5j0l3H4yGFvYRmqskvTqC/hqsdUPqCg6zblmjKQGJZOzXBNCwCz 11GS99kS0TWLgURa4zmG7NHE7L026C8= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5dc89df7eccso5372379a12.3 for ; Fri, 07 Feb 2025 19:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1738984955; x=1739589755; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HSnuYIJ812yAAamMzrkn+g6HCJ6wuJGWXwYClw24Ku0=; b=OEmVKMeOCRi67qFsg78WKSausDOkUUr+oKWqvuj7o2vn4t1jxXXDloK3Momktf1mRB 7WnfvWzLAAGm5X3J7IWSvf0s6rgdWg2p2Jt8C6Tg/6m8PCxY+SiTZimtkb77WXnwIk0G Snlv+Z4LtoWBYGiFCbgGnBLxDznzntqzWO8No= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738984955; x=1739589755; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HSnuYIJ812yAAamMzrkn+g6HCJ6wuJGWXwYClw24Ku0=; b=J5peP6KXlCOj3E2o82iPtHkUnt9hsrgKjFfr7/8KwqzvU27xnABnG5i8XhuSuFVIdO mUrlPNGvS6yzr8X+CZs2oYP+43hxNKBn6iuS+obw3hJk6HuxS1eWgoj51glQNvjYmSxR 9F2Y9SzZutg4a9kYv8TaYpiEYRVAkkRorr7Htht7ByKu9bFX8sq95kkeEAXqUxWVdEnv ozGaSQgO9KCOWdDHKTZaMgS13hXJ1eAXPcP6RnciDlwepnS9ovPLIzIjf/uodqzV3A8n FHZIUFvddsNvezBzfQAjfadRcl2GAVQ7HrmVK1KVD9Fg03U3SxfY1AqMTNNQrYO+wuxN Nxzw== X-Forwarded-Encrypted: i=1; AJvYcCUIQcpErq/OT1J6IaRoCvHPOZHbgVV0og0+k8HfLeVqGKGV91ljVD/9OUkRSEudf0I30ZRs7zWaIw==@kvack.org X-Gm-Message-State: AOJu0YxxE9WnD/kA0MWtUQZ3vbVgnquy0Sf/6M5HspVPw466sx7W+Frn uooFp7aB3oxyNvlVJx/OC4VWx8u7qs6SHdUTrVXm/TVwaCd8/iF0mb16UyplWRFfoog0/s7bp3N W+jErFg== X-Gm-Gg: ASbGncsx030YSHBF5zDvgXzGupoWddrtH1tOvDBl4RM3OY+5kllnegBHEtsIHV3ShfE 43BXVjuG6Ka41ufR1v65wdJYLYnMFJ79atIDmNZUqo36r5gPwI0jOiRl/mVfAj+HPyS/8j+S6iA dpBeAaYJJMo/Mnhg0+dszueWM8wO1wcUECUoDIWhI/KJoisRo/WbNTPWLKuHqEWZwKbcfAwspYg R4wsu/KE033PfxIjtrj4Cn2GSozzvLlyR79bqgP5rbD2LJcP1nJ0W5gtyaFgv4boCYZRXCMF+N3 aX9d+W8zE7WJCvoX/aDqhJLM7nWnMXrLnLIImkPaSzj983O3aC7i1O6k5lI1KLmBsw== X-Google-Smtp-Source: AGHT+IH0ft6fJJ5hY3UfLZNbfjQUCO+FQwon1tizUaJ1iQPtUCctR0T6lGL+bb5pSYkZWVSiH1tesw== X-Received: by 2002:a05:6402:1e91:b0:5de:39fd:b2ff with SMTP id 4fb4d7f45d1cf-5de44e5da3bmr7422025a12.0.1738984955192; Fri, 07 Feb 2025 19:22:35 -0800 (PST) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com. [209.85.208.54]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de5b2e4497sm703233a12.47.2025.02.07.19.22.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2025 19:22:33 -0800 (PST) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5dc89df7eccso5372351a12.3 for ; Fri, 07 Feb 2025 19:22:32 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX+cBaRDpC0Kz8AYLV4pnxZQKKFKQrqZJZ8fD1TMRmG4VQwM3f7N0ne/PxualvMIU2YA0pl0MXsxA==@kvack.org X-Received: by 2002:a05:6402:34cc:b0:5dc:c869:da53 with SMTP id 4fb4d7f45d1cf-5de458cde76mr5216130a12.31.1738984952258; Fri, 07 Feb 2025 19:22:32 -0800 (PST) MIME-Version: 1.0 References: <20250131191231.1370466-1-bvanassche@acm.org> <20250207164926.6daeac77@kernel.org> In-Reply-To: From: Linus Torvalds Date: Fri, 7 Feb 2025 19:22:15 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZmJpxMc1mtuA93TeKT6LZopGY_iCyLs2z63uV786Mm5F4PtOwTLUl6zrS4 Message-ID: Subject: Re: [PATCH] mm: Fix clang W=1 compiler warnings To: Bart Van Assche Cc: Jakub Kicinski , Andrew Morton , linux-mm@kvack.org, Ivan Shapovalov , Vlastimil Babka , David Laight , Nathan Chancellor , Pasha Tatashin , David Rientjes , David Hildenbrand , Kaiyang Zhao , Joel Granados , Sourav Panda , Johannes Weiner Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: ygoeyar8gs4rm7ygtwf7zqye33d1a7rd X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C76561A0003 X-HE-Tag: 1738984956-879232 X-HE-Meta: U2FsdGVkX196RirYmgqFTC/uHAiXwD4WNA4nmY1/9iGnjJSonSiKRvZ0Q9JUcIjFd1yKYp1oTwfmB722K8Bs+nSOnSXLIFsWjiCySdDtuy9Sq0ljUf0LR16qdetFBBNSuJQY0LHC5O7MFe1uWfSPAYUVXfIfDyGjsbjcw8wJdU1TJZdimE5QlwFTR1FhR+9tmZSMeXsVVl7uf1xrNFVOMvrKluLMQssmMhfZo2Qn30MvZY0i7XjjcsnJ9Hoxojdi7Q1aocEkaw/aGOQhaG0vvwG7CmQghObDYmN3OZ+Qaw2z21CsSNWwT1gTOM8ti6Zlao5+V+YOaOkD05nAYgRRSSD2CzXpcQLBIrcMXCNLKjfXj6SeI2oarX8eM1m07XtHZDtaued41XLuxHfRFF00HdW+FfT3zT+4jGtHNrY7v3PKLGYvdCY9oda8PBkHvhhXb2zkYTF0TpqgmO/Sj0JnfPTN5WSJeSAdoFR6+En46weZvdgB0oZCDSqgqJeSxJkF1/UM3yI97Q4LS3vHzi0NbQsi29AZCuWa3UMupE7xcZ0UvWxLYiiQTnQKtndflKGuEV7iC774+BqOSXGImd9D5oGA/rTcLdEpcykjABZxFoTLurBfK4NIledXi1uluZ8QSmzospwRq359iV3UuSAzzNpD+k3FqGIPUo5VVPXUX7WWaGa24leLMzYdqxeqVIX0TBegVUGwMcIvbaHkjYXXLRdNNcYp7TT6hI95hh0dqBIw8AQ9p6VqEIXfEne86Dq/zV9QlstplWBXc36cnFN5U7vRUQPcD4AcF4fHWAdnXntrylouidzUF44FoJnEmWwJA5eAtYmXEjETKrmT7Nun8dDjZvG7O+xkgoHlHNzx9jas6kM7tQQ5KL+rNV3MsPlXF+YM6pmt5GVRn7Dyh3ajecCa5gqPpA3n2KfQ44SzgMWn5bK5Q+epM/1y1EVYm/MgjfKHpEdtSZ4eBz9yg4V UwtPLv54 kFzjOKl55xNmWzjLPrp/yLFmNpFl6yu9CWmZX1Izfp8BH/7s0QRMfIWxPhbQsDbBPxD3Dh4ix3RrJBA565ValGR5OUbMLkoZs9QtADpM3iZVWbh+/42g4g0jxPLMuHqWipd+50zBs6I3UubqOer01lIk6zDc1GPtqctoAAY+2N3zTqDfJjYkIR7nDxgJdyIMaW+NviY+G7ZMMnmfY+8b1LN09Eur3SanYR68KFkWtkvzt4toB5Rtu5rIgO6LfkS5MrXUFBI8YyHDa0GB/UadEX7l36TTjLuoIX+a1JPHLLWZ1xqNpnd/QiQc3zGbmJOH0qTdwvjnwR9BNT0vzsehFtFzUkCStIF6Bt/vNP4ecEYNOCjyUqYoLHnMcUahy61jHmoQ4gYPrq/YUd19WF+cjR2/f/ih86HPFpnC87RHqz8PXORn+xgVr1Vr59N4RxsQ2UY84F3Vs4rz0tyuWI2cV1lbgpwDKbrWSYbSstXh7egmxr4UYdFaLzbXbYZbwdR0uqp3Ux3/Vgb6HTTRPainMpDSdFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 7 Feb 2025 at 18:56, Bart Van Assche wrote: > > Since the patch at the start of this e-mail thread is a follow-up for > commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning"), do > you perhaps want me to submit a revert for that commit? So I _think_ the proper fix is to just disable the warning (or move it to W=2 like apparently Nathan did - crossing emails left and right here), and once that is done, yes, reverting that commit too. That said, I'll repeat that while I think using enums for values that then get used for arithmetic can actually be a good thing, I'm not entirely against the notion of saying "let's limit ourselves". So if it's _so_ rare that these are the *only* cases of that warning happening in the whole kernel build, then I'll just concede that while I still think it's a fine pattern, if it's *so* rare that we only had two cases of it, then it's worth fixing those two cases. Because at some point "really really unusual" might be worth warning for, even if the unusual case isn't wrong per se. But I don't have any visibility into whether this is just one header file fix and we're done, or whether it's actually more common, and the one header file case is just a "this causes lots of noise because it's included everywhere". Linus